[Bug-wget] wget wait_ares void value not ignored

2018-08-24 Thread Endre Hagelund
Hi I've encountered a bug when compiling wget 1.19.5 from source with the following command: ./configure --with-cares && make Compile fails with the following error message: host.c: In function 'wait_ares' host.c:735:11: error: void value not ignored as it ought to be timer = ptimer_destroy

Re: [Bug-wget] wget wait_ares void value not ignored

2018-08-24 Thread Tim Rühsen
Thanks, it has been remove on 8th of March 2018 (commit 7eff94e881b94d119ba22fc0c29edd65f4e6798b) Regards, Tim On 08/24/2018 09:39 AM, Endre Hagelund wrote: > Hi > > I've encountered a bug when compiling wget 1.19.5 from source with the > following command: > > ./configure --with-cares &&

[Bug-wget] [bug #51666] Please hash the hostname in ~/.wget-hsts files

2018-08-24 Thread Tim Ruehsen
Follow-up Comment #5, bug #51666 (project wget): Thanks for addressing the issue. Saving the salt together with the (salted) hash isn't of big help when we talk about a limited set of input strings. You can get complete lists of existing domains and brute force through them in a few seconds. Can

[Bug-wget] [PATCH] Fixes for issues found by Coverity static analysis

2018-08-24 Thread Tomas Hozza
Hi. We scanned the latest version of wget (1.19.5) with Coverity static analyzer. It found some potentially important issues like RESOURCE LEAKS. I'm attaching my proposed fixes for these issues. Each commit includes the output from Coverity and the outcome of my analysis of the problem from

[Bug-wget] [bug #51666] Please hash the hostname in ~/.wget-hsts files

2018-08-24 Thread Ethan Welker
Follow-up Comment #6, bug #51666 (project wget): Thank you for your feedback. Regarding the salt: I used one because OpenSSH uses one and that was both what the original bug report references, and written by somebody likely more experienced than me Re: security. If you want me to remove the