[Bug-wget] [bug #45790] wget prints it's progress even when background

Update of bug #45790 (project wget): Status:None => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

Piotr writes: > I would like to avoid forcing users to hack like this ;). > Wget should print to std* when in fg and print to wget.log when in bg, no > matter how user gets there. > I don't think getpgrp() == tcgetpgrp(STDOUT_FILENO) is heavy and should > probaby be ok to

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

I would like to avoid forcing users to hack like this ;). Wget should print to std* when in fg and print to wget.log when in bg, no matter how user gets there. I don't think getpgrp() == tcgetpgrp(STDOUT_FILENO) is heavy and should probaby be ok to check it when printing lines. Piotr 28 wrz

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

"Wajda, Piotr" writes: > The case with stopping wget is obvious. CTRL+Z and bg should make wget > write to file and I can catch bg with SIGCONT. > But I wonder what to do when after CTRL+Z and bg, user runs fg. In this > case there's no signal between bg anf fg, Though the

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

Hi, The case with stopping wget is obvious. CTRL+Z and bg should make wget write to file and I can catch bg with SIGCONT. But I wonder what to do when after CTRL+Z and bg, user runs fg. In this case there's no signal between bg anf fg, and I can only check for getpgrp() ==

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

Hi Piotr, The patch looks fine. However, when Wget is foregrounded again, the progress bar remains invisible. When the process is foregrounded again, you should undo the effects of `redirect_output_signal()` * pwa...@gmail.net.pl [160919 18:01]: Hi Darshit, Sorry for

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

Ok, I'll fix that. Thanks Piotr W dniu 19.09.2016 o 19:30, Darshit Shah pisze: Hi Piotr, The patch looks fine. However, when Wget is foregrounded again, the progress bar remains invisible. When the process is foregrounded again, you should undo the effects of `redirect_output_signal()` *

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

Hi Darshit, Sorry for pasting patch into email incorrectly. I've send 2 other patches before, but as attachments, so they should be fine. Thanks Piotr W dniu 19.09.2016 o 17:28, Darshit Shah pisze: Hi Piotr, Thanks for your interest in Wget. I shall review your patch soon. However, for

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

Hi Piotr, Thanks for your interest in Wget. I shall review your patch soon. However, for future reference please do not send patches that are pasted into the mail like this. It makes it extremely difficult for us to apply the patch. I was unable to apply the provided diff after simply saving

[Bug-wget] bug #45790: wget prints it's progress even when background

Hi, I've implemented fix for bug #45790. Basically I used approach Noel showed in comment. Please check below diff if it's sane. diff --git a/src/main.c b/src/main.c index ac6ee2c..f324253 100644 --- a/src/main.c +++ b/src/main.c @@ -113,7 +113,7 @@ int numurls = 0; setting up gettext's

[Bug-wget] [bug #45790] wget prints it's progress even when background

URL: http://savannah.gnu.org/bugs/?45790 Summary: wget prints it's progress even when background Project: GNU Wget Submitted by: nok Submitted on: Di 18 Aug 2015 11:03:31 CEST Category: User Interface

Re: [Bug-wget] [bug #45790] wget prints it's progress even when background

Darshit Shah dar...@gmail.com writes: This affects an invokation using the shell's background operator () too. E.g.: wget http://cdimage.debian.org/debian-cd/current/multi-arch/iso-cd/debian-8.1.0-amd64-i386-netinst.iso will cause the logging output and progress bar to be displayed on the

Re: [Bug-wget] [bug #45790] wget prints it's progress even when background

This affects an invokation using the shell's background operator () too. E.g.: wget http://cdimage.debian.org/debian-cd/current/multi-arch/iso-cd/debian-8.1.0-amd64-i386-netinst.iso will cause the logging output and progress bar to be displayed on the terminal as explained in the bug report.