Please find attached a new patch incorporating your comments.
could you avoid this global? Can we propagate instead a pointer as
create_authorization_line and digest_authentication_encode param?
Fixed as a pointer that is sent to create_authorization_line and
digest_authentication_encode as a
Darshit Shah dar...@gmail.com writes:
Should we xfree_null (qop) before setting it to NULL?
qop will ALWAYS be xfree'd if it is explicitly set to NULL. The if
statement on the next line takes care of that.
sorry, I still don't understand it. Won't xfree_null (qop) be a NOP
On Mon, Jul 22, 2013 at 5:33 PM, Giuseppe Scrivano gscriv...@gnu.orgwrote:
Darshit Shah dar...@gmail.com writes:
Should we xfree_null (qop) before setting it to NULL?
qop will ALWAYS be xfree'd if it is explicitly set to NULL. The if
statement on the next line takes care of that.
Darshit Shah dar...@gmail.com writes:
Fixed the SIGSEGV issue that propped up. It was caused because wget
entered a code region that it should never reach in that use-case. Was
occurring because I replaced qop = NULL with xfree_null (qop) instead
of xfree-ing qop and then setting it to NULL.
Hi Darshit,
I have few comments inline:
Darshit Shah dar...@gmail.com writes:
diff --git a/src/http.c b/src/http.c
index b2a03c8..64929d7 100644
--- a/src/http.c
+++ b/src/http.c
@@ -146,6 +146,7 @@ struct request {
};
extern int numurls;
+uerr_t auth_err = RETROK;
could you avoid
Am Donnerstag, 18. Juli 2013, 02:32:21 schrieb Darshit Shah:
I see no wasted cycles in here.
Sorry, my mistake.
And you are right, a bit code cleanup wouldn't be too bad.
Tim
signature.asc
Description: This is a digitally signed message part.
I guess you are talking about calculating 'hash' two times when
algorithm=md5-
sess.
No, I was in fact talking about the two blocks of xfree statements. Maybe
we could somehow unify the blocks.
That is indeed unneeded. It should be like:
As far as I see it, the code seems perfect there.
Attaching a patch that fixes the above stated issue.
There are two regions that I would like to draw attention to:
1. http.c:3752 : The code is quite redundant and I would prefer that it was
somehow merged. Ideas on fixing this would be greatly appreciated!
2. http.c:2424 : There is a simple
Am Dienstag, 16. Juli 2013, 20:52:01 schrieb Darshit Shah:
There are two regions that I would like to draw attention to:
1. http.c:3752 : The code is quite redundant and I would prefer that it was
somehow merged. Ideas on fixing this would be greatly appreciated!
I guess you are talking
Am Montag, 15. Juli 2013, 03:34:46 schrieb Darshit Shah:
Wait, this is all Client End. Wget already has NTLM client-end support.
I need to write a Test Server for it.
There seems to be an Apache module for NTLM at
http://modntlm.sourceforge.net/
You should put writing an own NTLM
Am Sonntag, 14. Juli 2013, 19:02:36 schrieb Darshit Shah:
Hi,
In http.c:3739, we club 3 different error types in one.
1. The Server did not send a nonce / realm / uri attribute in the
WWW-Authenticate Header. This should exit as a Protocol Error, Status 7
2. Wget was not invoked with a
May I perhaps suggest you consider using libntlm by our friend Simon
Josefsson? http://www.nongnu.org/libntlm/
Thanks a bunch for that resource! This is however written in C and I need
to implement it in Python for the test server. I guess I'll write Python
bindings for this.
Be prepared to
On Mon, Jul 15, 2013 at 3:33 AM, Darshit Shah dar...@gmail.com wrote:
May I perhaps suggest you consider using libntlm by our friend Simon
Josefsson? http://www.nongnu.org/libntlm/
Thanks a bunch for that resource! This is however written in C and I need
to implement it in Python for the
13 matches
Mail list logo
