Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress even when background

2016-10-19 Thread Eli Zaretskii
> From: "Wajda, Piotr" > Date: Wed, 19 Oct 2016 11:57:06 +0200 > > My only confusion was that during testing on windows, when sending > CTRL+C or CTRL+Break it immediately terminates, which is basically what > I think it should do for CTRL+C. Not sure about CTRL+Break. What else is reasonable

Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress even when background

2016-10-19 Thread Wajda, Piotr
Sorry, I had the impression there was some discussion going on !? My only confusion was that during testing on windows, when sending CTRL+C or CTRL+Break it immediately terminates, which is basically what I think it should do for CTRL+C. Not sure about CTRL+Break. But the same behaviour was

Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress even when background

2016-10-18 Thread Tim Rühsen
On Dienstag, 18. Oktober 2016 08:30:34 CEST Wajda, Piotr wrote: > Can you please review my 3 patches? Sorry, I had the impression there was some discussion going on !? But apart from that: - please add a space after if statements. - please add a space between function name and (. - please make lo

Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress even when background

2016-10-17 Thread Wajda, Piotr
Can you please review my 3 patches? Piotr On 07/10/16 10:10, Wajda, Piotr wrote: From: losgrandes Date: Thu, 6 Oct 2016 09:47:01 +0200 Fortunately I tested wget.exe in normal mode and background mode (-b). Was ok. Unfortunately I haven't tested wget.exe with CTRL+Break/CTRL+C (is it really w

Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress even when background

2016-10-07 Thread Tim Ruehsen
On Friday, October 7, 2016 10:08:08 AM CEST Eli Zaretskii wrote: > The Windows runtime doesn't have 'pipe', it has '_pipe' (with a > slightly different argument list). I believe we need the Gnulib pipe > module to get this to compile. However, just as a quick hack, replace > the call to 'pipe' wi

Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress even when background

2016-10-07 Thread Wajda, Piotr
From: losgrandes Date: Thu, 6 Oct 2016 09:47:01 +0200 Fortunately I tested wget.exe in normal mode and background mode (-b). Was ok. Unfortunately I haven't tested wget.exe with CTRL+Break/CTRL+C (is it really works on windows?). Yes, CTRL-C/CTRL-BREAK should work on Windows. What didn't wo

Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress even when background

2016-10-07 Thread Wajda, Piotr
Eli, you're awesome! :) I tried many combinations (I think so), including LIBS=-liconv, but without success. I've tried now and it works! Now I'll test on my own. Thanks Piotr On 07/10/16 09:08, Eli Zaretskii wrote: From: losgrandes Date: Thu, 6 Oct 2016 09:47:01 +0200 Fortunately I teste

Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress even when background

2016-10-07 Thread Eli Zaretskii
> From: losgrandes > Date: Thu, 6 Oct 2016 09:47:01 +0200 > > Fortunately I tested wget.exe in normal mode and background mode (-b). Was ok. > Unfortunately I haven't tested wget.exe with CTRL+Break/CTRL+C (is it really > works on windows?). Yes, CTRL-C/CTRL-BREAK should work on Windows. What

Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress even when background

2016-10-06 Thread Wajda, Piotr
Sorry for incorrect Date email header in that email, I've send it from previously suspended virtual machine that I forgot to ntpupdate. Piotr On 06/10/16 09:47, losgrandes wrote: I've updated patch to not run tcgetpgrp, getpgrp and isatty (for shell_is_interactive test) on windows. I have com