Re: [Bug-wget] Pha support for tls1.3

2019-05-25 Thread Tim Rühsen
Thanks, applied. On 22.03.19 19:15, a...@cyberstorm.mu wrote: > > Hello all, > > Apache supports Post handshake authentication with tls1.3. > > Please find the patch to enable Pha in wget in the link below: > https://gist.github.com/AviSoomirtee/22c1b698c796177d836323ef506665a5 > > Thanks. >

Re: [Bug-wget] Pha support for tls1.3

2019-05-24 Thread Ander Juaristi
Hi Tim, Looks good. Could you merge it please? Thanks - AJ On 23/3/19 18:04, Tim Rühsen wrote: Thank you Daniel and Diresh. I don't think we should send the post handshake extension in case no client certificate is given. The OpenSSL documentation is pretty silent about what happens when a s

Re: [Bug-wget] Pha support for tls1.3

2019-04-30 Thread Ander Juaristi
Hi, Let me test this against gnutls-cli (with --post-handshake-auth), and I'll tell you something ASAP. It's a short patch, shouldn't be too hard to verify this. On 23/3/19 18:04, Tim Rühsen wrote: Thank you Daniel and Diresh. I don't think we should send the post handshake extension in case

Re: [Bug-wget] Pha support for tls1.3

2019-03-23 Thread Tim Rühsen
Thank you Daniel and Diresh. I don't think we should send the post handshake extension in case no client certificate is given. The OpenSSL documentation is pretty silent about what happens when a server requests a post handshake. What I found is that some kind of callback function is mentioned, b

Re: [Bug-wget] Pha support for tls1.3

2019-03-22 Thread Daniel Stenberg
On Fri, 22 Mar 2019, Tim Rühsen wrote: Are you sure that '#ifdef SSL_CTX_set_post_handshake_auth' works ? Here with OpenSSL 1.1.1b it seems that 'SSL_CTX_set_post_handshake_auth' is a function and not a #define. In curl we use this #ifdef magic for figuring out if the function is present: #i

Re: [Bug-wget] Pha support for tls1.3

2019-03-22 Thread Tim Rühsen
On 22.03.19 19:15, a...@cyberstorm.mu wrote: > > Hello all, > > Apache supports Post handshake authentication with tls1.3. > > Please find the patch to enable Pha in wget in the link below: > https://gist.github.com/AviSoomirtee/22c1b698c796177d836323ef506665a5 Thanks for sharing. Are you sure