Re: [Bug-wget] bug #46584: wget --spider always returns zero exit status

Darshit Shah writes: > Apart from the patch format, the patch itself looks good. > > @Giuseppe: We will require Copyright assignments for Piotr right? This > patch may be small, but there are a couple others in the pipeline. yes, I think we will need that. The sum of all the

Re: [Bug-wget] bug #46584: wget --spider always returns zero exit status

It's correct. That is because `git format-patch` is often used together with `git send-email`. It formats the patch as an email that can be directly passed to your MUA. What you sent is a correct form of the patch that is easy for us to apply. However, notice that you sent the patch on the

Re: [Bug-wget] bug #46584: wget --spider always returns zero exit status

Apart from the patch format, the patch itself looks good. @Giuseppe: We will require Copyright assignments for Piotr right? This patch may be small, but there are a couple others in the pipeline. * Wajda, Piotr [160916 22:48]: Hi, I'd like to start contributing to wget.

Re: [Bug-wget] bug #46584: wget --spider always returns zero exit status

I'm not yet fully familiar with git format-patch (weird for me that it's adding email-like headers. Is it suppose to be email creation tool for patches?), I believe it will work for you. Thanks Piotr W dniu 19.09.2016 o 18:56, Darshit Shah pisze: Hi Piotr, How did you create this patch?

Re: [Bug-wget] bug #46584: wget --spider always returns zero exit status

Hi Piotr, How did you create this patch? Because git refuses to accept it. Patch format detection fails. Please regenerate all your patches using `git format-patch` so that we can apply the patches locally. * Wajda, Piotr [160916 22:48]: Hi, I'd like to start