[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499
Bug 61499 depends on bug 63010, which changed state.

Bug 63010 Summary: mod_proxy_hcheck when health checks configured, esp. vs down 
service, consumes large memory
https://bz.apache.org/bugzilla/show_bug.cgi?id=63010

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499

Christophe JAILLET  changed:

   What|Removed |Added

 Depends on||63010
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Christophe JAILLET  ---
Closing because the reported issue (i.e. regression in 2.4.27) has been fixed
and confirmed (see comment #6)

The memory issue is already reported in bug 63010, so I've just added a
'Depends on tag'


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=63010
[Bug 63010] mod_proxy_hcheck when health checks configured, esp. vs down
service, consumes large memory
-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499

AK  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #9 from AK  ---
Memory consumption started to rise after the patch was applied. There were no
this problem before the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499

--- Comment #8 from Graham Leggett  ---
Backported to 2.4.35.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499

Jim Jagielski  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #7 from Jim Jagielski  ---
By "still" do you mean it was doing so before as well?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499

--- Comment #6 from AK  ---
Hi,
I have just patched version 2.4.34 (removed the line) and TCP health check
started to work. But httpd process is still consuming more and more memory. In
approx. 20 hours it rised in heap up to 20GB. I have 260 TCP hchecks
configured.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499

--- Comment #5 from Jim Jagielski  ---
Yes, it does not do the double-set for HTTP so this is likely fluff left over
from the rework around 2.4.27.

Thx for the patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499

--- Comment #4 from Dominik Stillhard 
 ---
the line i was talking about:
https://github.com/apache/httpd/blob/5bd8f20a5063f47e93fe148032ec8ffa5d04a12e/modules/proxy/mod_proxy_hcheck.c#L615

;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499

--- Comment #3 from Dominik Stillhard 
 ---
I tested this in version 2.3.34 and the bug still exists. 

The problem is, that compare to http checks, in the function 
ap_proxy_connect_backend (proxy_util.c) the backend_addr  is NULL.
Thats why we never fall in the while-loop in that case, because
ap_proxy_check_connection returns APR_ENOSOCKET then.

This is because of this line in the function check_tcp (mod_proxy_hcheck.c): 
   backend->addr = hc->cp->addr;  

But this is already done in the function hc_get_backend (mod_proxy_hcheck.c),
which is called just two lines before:
 (*backend)->addr = hc->cp->addr;

I don’t completely understand why this double-copy leads to backend->addr 
being NULL, but removing the line solves the problem.

I have tested this with http 2.4.34 and tcp checks arrive at the backend
server.
The patch (based on trunk) simply removes this line, anyway i have attached it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499

--- Comment #2 from Dominik Stillhard 
 ---
Created attachment 36143
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36143=edit
patch removing the line, based on trunk

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499

cbarb...@okta.com changed:

   What|Removed |Added

 CC||cbarb...@okta.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

[Bug 61499] TCP healthchecks failing falsely / not actually checking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61499

--- Comment #1 from Luca Toscano  ---
Hi,

it might be due to
https://github.com/apache/httpd/commit/77ebb516535eecd90b458c52647b08a4da82e84e

Any chance that you could try the 'no-proxy' variable via SetEnvIf?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org