Re: Potential memory leak in route6d

2018-06-14 Thread Stuart Henderson
On 2018/06/14 16:44, Florian Obser wrote: > OK florian@ if someone wants to commit it. Alternatively I take OKs, > too :) It's only a single struct in init(), but sure, fix makes sense, OK sthen@

Re: Potential memory leak in route6d

2018-06-14 Thread Florian Obser
On Thu, Jun 14, 2018 at 04:54:46PM +0200, Barabosch, Thomas wrote: > BTW I had a quick look at the FreeBSD [1] and NetBSD [2] sources. This > issue is actually fixed in FreeBSD but not fixed in NetBSD (should we > notify them as well right now?) sure, go ahead. > > [1] >

Re: Potential memory leak in route6d

2018-06-14 Thread Barabosch, Thomas
BTW I had a quick look at the FreeBSD [1] and NetBSD [2] sources. This issue is actually fixed in FreeBSD but not fixed in NetBSD (should we notify them as well right now?) [1] https://github.com/freebsd/freebsd/blob/master/usr.sbin/route6d/route6d.c [2]

Re: Potential memory leak in route6d

2018-06-14 Thread Florian Obser
OK florian@ if someone wants to commit it. Alternatively I take OKs, too :) On Thu, Jun 14, 2018 at 04:25:22PM +0200, Barabosch, Thomas wrote: > Hi there, > > while reviewing the code, I may have stumbled upon potential memory > leaks in usr.sbin/route6d/route6d.c. > > I think there is an issue

Potential memory leak in route6d

2018-06-14 Thread Barabosch, Thomas
Hi there, while reviewing the code, I may have stumbled upon potential memory leaks in usr.sbin/route6d/route6d.c. I think there is an issue with the two calls to getaddrinfo. According to getaddrinfo.3, the dynamically allocated structures must be free'd with freeaddrinfo: "All of the

Re: Assertion failure when adding point-to-point routes to interfaces in rdomain with deleted loopback

2018-06-14 Thread Martin Pieuchot
On 06/06/18(Wed) 16:21, multiplexd wrote: > >Synopsis: Assertion failure when adding point-to-point routes to > >interfaces in rdomain with deleted loopback > >Category: Reliability > >Environment: > System : OpenBSD 6.3 > Details : OpenBSD 6.3 (GENERIC) #3: Thu

Re: upgrade not working on -current as of today.

2018-06-14 Thread Stuart Henderson
On 2018/06/14 14:20, Karel Gardas wrote: > > Hello, > > attempt to updrade to todays' -current (CEST time) was not successful since > upgrade script looks kind of broken. > > - it lists a lot of errors of rm /dev/ running over all drives > and all letters > and > - after selecting

upgrade not working on -current as of today.

2018-06-14 Thread Karel Gardas
Hello, attempt to updrade to todays' -current (CEST time) was not successful since upgrade script looks kind of broken. - it lists a lot of errors of rm /dev/ running over all drives and all letters and - after selecting keyboard layout and after selecting drive, it simply finishes