Re: deadlock in ifconfig

2022-11-25 Thread Alexander Bluhm
On Thu, Nov 24, 2022 at 11:23:51AM +1000, David Gwynne wrote: > > we're working toward dropping the need for NET_LOCK before PF_LOCK. could > > we try the diff below as a compromise? > > > > sashan@ and mvs@ have pushed that forward, so this diff should be enough > now. This diff has been

Re: deadlock in ifconfig

2022-11-25 Thread Alexander Bluhm
On Thu, Nov 24, 2022 at 07:09:39PM +0100, Alexandr Nedvedicky wrote: > Hello, > > > On Thu, Nov 24, 2022 at 10:29:37AM -0500, David Hill wrote: > > > > > > > > With this diff against -current - my dmesg is spammed with: > > > > splassert: pfsync_delete_state: want 2 have 0 > > Starting stack

Re: deadlock in ifconfig

2022-11-25 Thread David Hill
On 11/24/22 13:09, Alexandr Nedvedicky wrote: Hello, On Thu, Nov 24, 2022 at 10:29:37AM -0500, David Hill wrote: With this diff against -current - my dmesg is spammed with: splassert: pfsync_delete_state: want 2 have 0 Starting stack trace... pfsync_delete_state(fd820af9f940) at

Re: deadlock in ifconfig

2022-11-24 Thread Alexander Bluhm
On Thu, Nov 24, 2022 at 11:23:51AM +1000, David Gwynne wrote: > > we're working toward dropping the need for NET_LOCK before PF_LOCK. could > > we try the diff below as a compromise? > > > > sashan@ and mvs@ have pushed that forward, so this diff should be enough > now. I have tested the

Re: deadlock in ifconfig

2022-11-24 Thread Alexandr Nedvedicky
Hello, On Thu, Nov 24, 2022 at 10:29:37AM -0500, David Hill wrote: > > > > > With this diff against -current - my dmesg is spammed with: > > splassert: pfsync_delete_state: want 2 have 0 > Starting stack trace... > pfsync_delete_state(fd820af9f940) at pfsync_delete_state+0x58 >

Re: deadlock in ifconfig

2022-11-24 Thread David Hill
On 11/24/22 04:59, Alexandr Nedvedicky wrote: Hello, On Thu, Nov 24, 2022 at 11:23:51AM +1000, David Gwynne wrote: we're working toward dropping the need for NET_LOCK before PF_LOCK. could we try the diff below as a compromise? sashan@ and mvs@ have pushed that forward, so this diff

Re: deadlock in ifconfig

2022-11-24 Thread Alexandr Nedvedicky
Hello, On Thu, Nov 24, 2022 at 11:23:51AM +1000, David Gwynne wrote: > > > > we're working toward dropping the need for NET_LOCK before PF_LOCK. could > > we try the diff below as a compromise? > > > > sashan@ and mvs@ have pushed that forward, so this diff should be enough > now. >

Re: deadlock in ifconfig

2022-11-23 Thread David Gwynne
On Tue, Nov 22, 2022 at 10:49:35AM +1000, David Gwynne wrote: > On Mon, Nov 21, 2022 at 08:53:52PM +0100, Mark Kettenis wrote: > > > Date: Mon, 21 Nov 2022 20:28:35 +0100 > > > From: Alexander Bluhm > > > > > > Hi, > > > > > > Some of my test machines hang while booting userland. > > > > > >

Re: deadlock in ifconfig

2022-11-21 Thread David Gwynne
On Mon, Nov 21, 2022 at 08:53:52PM +0100, Mark Kettenis wrote: > > Date: Mon, 21 Nov 2022 20:28:35 +0100 > > From: Alexander Bluhm > > > > Hi, > > > > Some of my test machines hang while booting userland. > > > > starting network > > -> here it hangs > > load: 0.02 cmd: ifconfig 81303 [sbar]

Re: deadlock in ifconfig

2022-11-21 Thread Mark Kettenis
> Date: Mon, 21 Nov 2022 20:28:35 +0100 > From: Alexander Bluhm > > Hi, > > Some of my test machines hang while booting userland. > > starting network > -> here it hangs > load: 0.02 cmd: ifconfig 81303 [sbar] 0.00u 0.15s 0% 78k > > ddb shows these two processes. > > 81303 375320 89140

deadlock in ifconfig

2022-11-21 Thread Alexander Bluhm
Hi, Some of my test machines hang while booting userland. starting network -> here it hangs load: 0.02 cmd: ifconfig 81303 [sbar] 0.00u 0.15s 0% 78k ddb shows these two processes. 81303 375320 89140 0 3 0x3 sbar ifconfig 48135 157353 0 0 3 0x14200