Re: intel(4): edp_panel_vdd_on calls task_del(9) with NULL taskq

2021-05-06 Thread Scott Cheloha
On Thu, May 06, 2021 at 02:36:21PM +0200, Mark Kettenis wrote: > > Date: Thu, 6 May 2021 21:59:12 +1000 > > From: Jonathan Gray > > > > On Wed, May 05, 2021 at 04:47:50PM -0500, Scott Cheloha wrote: > > > > > > [...] > > > > > > On a hunch I added additional parameter checks to task_add(9) and

Re: intel(4): edp_panel_vdd_on calls task_del(9) with NULL taskq

2021-05-06 Thread Mark Kettenis
> Date: Thu, 6 May 2021 21:59:12 +1000 > From: Jonathan Gray > > On Wed, May 05, 2021 at 04:47:50PM -0500, Scott Cheloha wrote: > > Hi, > > > > On a hunch I added additional parameter checks to task_add(9) and > > task_del(9) and caught intel(4) doing something strange. > > > > The patch is

Re: intel(4): edp_panel_vdd_on calls task_del(9) with NULL taskq

2021-05-06 Thread Jonathan Gray
On Wed, May 05, 2021 at 04:47:50PM -0500, Scott Cheloha wrote: > Hi, > > On a hunch I added additional parameter checks to task_add(9) and > task_del(9) and caught intel(4) doing something strange. > > The patch is straightforward: check that the taskq pointer tq is not > NULL. In the current

intel(4): edp_panel_vdd_on calls task_del(9) with NULL taskq

2021-05-05 Thread Scott Cheloha
Hi, On a hunch I added additional parameter checks to task_add(9) and task_del(9) and caught intel(4) doing something strange. The patch is straightforward: check that the taskq pointer tq is not NULL. In the current code we return early if a flag is set or cleared in the task w, in which case