Re: pax/tar: reading extended headers of > 512 bytes fails

2024-04-16 Thread Jeremie Courreges-Anglas
On Tue, Apr 16, 2024 at 03:54:41PM -0600, Todd C. Miller wrote: > On Tue, 16 Apr 2024 23:39:50 +0200, Jeremie Courreges-Anglas wrote: > > > Here's a cheap trick. Testing with path=... longer than PATH_MAX > > results in broken behavior. If you want to test this with symbolic > > links and long

Re: pax/tar: reading extended headers of > 512 bytes fails

2024-04-16 Thread Todd C . Miller
On Tue, 16 Apr 2024 23:39:50 +0200, Jeremie Courreges-Anglas wrote: > Here's a cheap trick. Testing with path=... longer than PATH_MAX > results in broken behavior. If you want to test this with symbolic > links and long linkpath=... please use the latest tar.c. > > There's probably a better

Re: pax/tar: reading extended headers of > 512 bytes fails

2024-04-16 Thread Todd C . Miller
On Wed, 17 Apr 2024 00:42:32 +0200, Jeremie Courreges-Anglas wrote: > Well the second sizeof should take care of it, or are you suggesting > PAXPATHLEN+1+1...? :-| > > char buf[sizeof("30xx linkpath=") - 1 + PAXPATHLEN + sizeof("\n")]; No, you are correct, I just missed the second one. OK

Re: pax/tar: reading extended headers of > 512 bytes fails

2024-04-16 Thread Jeremie Courreges-Anglas
On Tue, Apr 16, 2024 at 04:29:32PM -0600, Todd C. Miller wrote: > On Wed, 17 Apr 2024 00:08:30 +0200, Jeremie Courreges-Anglas wrote: > > > Indeed, spotted too late, thanks. But maybe the latter looks, ahem, nicer? > > The name and ln_name buffers are sized using it. > > I don't think

Re: pax/tar: reading extended headers of > 512 bytes fails

2024-04-16 Thread Todd C . Miller
On Wed, 17 Apr 2024 00:08:30 +0200, Jeremie Courreges-Anglas wrote: > Indeed, spotted too late, thanks. But maybe the latter looks, ahem, nicer? > The name and ln_name buffers are sized using it. I don't think PAXPATHLEN includes space for the NUL so maybe this should be PAXPATHLEN+1. Or just

Re: pax/tar: reading extended headers of > 512 bytes fails

2024-04-16 Thread Jeremie Courreges-Anglas
On Tue, Apr 16, 2024 at 06:23:18PM +0200, Caspar Schutijser wrote: > Hi, > > While I was testing jca@'s diff to make the pax format the > default for tar(1), I ran into the following bug in the code > that reads extended headers. (To be clear: this has nothing to > do with the code that *writes*

Re: amdgpu Xorg.0.log filled with flip queue failed and Page flip failed

2024-04-16 Thread Nam Nguyen
Jonathan Gray writes: > try the diff below which brings in > xf86-video-amdgpu-23.0.0..31a092ae71371fb473a3a51f70fe58e1f42e283b > > the last commit is the one referenced in: > https://gitlab.freedesktop.org/drm/amd/-/issues/2852 > >

Re: amdgpu Xorg.0.log filled with flip queue failed and Page flip failed

2024-04-16 Thread Jonathan Gray
On Tue, Apr 16, 2024 at 02:32:17AM -0700, Nam Nguyen wrote: > >Synopsis:amdgpu Xorg.0.log filled with flip queue failed and Page flip > >failed > >Category:system > >Environment: > System : OpenBSD 7.5 > Details : OpenBSD 7.5-current (GENERIC.MP) #25: Mon Apr 15

amdgpu Xorg.0.log filled with flip queue failed and Page flip failed

2024-04-16 Thread Nam Nguyen
>Synopsis: amdgpu Xorg.0.log filled with flip queue failed and Page flip >failed >Category: system >Environment: System : OpenBSD 7.5 Details : OpenBSD 7.5-current (GENERIC.MP) #25: Mon Apr 15 12:00:00 MDT 2024

pax/tar: reading extended headers of > 512 bytes fails

2024-04-16 Thread Caspar Schutijser
Hi, While I was testing jca@'s diff to make the pax format the default for tar(1), I ran into the following bug in the code that reads extended headers. (To be clear: this has nothing to do with the code that *writes* extended headers and/or jca@'s diff.) If the file name of the file in the