[Bug 62223] httpd-2.4.33/modules/cache/mod_cache_socache.c:217]: limit check in wrong place ?

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62223 --- Comment #1 from Yann Ylavic --- The goal is to not go above the '\r' here (which is the end of the buffer but still in the bounds). So you raise a good optimization point since the last apr_isspace(buffer[colon])

[Bug 62223] New: httpd-2.4.33/modules/cache/mod_cache_socache.c:217]: limit check in wrong place ?

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62223 Bug ID: 62223 Summary: httpd-2.4.33/modules/cache/mod_cache_socache.c:217]: limit check in wrong place ? Product: Apache httpd-2 Version: 2.5-HEAD Hardware: PC

[Bug 62220] RemoteIPInternalProxyList does not work after PROXY implementation

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62220 --- Comment #7 from smtalk --- 1) patch enables RemoteIPProxyProtocol by default: [Wed Mar 28 01:12:43.030981 2018] [remoteip:debug] [pid 14075] mod_remoteip.c(892): [client 185.38.149.80:40630] AH03503:

[Bug 61206] mod_ssl fails to build with 2.4.26 if openssl was built with OPENSSL_NO_COMP

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61206 Christophe JAILLET changed: What|Removed |Added Resolution|---

[Bug 50317] Possible error in mod_cache's "Avoiding the Thundering Herd"

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=50317 Christophe JAILLET changed: What|Removed |Added Status|NEW

[Bug 56569] Null CRC in gzip footer with mod_cgid and ErrorDocument

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56569 Christophe JAILLET changed: What|Removed |Added Resolution|---

[Bug 59685] [Patchset] Fix CMake builds for Visual Studio

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59685 Christophe JAILLET changed: What|Removed |Added Status|NEW

[Bug 54252] acinclude.m4 requires -lz when linking with ssl static libraries

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=54252 Christophe JAILLET changed: What|Removed |Added Status|NEW

[Bug 54949] [PATCH] mod_cache: fix uninitialized tmppath variable (can lead to crash)

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=54949 Christophe JAILLET changed: What|Removed |Added Status|NEW

[Bug 62003] [req] Add client IP to "Hostname %s provided via SNI..." messages

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62003 --- Comment #1 from Christophe JAILLET --- Shouldn't a custom LogFormat (https://httpd.apache.org/docs/2.4/en/mod/mod_log_config.html#formats) be enough? -- You are receiving this mail because: You are the

[Bug 60251] mod_remoteip discards additional address when mod_rewrite rule is triggered

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60251 --- Comment #4 from Christophe JAILLET --- This has been fixed in 2.4.x in r1767483 and is part of 2.4.24. I still leave it open because of Eric's last comment. Should anyone want to check and apply the proposed

[Bug 62220] RemoteIPInternalProxyList does not work after PROXY implementation

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62220 Christophe JAILLET changed: What|Removed |Added Status|NEW

[Bug 62003] [req] Add client IP to "Hostname %s provided via SNI..." messages

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62003 --- Comment #4 from Ben RUBSON --- Good catch ! Perhaps then we could move to ap_log_rerror() so that client IP is logged ? Or perhaps you think about a better solution ? -- You are receiving this mail because: You are

[Bug 62220] RemoteIPInternalProxyList does not work after PROXY implementation

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62220 smtalk changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #2

[Bug 62003] [req] Add client IP to "Hostname %s provided via SNI..." messages

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62003 --- Comment #2 from Ben RUBSON --- I don't think so, as all other error messages correctly show-up with the client IP. For example this one is OK :

[Bug 62003] [req] Add client IP to "Hostname %s provided via SNI..." messages

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62003 --- Comment #3 from Christophe JAILLET --- The culprit is ap_log_error vs ap_log_rerror. ^ The 4th argument should be updated accordingly. -- You are receiving this mail

[Bug 62003] [req] Add client IP to "Hostname %s provided via SNI..." messages

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62003 --- Comment #5 from Christophe JAILLET --- Can you test with r1827865? (based on trunk, but should be easy to replicate in any other version of the server) -- You are receiving this mail because: You are the

[Bug 62003] [req] Add client IP to "Hostname %s provided via SNI..." messages

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62003 --- Comment #6 from Christophe JAILLET --- r1827865 -- You are receiving this mail because: You are the assignee for the bug. - To

[Bug 62003] [req] Add client IP to "Hostname %s provided via SNI..." messages

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62003 --- Comment #7 from Ben RUBSON --- Thank you Christophe ! Let me test this and come back to you ASAP with the result. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 61695] Load Avarage problem with 2.4.29

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61695 --- Comment #14 from Jacob Lundberg --- Created attachment 35816 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35816=edit A pair of stuck processes in 2.4.33 I built and deployed 2.4.33 and after some time

[Bug 62220] RemoteIPInternalProxyList does not work after PROXY implementation

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62220 --- Comment #4 from smtalk --- Yes, the file has the IP address. We got reports from many servers, they all got broken after update to 2.4.33. I compiled 2.4.33 with mod_remoteip.c from

[Bug 62220] RemoteIPInternalProxyList does not work after PROXY implementation

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62220 --- Comment #6 from Christophe JAILLET --- s/by/but/ -- You are receiving this mail because: You are the assignee for the bug. - To

[Bug 62220] RemoteIPInternalProxyList does not work after PROXY implementation

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62220 --- Comment #3 from Christophe JAILLET --- Strange. Basically 'RemoteIPInternalProxyList' is just a convenient way to call 'RemoteIPInternalProxy'. I suppose that you have already checked 'file.lst' itself? --

[Bug 62220] RemoteIPInternalProxyList does not work after PROXY implementation

2018-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62220 --- Comment #5 from Christophe JAILLET --- Created attachment 35817 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35817=edit Patch for test Could you please try the attached patch. It is just for