Re: MBP M2 pro, !cold assert failed drm/include/linux/completion.h line 89 at shutdown

2024-08-28 Thread Mark Kettenis
> From: Stuart Henderson 
> Date: Wed, 28 Aug 2024 23:21:50 +0100
> 
> I've not run into this again yet (with a few reboots).

Well, the issue is probably real.  We have no code to "quiesce" the
drm drivers upon reboot/shutdown, so if you hit the backlight buttons
at the wrong moment, or if X is slow shutting down, you might hit
this.  Needs some thinking...

> -- 
>   Sent from a phone, apologies for poor formatting.
> 
> On 27 August 2024 23:46:46 Stuart Henderson  wrote:
> 
>  'Apple MacBook Pro (14-inch, M2 Pro, 2023)', running recent -current.
>  Not running X. I hit this after running halt -p:
> 
>  panic: kernel diagnostic assertion "!cold" failed: file
>  "/usr/src/sys/dev/pci/drm/include/linux/completion.h", line 89
> 
>  Transcribed, maybe typos:
> 
>  TID *328025, PID 16963, UID 0, PRFLAGS 0x3, PFLAGS 0, CPU 0K, COMMAND
>  halt
> 
>  db_enter at panic
>  panic at assert
>  panic at drm_atomic_helper_swap_state+0x57c
>  commit_tail at drm_atomic_helper_commit+0x1d4
>  drm_atomic_helper_commit at drm_atomic_commit+0xa4
>  drm_atomic_commit at drm_client_modeset_commit_atomic+0x158
>  drm_client_modeset_commit_atomic at
>  drm_client_modeset_commit_locked+0x5c
> 
>  After restart/fsck I tried halt -p again and it succeeded.
> 
>  OpenBSD 7.6-beta (GENERIC.MP) #160: Mon Aug 26 05:36:05 MDT 2024
>  dera...@arm64.openbsd.org:/usr/src/sys/arch/arm64/compile/GENERIC.MP
>  real mem  = 16312172544 (15556MB)
>  avail mem = 15672647680 (14946MB)
>  random: good seed from bootblocks
>  mainbus0 at root: Apple MacBook Pro (14-inch, M2 Pro, 2023)
>  efi0 at mainbus0: UEFI 2.10
>  efi0: Das U-Boot rev 0x20240100
>  cpu0 at mainbus0 mpidr 0: Apple Blizzard Pro r1p0
>  cpu0: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1
>  D-cache
>  cpu0: 4096KB 128b/line 16-way L2 cache
>  cpu0:
>  
> TLBIOS+IRANGE,TS+AXFLAG,FHM,DP,SHA3,RDM,Atomic,CRC32,SHA2+SHA512,SHA1,AES+PMULL,I8MM,BF16,SPECRES,SB,FRINTTS,GPI,LRCPC+LDAPUR,FCMA,JSCVT,API+PAC,DPB+DCCVADP,ECV,SpecSEI,PAN+ATS1E1,LO,HPDS,VH,IDS,AT,CSV3,CSV2,DIT,AdvSIMD+HP,FP+HP,BT,SSBS+MSR
>  
>  cpu1 at mainbus0 mpidr 1: Apple Blizzard Pro r1p0
>  cpu1: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1
>  D-cache
>  cpu1: 4096KB 128b/line 16-way L2 cache
>  cpu2 at mainbus0 mpidr 2: Apple Blizzard Pro r1p0
>  cpu2: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1
>  D-cache
>  cpu2: 4096KB 128b/line 16-way L2 cache
>  cpu3 at mainbus0 mpidr 3: Apple Blizzard Pro r1p0
>  cpu3: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1
>  D-cache
>  cpu3: 4096KB 128b/line 16-way L2 cache
>  cpu4 at mainbus0 mpidr 10100: Apple Avalanche Pro r1p0
>  cpu4: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1
>  D-cache
>  cpu4: 16384KB 128b/line 16-way L2 cache
>  cpu5 at mainbus0 mpidr 10101: Apple Avalanche Pro r1p0
>  cpu5: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1
>  D-cache
>  cpu5: 16384KB 128b/line 16-way L2 cache
>  cpu6 at mainbus0 mpidr 10102: Apple Avalanche Pro r1p0
>  cpu6: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1
>  D-cache
>  cpu6: 16384KB 128b/line 16-way L2 cache
>  cpu7 at mainbus0 mpidr 10103: Apple Avalanche Pro r1p0
>  cpu7: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1
>  D-cache
>  cpu7: 16384KB 128b/line 16-way L2 cache
>  cpu8 at mainbus0 mpidr 10200: Apple Avalanche Pro r1p0
>  cpu8: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1
>  D-cache
>  cpu8: 16384KB 128b/line 16-way L2 cache
>  cpu9 at mainbus0 mpidr 10201: Apple Avalanche Pro r1p0
>  cpu9: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1
>  D-cache
>  cpu9: 16384KB 128b/line 16-way L2 cache
>  cpu10 at mainbus0 mpidr 10202: Apple Avalanche Pro r1p0
>  cpu10: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1
>  D-cache
>  cpu10: 16384KB 128b/line 16-way L2 cache
>  cpu11 at mainbus0 mpidr 10203: Apple Avalanche Pro r1p0
>  cpu11: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1
>  D-cache
>  cpu11: 16384KB 128b/line 16-way L2 cache
>  "asc-firmware" at mainbus0 not configured
>  "asc-firmware" at mainbus0 not configured
>  "framebuffer" at mainbus0 not configured
>  "asc-firmware" at mainbus0 not configured
>  "asc-firmware" at mainbus0 not configured
>  "region157" at mainbus0 not configured
>  "region95" at mainbus0 not configured
>  "region94" at mainbus0 not configured
>  "region57" at mainbus0 not configured
>  "dcp_data" at mainbus0 not configured
>  "asc-firmware" at mainbus0 not configured
>  "uat-handoff" at mainbus0 not configured
>  "uat-pagetables" at mainbus0 not configured
>  "uat-ttbs" at mainbus0 not configured
>  "isp-heap" at mainbus0 not configured
>  apm0 at mainbus0
>  "opp-table-0" at mainbus0 not configured
>  "opp-table-1" at mainbus0 not configured
>  "opp-table-gpu" at mainbus0 not configured
>  "opp-table-gpu-cs" at mainbus0 not configured
>  "opp-table-gpu-afr" at mainbus0 not configured
>  "pmu-e" at mainbus0 no

Re: MBP M2 pro, !cold assert failed drm/include/linux/completion.h line 89 at shutdown

2024-08-28 Thread Stuart Henderson

I've not run into this again yet (with a few reboots).

--
 Sent from a phone, apologies for poor formatting.

On 27 August 2024 23:46:46 Stuart Henderson  wrote:


'Apple MacBook Pro (14-inch, M2 Pro, 2023)', running recent -current.
Not running X. I hit this after running halt -p:

panic: kernel diagnostic assertion "!cold" failed: file 
"/usr/src/sys/dev/pci/drm/include/linux/completion.h", line 89


Transcribed, maybe typos:

TID *328025, PID 16963, UID 0, PRFLAGS 0x3, PFLAGS 0, CPU 0K, COMMAND halt

db_enter at panic
panic at assert
panic at drm_atomic_helper_swap_state+0x57c
commit_tail at drm_atomic_helper_commit+0x1d4
drm_atomic_helper_commit at drm_atomic_commit+0xa4
drm_atomic_commit at drm_client_modeset_commit_atomic+0x158
drm_client_modeset_commit_atomic at drm_client_modeset_commit_locked+0x5c

After restart/fsck I tried halt -p again and it succeeded.


OpenBSD 7.6-beta (GENERIC.MP) #160: Mon Aug 26 05:36:05 MDT 2024
   dera...@arm64.openbsd.org:/usr/src/sys/arch/arm64/compile/GENERIC.MP
real mem  = 16312172544 (15556MB)
avail mem = 15672647680 (14946MB)
random: good seed from bootblocks
mainbus0 at root: Apple MacBook Pro (14-inch, M2 Pro, 2023)
efi0 at mainbus0: UEFI 2.10
efi0: Das U-Boot rev 0x20240100
cpu0 at mainbus0 mpidr 0: Apple Blizzard Pro r1p0
cpu0: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1 D-cache
cpu0: 4096KB 128b/line 16-way L2 cache
cpu0: 
TLBIOS+IRANGE,TS+AXFLAG,FHM,DP,SHA3,RDM,Atomic,CRC32,SHA2+SHA512,SHA1,AES+PMULL,I8MM,BF16,SPECRES,SB,FRINTTS,GPI,LRCPC+LDAPUR,FCMA,JSCVT,API+PAC,DPB+DCCVADP,ECV,SpecSEI,PAN+ATS1E1,LO,HPDS,VH,IDS,AT,CSV3,CSV2,DIT,AdvSIMD+HP,FP+HP,BT,SSBS+MSR

cpu1 at mainbus0 mpidr 1: Apple Blizzard Pro r1p0
cpu1: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1 D-cache
cpu1: 4096KB 128b/line 16-way L2 cache
cpu2 at mainbus0 mpidr 2: Apple Blizzard Pro r1p0
cpu2: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1 D-cache
cpu2: 4096KB 128b/line 16-way L2 cache
cpu3 at mainbus0 mpidr 3: Apple Blizzard Pro r1p0
cpu3: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1 D-cache
cpu3: 4096KB 128b/line 16-way L2 cache
cpu4 at mainbus0 mpidr 10100: Apple Avalanche Pro r1p0
cpu4: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu4: 16384KB 128b/line 16-way L2 cache
cpu5 at mainbus0 mpidr 10101: Apple Avalanche Pro r1p0
cpu5: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu5: 16384KB 128b/line 16-way L2 cache
cpu6 at mainbus0 mpidr 10102: Apple Avalanche Pro r1p0
cpu6: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu6: 16384KB 128b/line 16-way L2 cache
cpu7 at mainbus0 mpidr 10103: Apple Avalanche Pro r1p0
cpu7: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu7: 16384KB 128b/line 16-way L2 cache
cpu8 at mainbus0 mpidr 10200: Apple Avalanche Pro r1p0
cpu8: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu8: 16384KB 128b/line 16-way L2 cache
cpu9 at mainbus0 mpidr 10201: Apple Avalanche Pro r1p0
cpu9: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu9: 16384KB 128b/line 16-way L2 cache
cpu10 at mainbus0 mpidr 10202: Apple Avalanche Pro r1p0
cpu10: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu10: 16384KB 128b/line 16-way L2 cache
cpu11 at mainbus0 mpidr 10203: Apple Avalanche Pro r1p0
cpu11: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu11: 16384KB 128b/line 16-way L2 cache
"asc-firmware" at mainbus0 not configured
"asc-firmware" at mainbus0 not configured
"framebuffer" at mainbus0 not configured
"asc-firmware" at mainbus0 not configured
"asc-firmware" at mainbus0 not configured
"region157" at mainbus0 not configured
"region95" at mainbus0 not configured
"region94" at mainbus0 not configured
"region57" at mainbus0 not configured
"dcp_data" at mainbus0 not configured
"asc-firmware" at mainbus0 not configured
"uat-handoff" at mainbus0 not configured
"uat-pagetables" at mainbus0 not configured
"uat-ttbs" at mainbus0 not configured
"isp-heap" at mainbus0 not configured
apm0 at mainbus0
"opp-table-0" at mainbus0 not configured
"opp-table-1" at mainbus0 not configured
"opp-table-gpu" at mainbus0 not configured
"opp-table-gpu-cs" at mainbus0 not configured
"opp-table-gpu-afr" at mainbus0 not configured
"pmu-e" at mainbus0 not configured
"pmu-p" at mainbus0 not configured
agtimer0 at mainbus0: 24000 kHz
"clock-ref" at mainbus0 not configured
"clock-200m" at mainbus0 not configured
"clock-disp0" at mainbus0 not configured
"clock-dispext0" at mainbus0 not configured
"clock-dispext0_die1" at mainbus0 not configured
"clock-dispext1" at mainbus0 not configured
"clock-dispext1_die1" at mainbus0 not configured
"clock-ref-nco" at mainbus0 not configured
simplebus0 at mainbus0: "soc"
aplpmgr0 at simplebus0
aplpmgr1 at simplebus0
aplpmgr2 at simplebus0
aplpmgr3 at simplebus0
aplintc0 at simplebus0 nirq 1961 ndie 1
apldog0 at simplebus0
aplmbo

MBP M2 pro, !cold assert failed drm/include/linux/completion.h line 89 at shutdown

2024-08-27 Thread Stuart Henderson
'Apple MacBook Pro (14-inch, M2 Pro, 2023)', running recent -current.
Not running X. I hit this after running halt -p:

panic: kernel diagnostic assertion "!cold" failed: file 
"/usr/src/sys/dev/pci/drm/include/linux/completion.h", line 89

Transcribed, maybe typos:

TID *328025, PID 16963, UID 0, PRFLAGS 0x3, PFLAGS 0, CPU 0K, COMMAND halt

db_enter at panic
panic at assert
panic at drm_atomic_helper_swap_state+0x57c
commit_tail at drm_atomic_helper_commit+0x1d4
drm_atomic_helper_commit at drm_atomic_commit+0xa4
drm_atomic_commit at drm_client_modeset_commit_atomic+0x158
drm_client_modeset_commit_atomic at drm_client_modeset_commit_locked+0x5c

After restart/fsck I tried halt -p again and it succeeded.


OpenBSD 7.6-beta (GENERIC.MP) #160: Mon Aug 26 05:36:05 MDT 2024
dera...@arm64.openbsd.org:/usr/src/sys/arch/arm64/compile/GENERIC.MP
real mem  = 16312172544 (15556MB)
avail mem = 15672647680 (14946MB)
random: good seed from bootblocks
mainbus0 at root: Apple MacBook Pro (14-inch, M2 Pro, 2023)
efi0 at mainbus0: UEFI 2.10
efi0: Das U-Boot rev 0x20240100
cpu0 at mainbus0 mpidr 0: Apple Blizzard Pro r1p0
cpu0: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1 D-cache
cpu0: 4096KB 128b/line 16-way L2 cache
cpu0: 
TLBIOS+IRANGE,TS+AXFLAG,FHM,DP,SHA3,RDM,Atomic,CRC32,SHA2+SHA512,SHA1,AES+PMULL,I8MM,BF16,SPECRES,SB,FRINTTS,GPI,LRCPC+LDAPUR,FCMA,JSCVT,API+PAC,DPB+DCCVADP,ECV,SpecSEI,PAN+ATS1E1,LO,HPDS,VH,IDS,AT,CSV3,CSV2,DIT,AdvSIMD+HP,FP+HP,BT,SSBS+MSR
cpu1 at mainbus0 mpidr 1: Apple Blizzard Pro r1p0
cpu1: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1 D-cache
cpu1: 4096KB 128b/line 16-way L2 cache
cpu2 at mainbus0 mpidr 2: Apple Blizzard Pro r1p0
cpu2: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1 D-cache
cpu2: 4096KB 128b/line 16-way L2 cache
cpu3 at mainbus0 mpidr 3: Apple Blizzard Pro r1p0
cpu3: 128KB 64b/line 4-way L1 PIPT I-cache, 64KB 64b/line 8-way L1 D-cache
cpu3: 4096KB 128b/line 16-way L2 cache
cpu4 at mainbus0 mpidr 10100: Apple Avalanche Pro r1p0
cpu4: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu4: 16384KB 128b/line 16-way L2 cache
cpu5 at mainbus0 mpidr 10101: Apple Avalanche Pro r1p0
cpu5: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu5: 16384KB 128b/line 16-way L2 cache
cpu6 at mainbus0 mpidr 10102: Apple Avalanche Pro r1p0
cpu6: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu6: 16384KB 128b/line 16-way L2 cache
cpu7 at mainbus0 mpidr 10103: Apple Avalanche Pro r1p0
cpu7: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu7: 16384KB 128b/line 16-way L2 cache
cpu8 at mainbus0 mpidr 10200: Apple Avalanche Pro r1p0
cpu8: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu8: 16384KB 128b/line 16-way L2 cache
cpu9 at mainbus0 mpidr 10201: Apple Avalanche Pro r1p0
cpu9: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu9: 16384KB 128b/line 16-way L2 cache
cpu10 at mainbus0 mpidr 10202: Apple Avalanche Pro r1p0
cpu10: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu10: 16384KB 128b/line 16-way L2 cache
cpu11 at mainbus0 mpidr 10203: Apple Avalanche Pro r1p0
cpu11: 192KB 64b/line 6-way L1 PIPT I-cache, 128KB 64b/line 8-way L1 D-cache
cpu11: 16384KB 128b/line 16-way L2 cache
"asc-firmware" at mainbus0 not configured
"asc-firmware" at mainbus0 not configured
"framebuffer" at mainbus0 not configured
"asc-firmware" at mainbus0 not configured
"asc-firmware" at mainbus0 not configured
"region157" at mainbus0 not configured
"region95" at mainbus0 not configured
"region94" at mainbus0 not configured
"region57" at mainbus0 not configured
"dcp_data" at mainbus0 not configured
"asc-firmware" at mainbus0 not configured
"uat-handoff" at mainbus0 not configured
"uat-pagetables" at mainbus0 not configured
"uat-ttbs" at mainbus0 not configured
"isp-heap" at mainbus0 not configured
apm0 at mainbus0
"opp-table-0" at mainbus0 not configured
"opp-table-1" at mainbus0 not configured
"opp-table-gpu" at mainbus0 not configured
"opp-table-gpu-cs" at mainbus0 not configured
"opp-table-gpu-afr" at mainbus0 not configured
"pmu-e" at mainbus0 not configured
"pmu-p" at mainbus0 not configured
agtimer0 at mainbus0: 24000 kHz
"clock-ref" at mainbus0 not configured
"clock-200m" at mainbus0 not configured
"clock-disp0" at mainbus0 not configured
"clock-dispext0" at mainbus0 not configured
"clock-dispext0_die1" at mainbus0 not configured
"clock-dispext1" at mainbus0 not configured
"clock-dispext1_die1" at mainbus0 not configured
"clock-ref-nco" at mainbus0 not configured
simplebus0 at mainbus0: "soc"
aplpmgr0 at simplebus0
aplpmgr1 at simplebus0
aplpmgr2 at simplebus0
aplpmgr3 at simplebus0
aplintc0 at simplebus0 nirq 1961 ndie 1
apldog0 at simplebus0
aplmbox0 at simplebus0
aplpinctrl0 at simplebus0
aplmbox1 at simplebus0
apldart0 at simplebus0 rev 2.0: 42 bits, bypass
apldart1 at simplebus0 rev 2.0: 42 bits, bypass
aplda