Re: Vertical lines present on fonts (FreeType update related)

[Bryan Linton]

I finally had some time to bisect this diff and found that
reverting the following line of code to the one that was present
in FreeType 2.8.0 fixes the error for me.

Is there any way this can go in?  This bug significantly affects
the legibility of Asian fonts, and while the diff is a one-liner,
I won't claim to understand what exactly the new memory allocation
function is doing differently than the old one.

-- 
Bryan


Index: ftutil.c
===
RCS file: /cvs/xenocara/lib/freetype/src/base/ftutil.c,v
retrieving revision 1.9
diff -u -r1.9 ftutil.c
--- ftutil.c15 Dec 2017 19:29:12 -  1.9
+++ ftutil.c2 Mar 2018 12:27:45 -
@@ -143,7 +143,8 @@
 {
   FT_ASSERT( !block );
 
-  block = memory->alloc( memory, new_count * item_size );
+//  block = memory->alloc( memory, new_count * item_size );
+   block = ft_mem_alloc( memory, new_count * item_size, &error );
   if ( block == NULL )
 error = FT_THROW( Out_Of_Memory );
 }

Re: Vertical lines present on fonts (FreeType update related)

[Bryan Linton]

On 2018-02-17 08:29:15, Bryan Linton  wrote:
> CCing dcoppa@
> 
> Ping?
> 

FWIW, I'm still seeing this bug on the following snapshot:

OpenBSD 6.2-current (GENERIC.MP) #10: Wed Feb 21 21:26:27 MST 2018
dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP

-- 
Bryan

Re: Vertical lines present on fonts (FreeType update related)

[Bryan Linton]

CCing dcoppa@

Ping?

Can anyone else reproduce the vertical lines I'm seeing with the
new FreeType update, or can I assume that there's something weird
going on with just my machine that doesn't affect others?

-- 
Bryan

On 2018-02-11 22:05:54, Bryan Linton  wrote:
> >Synopsis:Asian fonts are rendering with vertical bars after recent 
> >FreeType update
> >Category:system
> >Environment:
>   System  : OpenBSD 6.2
>   Details : OpenBSD 6.2-current (GENERIC.MP) #408: Thu Feb  8 
> 04:09:33 MST 2018
>
> dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> 
>   Architecture: OpenBSD.amd64
>   Machine : amd64
> >Description:
>   I noticed after upgrading to a newer snapshot that
>   vertical lines are now displayed when Asian fonts are
>   rendered.  The example (and screenshot) is from mutt in an
>   xterm, but I see the same thing in Firefox.
> 
>   I've attached a screenshot of mutt (please ignore the date
>   in the email itself, I've had OpenBSD installed for a long
>   time).  Notice how "Theo de Raadt" renders more like "Thθa
>   dθ Raadt", the following left angle bracket looks more
>   like a triangle, and the date in the line above looks like
>   it says "2101017" instead of "2007".
> 
>   While this is only mildly annoying when reading the Latin
>   alphabet, it causes considerably more confusion when
>   reading Asian (specifically Japanese) scripts.  For
>   example, the difference between リ and 川
>   is quite significant.  (One is simply a phonetic character
>   with the reading of "ri", the other is a kanji meaning
>   "river" with the reading of "kawa").
> 
>   It also appears to be specifically limited to embolded
>   fonts.  I do not see it occur on regular (non-italic,
>   non-embolded) fonts.
> 
> >How-To-Repeat:
>   pkg_add mutt ja-sazanami-ttf-20040629p3
>   env LC_ALL=ja_JP.UTF-8 xterm -fa "Sazanami Gothic" -fs 16 mutt
>   
> 
>   --- or ---
> 
>   pkg_add firefox-esr ja-sazanami-ttf-20040629p3
>   
>   
> 
> >Fix:
>   Reverting FreeType 2.8.1 back to FreeType 2.8.0 resolves
>   all issues for me.
> 
> 
> dmesg:
> OpenBSD 6.2-current (GENERIC.MP) #408: Thu Feb  8 04:09:33 MST 2018
> dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> real mem = 12539572224 (11958MB)
> avail mem = 12152545280 (11589MB)
> enter_shared_special_pages: entered idt page va 0x8001 pa 
> 0x1d5a000
> enter_shared_special_pages: entered kutext page va 0x8183 pa 
> 0x183
> enter_shared_special_pages: entered kutext page va 0x81831000 pa 
> 0x1831000
> enter_shared_special_pages: entered kutext page va 0x81832000 pa 
> 0x1832000
> enter_shared_special_pages: entered kudata page va 0x81ac6000 pa 
> 0x1ac6000
> cpu_enter_pages: entered tss+gdt page at va 0x81a93000 pa 0x1a93000
> cpu_enter_pages: entered t.stack page at va 0x81a94000 pa 0x1a94000
> cpu_enter_pages: cif_tss.tss_rsp0 = 0x81a943e0
> mpath0 at root
> scsibus0 at mpath0: 256 targets
> mainbus0 at root
> bios0 at mainbus0: SMBIOS rev. 2.7 @ 0xbcc0d000 (67 entries)
> bios0: vendor LENOVO version "GLET92WW (2.46 )" date 12/11/2017
> bios0: LENOVO 20AWS27D00
> acpi0 at bios0: rev 2
> acpi0: sleep states S0 S3 S4 S5
> acpi0: tables DSDT FACP SLIC DBGP ECDT HPET APIC MCFG SSDT SSDT SSDT SSDT 
> SSDT SSDT SSDT PCCT SSDT TCPA UEFI MSDM ASF! BATB FPDT UEFI DMAR
> acpi0: wakeup devices LID_(S4) SLPB(S3) IGBE(S4) EXP2(S4) EXP3(S4) XHCI(S3) 
> EHC1(S3) EHC2(S3)
> acpitimer0 at acpi0: 3579545 Hz, 24 bits
> acpiec0 at acpi0
> acpihpet0 at acpi0: 14318179 Hz
> acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
> lapic_map: entered lapic page va 0x81ac4000 pa 0xfee0
> cpu0 at mainbus0: apid 0 (boot processor)
> cpu0: Intel(R) Core(TM) i7-4800MQ CPU @ 2.70GHz, 2694.09 MHz
> cpu0: 
> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,SDBG,FMA3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,PAGE1GB,RDTSCP,LONG,LAHF,ABM,PERF,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,IBRS,IBPB,STIBP,SENSOR,ARAT,INSECURE
> cpu0: 256KB 64b/line 8-way L2 cache
> acpihpet0: recalibrated TSC frequency 2693764628 Hz
> cpu0: smt 0, core 0, package 0
> mtrr: Pentium Pro MTRR support, 10 var ranges, 88 fixed ranges
> cpu0: apic clock running at 99MHz
> cpu0: mwait min=64, max=64, C-substates=0.2.1.2.4, IBE
> cpu1 at mainbus0cpu_enter_pages: entered tss+gdt page at va 
> 0x80002200 pa 0x116a8c000
> cpu_enter_pages: entered t.stack page at va 0x800022001000 pa 0x116a8d000
> cpu_enter_pages: cif_tss.tss_rsp0 = 0x8000220013e0
> : apid 1 (application processor)
> cpu1: Intel(R) Core(TM) i7-4800MQ CPU @ 2.70GHz, 2693.77 MHz