Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+
 Reporter:  Chris Johns  |   Owner:  Joel Sherrill
 Type:  defect   |  Status:  closed
 Priority:  normal   |   Milestone:  5.1
Component:  score| Version:  5
 Severity:  normal   |  Resolution:  fixed
 Keywords:   |  Blocked By:
 Blocking:   |
-+

Comment (by Sebastian Huber ):

 In [changeset:"38cb59ee0b8f3b55ad3277bbf24b5fd1caa88603/rtems"
 38cb59e/rtems]:
 {{{
 #!CommitTicketReference repository="rtems"
 revision="38cb59ee0b8f3b55ad3277bbf24b5fd1caa88603"
 Separate task mode checks

 Update #3000.
 }}}

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+
 Reporter:  Chris Johns  |   Owner:  Joel Sherrill
 Type:  defect   |  Status:  closed
 Priority:  normal   |   Milestone:  5.1
Component:  score| Version:  5
 Severity:  normal   |  Resolution:  fixed
 Keywords:   |  Blocked By:
 Blocking:   |
-+

Comment (by Sebastian Huber ):

 In [changeset:"3bd336cfa8a77a545e513669e61877f9ccb6/rtems"
 3bd3/rtems]:
 {{{
 #!CommitTicketReference repository="rtems"
 revision="3bd336cfa8a77a545e513669e61877f9ccb6"
 Adjust interrupt mode tests for some CPU ports

 In case the robust thread dispatch is enabled by the CPU port, then the
 interrupt level must not be changed through the task mode.

 Update #3000.
 }}}

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+
 Reporter:  Chris Johns  |   Owner:  Joel Sherrill
 Type:  defect   |  Status:  closed
 Priority:  normal   |   Milestone:  5.1
Component:  score| Version:  5
 Severity:  normal   |  Resolution:  fixed
 Keywords:   |  Blocked By:
 Blocking:   |
-+

Comment (by Sebastian Huber ):

 In [changeset:"1f2851867535aa24edfd8574b520f1b3ec22efc0/rtems"
 1f285186/rtems]:
 {{{
 #!CommitTicketReference repository="rtems"
 revision="1f2851867535aa24edfd8574b520f1b3ec22efc0"
 rtems: Allow to set ISR level 0 in SMP config

 Update #3000.
 }}}

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+
 Reporter:  Chris Johns  |   Owner:  Joel Sherrill
 Type:  defect   |  Status:  closed
 Priority:  normal   |   Milestone:  5.1
Component:  score| Version:  5
 Severity:  normal   |  Resolution:  fixed
 Keywords:   |  Blocked By:
 Blocking:   |
-+
Changes (by Joel Sherrill):

 * status:  reopened => closed
 * resolution:   => fixed


--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+
 Reporter:  Chris Johns  |   Owner:  Joel Sherrill
 Type:  defect   |  Status:  reopened
 Priority:  normal   |   Milestone:  5.1
Component:  score| Version:  5
 Severity:  normal   |  Resolution:
 Keywords:   |  Blocked By:
 Blocking:   |
-+

Comment (by Chris Johns):

 Can this ticket be closed? If it cannot be closed what is outstanding to
 be done?

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+
 Reporter:  Chris Johns  |   Owner:  Joel Sherrill
 Type:  defect   |  Status:  reopened
 Priority:  normal   |   Milestone:  5.1
Component:  score| Version:  5
 Severity:  normal   |  Resolution:
 Keywords:   |
-+

Comment (by Sebastian Huber ):

 In [changeset:"a5b4db4bc250a1beb06da16b3003ae1608c611d4/rtems"
 a5b4db4b/rtems]:
 {{{
 #!CommitTicketReference repository="rtems"
 revision="a5b4db4bc250a1beb06da16b3003ae1608c611d4"
 rtems: Fix rtems_task_mode()

 A rtems_configuration_is_smp_enabled() inside a !defined( RTEMS_SMP)
 block makes no sense.

 Remove !defined( RTEMS_SMP ) conditions.

 Test tm04 works now again.

 Update #3000.
 }}}

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+
 Reporter:  Chris Johns  |   Owner:  Joel Sherrill
 Type:  defect   |  Status:  reopened
 Priority:  normal   |   Milestone:  5.1
Component:  score| Version:  5
 Severity:  normal   |  Resolution:
 Keywords:   |
-+

Comment (by Joel Sherrill ):

 In [changeset:"1307e759e31af452b614ea341759f638dc81423f/rtems"
 1307e75/rtems]:
 {{{
 #!CommitTicketReference repository="rtems"
 revision="1307e759e31af452b614ea341759f638dc81423f"
 tm08: Do not use RTEMS_INTERRUPT_MASK for no reschedule case

 Updates #3000.
 }}}

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+
 Reporter:  Chris Johns  |   Owner:  Joel Sherrill
 Type:  defect   |  Status:  reopened
 Priority:  normal   |   Milestone:  5.1
Component:  score| Version:  5
 Severity:  normal   |  Resolution:
 Keywords:   |
-+
Changes (by Sebastian Huber):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Tests tm04 and tm20 fail now with --enable-smp.

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+
 Reporter:  Chris Johns  |   Owner:  Joel Sherrill
 Type:  defect   |  Status:  closed
 Priority:  normal   |   Milestone:  5.1
Component:  score| Version:  5
 Severity:  normal   |  Resolution:  fixed
 Keywords:   |
-+
Changes (by Joel Sherrill ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"307945504afcaab3b7bb9a29864666e892a707b0/rtems-docs"
 3079455/rtems-docs]:
 {{{
 #!CommitTicketReference repository="rtems-docs"
 revision="307945504afcaab3b7bb9a29864666e892a707b0"
 Account for non-preemption and interrupt level not supported on SMP

 Closes #3000.
 }}}

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+
 Reporter:  Chris Johns  |   Owner:  Joel Sherrill
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  5.1
Component:  score| Version:  5
 Severity:  normal   |  Resolution:
 Keywords:   |
-+

Comment (by Joel Sherrill ):

 In [changeset:"e9e0f1d4649191a419274b76cacad354f2a45798/rtems"
 e9e0f1d4/rtems]:
 {{{
 #!CommitTicketReference repository="rtems"
 revision="e9e0f1d4649191a419274b76cacad354f2a45798"
 smpunsupported01: Add missing error check for rtems_task_mode

 Update test documentation to include more cases.

 Updates #3000.
 }}}

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+
 Reporter:  Chris Johns  |   Owner:  Joel Sherrill
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.12.0
Component:  score| Version:  4.12
 Severity:  normal   |  Resolution:
 Keywords:   |
-+
Changes (by Joel Sherrill):

 * owner:  Chris Johns => Joel Sherrill


--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+--
 Reporter:  Chris Johns  |   Owner:  Chris Johns
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.12.0
Component:  score| Version:  4.12
 Severity:  normal   |  Resolution:
 Keywords:   |
-+--

Comment (by Joel Sherrill):

 Updated work list:

 * Whine that this was easier to report than to fix.
 * CPUKit Changes
   * Add status to enumeration
   * Add status to list in rtems status to string
   * Add status to list in Ada binding. Should be mechanical.
   * Add both error checks to rtems_task_create()
   * Add both error checks to rtems_task_mode()
 * Documentation
   * Add status to status table in Classic API manual
   * Add new status to rtems_task_create() documentation
   * Add new status to rtems_task_mode() documentation
 * Testing
   * Add rtems_task_create() test case(s) to smpunsupported01
   * Add rtems_task_mode() test case(s) to smpunsupported01

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+--
 Reporter:  Chris Johns  |   Owner:  Chris Johns
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.12.0
Component:  score| Version:  4.12
 Severity:  normal   |  Resolution:
 Keywords:   |
-+--
Description changed by Chris Johns:

Old description:

> If for any reason a user sets the interrupt level in the mode on an SMP
> build the error {{{RTEMS_UNSATISFIED}}} is returned. The documentation
> indicates this is a lack of stack and this confusing.
>
> The reason this happens is the SMP check for an interrupt level being set
> is in the score's {{{_Thread_Initialize}}}. I propose that and
> {{{is_preemptible}} check be converted to an {{assert}} and checks be
> added to the Classic API to catch these errors and report suitable error
> codes.
>
> There is no meaningful error code available without abusing an existing
> one so I propose adding {{{RTEMS_INVALID_MODE}}}.

New description:

 If for any reason a user sets the interrupt level in the mode on an SMP
 build the error {{{RTEMS_UNSATISFIED}}} is returned. The documentation
 indicates this is a lack of stack and this confusing.

 The reason this happens is the SMP check for an interrupt level being set
 is in the score's {{{_Thread_Initialize}}}. I propose that and
 {{{is_preemptible}}} check be converted to an {{{assert}}} and checks be
 added to the Classic API to catch these errors and report suitable error
 codes.

 There is no meaningful error code available without abusing an existing
 one so I propose adding {{{RTEMS_INVALID_MODE}}}.

--

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+--
 Reporter:  Chris Johns  |   Owner:  Chris Johns
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.12.0
Component:  cpukit   | Version:  4.12
 Severity:  normal   |  Resolution:
 Keywords:   |
-+--

Comment (by Sebastian Huber):

 Replying to [comment:4 Chris Johns]:
 > Replying to [comment:3 Sebastian Huber]:
 > > See smpunsupported01 test.
 >
 > What what? Could you please elaborate a little more?

 This is the test program the new error cases should be added.

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+--
 Reporter:  Chris Johns  |   Owner:  Chris Johns
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.12.0
Component:  cpukit   | Version:  4.12
 Severity:  normal   |  Resolution:
 Keywords:   |
-+--

Comment (by Chris Johns):

 Replying to [comment:3 Sebastian Huber]:
 > See smpunsupported01 test.

 What what? Could you please elaborate a little more?

 Thanks

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+--
 Reporter:  Chris Johns  |   Owner:  Chris Johns
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.12.0
Component:  cpukit   | Version:  4.12
 Severity:  normal   |  Resolution:
 Keywords:   |
-+--

Comment (by Sebastian Huber):

 See smpunsupported01 test.

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+--
 Reporter:  Chris Johns  |   Owner:  Chris Johns
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.12.0
Component:  cpukit   | Version:  4.12
 Severity:  normal   |  Resolution:
 Keywords:   |
-+--

Comment (by Chris Johns):

 Replying to [comment:1 Joel Sherrill]:
 > I think this is a generally a good idea but there are a number of pieces
 to do this completely:

 Great and yes.

 > * the status has to also be returned by rtems_task_mode()

 OK.

 > * add status to list in rtems status to string

 Done in the posted patch.

 > * add status to list in Ada binding. Should be mechanical.

 Is there any documentation on how to do this?

 > * add status to status table in Classic API manual
 > * add new status to rtems_task_create() documentation
 > * add new status to rtems_task_mode() documentation

 I will create a docs patch once I have a suitable patch for {{{master}}}.

 > * add test for rtems_task_create() new error
 > * add test for rtems_task_mode() new error

 Yes however the tests are only running in the single core mode even when
 built with SMP so the error is not able to be tripped.

 > I am unsure if the assert() is debug mode only. That needs to be
 clarified.

 That is correct. The assert's catch a bug in a user of the score API when
 built with {{{RTEMS_DEBUG}}}. The users of the call need to protect the
 score thread initialise call.

 > Sorry to be pedantic with the list but this looks like the type of
 change that is small but has tentacles that would be easy to miss pieces.
 I suspect my list isn't complete yet.

 This looks the list to me.

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED

[RTEMS trac]

#3000: Setting interrupt level in the mode arg on SMP returns RTEMS_UNSATISFIED
-+--
 Reporter:  Chris Johns  |   Owner:  Chris Johns
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.12.0
Component:  cpukit   | Version:  4.12
 Severity:  normal   |  Resolution:
 Keywords:   |
-+--

Comment (by Joel Sherrill):

 I think this is a generally a good idea but there are a number of pieces
 to do this completely:

 * the status has to also be returned by rtems_task_mode()
 * add status to list in rtems status to string
 * add status to list in Ada binding. Should be mechanical.
 * add status to status table in Classic API manual
 * add new status to rtems_task_create() documentation
 * add new status to rtems_task_mode() documentation
 * add test for rtems_task_create() new error
 * add test for rtems_task_mode() new error

 I am unsure if the assert() is debug mode only. That needs to be
 clarified.

 Sorry to be pedantic with the list but this looks like the type of change
 that is small but has tentacles that would be easy to miss pieces. I
 suspect my list isn't complete yet.

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs