Re: RTEMS | tc-cpuuse.c: magic number cleanup (!1049)
Merge request !1049 was merged Merge request URL: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049 Project:Branches: TheSamPrice/rtems:tic-cleanup to rtems/rtos/rtems:main Author: Sam Price -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049 You're receiving this email because of your account on gitlab.rtems.org. ___ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
Re: RTEMS | tc-cpuuse.c: magic number cleanup (!1049)
Joel Sherrill pushed new commits to merge request !1049 Merge request URL: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049 * 97e4174c...9ff62c34 - 2 commits from branch `main` * 03a2e44c - tc-cpuuse.c: magic number cleanup -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049 You're receiving this email because of your account on gitlab.rtems.org. ___ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
Re: RTEMS | tc-cpuuse.c: magic number cleanup (!1049)
Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049 was reviewed by Joel Sherrill -- Joel Sherrill commented on a discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049#note_142674 Unless someone is reformatting code embedded in central, this testsuite is off limits to formatting. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049 You're receiving this email because of your account on gitlab.rtems.org. ___ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
Re: RTEMS | tc-cpuuse.c: magic number cleanup (!1049)
Gedare Bloom started a new discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049#note_142094 This file is generated from `rtems-central.git`, we need a corresponding fix in `spec/rtems/cpuuse/val/cpuuse.yml` -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049#note_142094 You're receiving this email because of your account on gitlab.rtems.org. ___ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
Re: RTEMS | tc-cpuuse.c: magic number cleanup (!1049)
Gedare Bloom started a new discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049#note_142092 Fix formatting errors: ``` gedare@localhost:~/rtems/rtems$ git clang-format HEAD^ changed files: testsuites/validation/tc-cpuuse.c gedare@localhost:~/rtems/rtems$ git diff diff --git a/testsuites/validation/tc-cpuuse.c b/testsuites/validation/tc-cpuuse.c index bc22262442..4733eda998 100644 --- a/testsuites/validation/tc-cpuuse.c +++ b/testsuites/validation/tc-cpuuse.c @@ -142,10 +142,14 @@ static void RtemsCpuuseValCpuuse_Action_0( void ) * Our CPU usage after the last reset is now exactly one tick of the * software timecounter. */ - T_eq_i64( _Thread_Get_CPU_time_used_after_last_reset( self ), CPUUSE_SOFT_TICKS ); + T_eq_i64( +_Thread_Get_CPU_time_used_after_last_reset( self ), +CPUUSE_SOFT_TICKS + ); T_eq_i64( _Thread_Get_CPU_time_used( self ), -cpu_usage_self + (3*CPUUSE_SOFT_TICKS) + (CPUUSE_SOFT_TICKS * idle_tasks) +cpu_usage_self + ( 3 * CPUUSE_SOFT_TICKS ) + + ( CPUUSE_SOFT_TICKS * idle_tasks ) ); T_eq_i64( _Thread_Get_CPU_time_used_after_last_reset( other ), 0 ); ``` -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049#note_142092 You're receiving this email because of your account on gitlab.rtems.org. ___ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
Re: RTEMS | tc-cpuuse.c: magic number cleanup (!1049)
Kinsey Moore pushed new commits to merge request !1049 Merge request URL: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049 * f7737a09...9c7666ba - 2 commits from branch `main` * 4c813f5e - tc-cpuuse.c: magic number cleanup -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049 You're receiving this email because of your account on gitlab.rtems.org. ___ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
Re: RTEMS | tc-cpuuse.c: magic number cleanup (!1049)
Sam Price commented: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049#note_141974 @opticron Pulled cleanup into pr. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1049#note_141974 You're receiving this email because of your account on gitlab.rtems.org. ___ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
