Re: Request for approval: file fallout from 100028 patch

2009-04-20 Thread Xiomara . Jayasena
On 04/20/09 11:10, Andrew Haley wrote: Andrew Haley wrote: Kelly O'Hair wrote: I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Looks ok to me. Xiomara would like to integrate the build

hg: jdk7/build/langtools: 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files

2009-04-20 Thread aph
Changeset: 321854d9ab19 Author:aph Date: 2009-04-20 19:01 +0100 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/321854d9ab19 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Summary: Correct fallout from 100028 patch Reviewed-by: ohair Contributed-by:

hg: jdk7/build/jaxws: 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files

2009-04-20 Thread aph
Changeset: ab30d5761947 Author:aph Date: 2009-04-20 19:01 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/ab30d5761947 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Summary: Correct fallout from 100028 patch Reviewed-by: ohair Contributed-by: And

Re: Request for approval: file fallout from 100028 patch

2009-04-20 Thread Andrew Haley
Andrew Haley wrote: > Andrew Haley wrote: >> Kelly O'Hair wrote: >>> I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) >>> >>> 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files >>> >>> Looks ok to me. >>> >>> Xiomara would like to integrate the build

hg: jdk7/build/jaxp: 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files

2009-04-20 Thread aph
Changeset: 7967d26b229c Author:aph Date: 2009-04-20 19:00 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/7967d26b229c 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Summary: Correct fallout from 100028 patch Reviewed-by: ohair Contributed-by: Andr

Re: Request for approval: file fallout from 100028 patch

2009-04-20 Thread Andrew Haley
Andrew Haley wrote: > Kelly O'Hair wrote: >> I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) >> >> 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files >> >> Looks ok to me. >> >> Xiomara would like to integrate the build forest to jdk7/jdk7 (master >>

Re: Request for approval: file fallout from 100028 patch

2009-04-20 Thread Kelly O'Hair
Andrew Haley wrote: Kelly O'Hair wrote: I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Looks ok to me. Xiomara would like to integrate the build forest to jdk7/jdk7 (master forest) today or

Re: Request for approval: file fallout from 100028 patch

2009-04-20 Thread Andrew Haley
Kelly O'Hair wrote: > > I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) > > 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files > > Looks ok to me. > > Xiomara would like to integrate the build forest to jdk7/jdk7 (master > forest) > today or tomo

Re: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing

2009-04-20 Thread Kelly O'Hair
I created 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files -kto Andrew Haley wrote: Jonathan Gibbons wrote: Andrew. Earlier this week, Mark announced that Release Team approval was required for the final M3 builds for JDK7. [1] Glad I asked. Even without that, jch

Re: Request for approval: file fallout from 100028 patch

2009-04-20 Thread Kelly O'Hair
I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Looks ok to me. Xiomara would like to integrate the build forest to jdk7/jdk7 (master forest) today or tomorrow, so we'll need this fix in for tha

Re: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing

2009-04-20 Thread Jonathan Gibbons
Dalibor, I'd suggest raising this to P2, since I think it's a serious regression. -- Jon Dalibor Topic wrote: Jonathan Gibbons wrote: Andrew. Earlier this week, Mark announced that Release Team approval was required for the final M3 builds for JDK7. [1] Even without that, jcheck would r

Re: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing

2009-04-20 Thread Dalibor Topic
Jonathan Gibbons wrote: > Andrew. > > Earlier this week, Mark announced that Release Team approval was required > for the final M3 builds for JDK7. [1] > > Even without that, jcheck would require that you have another BugTraq CR > for this issue, even though it is just a modification of a recent

Re: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing

2009-04-20 Thread Dalibor Topic
Jonathan Gibbons wrote: > Andrew. > > Earlier this week, Mark announced that Release Team approval was required > for the final M3 builds for JDK7. [1] > > Even without that, jcheck would require that you have another BugTraq CR > for this issue, even though it is just a modification of a recent

Re: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing

2009-04-20 Thread Andrew Haley
Xiomara Jayasena wrote: > End of today is the code freeze for the build integration area. The > last putback (Bug ID: 6829575) broke the windows builds. Kelly, please help me out here, my understanding is that my patch was tested on all the platforms before I pushed it. If my patch really broke

Re: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing

2009-04-20 Thread Xiomara Jayasena
End of today is the code freeze for the build integration area. The last putback (Bug ID: 6829575) broke the windows builds. Chris Hegarty's (SCTP feature) is in the build integration area so the changes from there need to be pushed to the master prior to build 56. Please address the above

Re: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing

2009-04-20 Thread Martin Buchholz
On Mon, Apr 20, 2009 at 02:06, Andrew Haley wrote: > Jonathan Gibbons wrote: >> Andrew. >> >> Earlier this week, Mark announced that Release Team approval was required >> for the final M3 builds for JDK7. [1] > > Glad I asked. > >> Even without that, jcheck would require that you have another BugT

Request for approval: file fallout from 100028 patch

2009-04-20 Thread Andrew Haley
https://bugs.openjdk.java.net/show_bug.cgi?id=100045 Andrew.

Re: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing

2009-04-20 Thread Andrew Haley
Jonathan Gibbons wrote: > Andrew. > > Earlier this week, Mark announced that Release Team approval was required > for the final M3 builds for JDK7. [1] Glad I asked. > Even without that, jcheck would require that you have another BugTraq CR > for this issue, even though it is just a modification