Re: 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Andrew John Hughes
2009/6/17 Anthony Petrov : > On 6/17/2009 10:13 PM Andrew John Hughes wrote: >>> >>> Please update the README-builds.html file also as Kelly suggests. Thanks! >> >> Ok here's an updated version with Xrender mentioned in README-builds: >> >> http://fuseyism.com/6851515/webrev.03/ >> >> Ok? > > Perfe

Re: 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Anthony Petrov
On 6/17/2009 10:13 PM Andrew John Hughes wrote: Please update the README-builds.html file also as Kelly suggests. Thanks! Ok here's an updated version with Xrender mentioned in README-builds: http://fuseyism.com/6851515/webrev.03/ Ok? Perfect! Approved. Feel free to push to the AWT gate. --

Re: 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Kelly O'Hair
Excellent README change, thank you. -kto Andrew John Hughes wrote: 2009/6/17 Anthony Petrov : Andrew, Please update the README-builds.html file also as Kelly suggests. Thanks! Ok here's an updated version with Xrender mentioned in README-builds: http://fuseyism.com/6851515/webrev.03/ Ok

Re: 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Andrew John Hughes
2009/6/17 Anthony Petrov : > Andrew, > > Please update the README-builds.html file also as Kelly suggests. Thanks! > Ok here's an updated version with Xrender mentioned in README-builds: http://fuseyism.com/6851515/webrev.03/ Ok? > -- > best regards, > Anthony > > On 6/17/2009 9:00 PM Anthony P

Re: 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Kelly O'Hair
Well, I'm not a member of the awt team, so I suspect you should check with them. It does seem to be a pretty specific awt change. -kto Andrew John Hughes wrote: 2009/6/17 Kelly O'Hair : Anthony Petrov wrote: So, build-dev, Any opinions? Can we make sure the header is always present on Sol1

Re: 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Anthony Petrov
Andrew, Please update the README-builds.html file also as Kelly suggests. Thanks! -- best regards, Anthony On 6/17/2009 9:00 PM Anthony Petrov wrote: On 6/17/2009 8:44 PM Andrew John Hughes wrote: So should I push the original webrev http://fuseyism.com/xrender/webrev.01/ (which uses the stan

Re: 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Anthony Petrov
On 6/17/2009 8:44 PM Andrew John Hughes wrote: So should I push the original webrev http://fuseyism.com/xrender/webrev.01/ (which uses the standard header instead) to the awt gate? Given Kelly's point, I'm approving the fix. Please use the CR number 6851515 for your commit message. Thanks for th

Re: 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Andrew John Hughes
2009/6/17 Kelly O'Hair : > > > Anthony Petrov wrote: >> >> So, build-dev, >> >> Any opinions? Can we make sure the header is always present on Sol10u2? > > I'm very much ok with this change. I hate copying system include stuff. > > We could add a specific sanity check, but my preference would to no

Re: 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Kelly O'Hair
Anthony Petrov wrote: So, build-dev, Any opinions? Can we make sure the header is always present on Sol10u2? I'm very much ok with this change. I hate copying system include stuff. We could add a specific sanity check, but my preference would to not, Too many sanity checks as it is... :^(

Re: 6839999: Cumulative fix for 6762511 and 6838003

2009-06-17 Thread Anthony Petrov
So, build-dev, Any opinions? Can we make sure the header is always present on Sol10u2? Perhaps we could add it to the requirements list for building OpenJDK? -- best regards, Anthony On 06/16/2009 07:25 PM, Anthony Petrov wrote: On 06/16/2009 07:21 PM, Andrew John Hughes wrote: Is it reall