Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Jonathan Gibbons
Kelly O'Hair wrote: I also like the approach I advocated some years ago: - run tests under JDK 1 - run tests under JDK 2 - diff the results (JTreport directories) See my diff-javatest script. jtreg now has support for this (I haven't tried it lately). In an ideal world, one set of results w

Re: 6856630: Restructure jaxp/jaxws repository

2009-11-04 Thread Kelly O'Hair
Andrew John Hughes wrote: 2009/11/4 Kelly O'Hair : Andrew John Hughes wrote: 2009/11/4 Kelly O'Hair : Andrew John Hughes wrote: 2009/11/4 Kelly O'Hair : I'm basically ok with this, but have one concern. There is no longer a default ant value for drops.dir, it is only set via the Makefile

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Kelly O'Hair
Martin Buchholz wrote: On Wed, Nov 4, 2009 at 09:19, Kelly O'Hair wrote: Managing the ProblemList (as Jon noted) will be a pain at times. It's even more of a problem as development becomes more distributed, as failures become platform-dependent, etc... I would prefer to see per-file annota

Re: 6856630: Restructure jaxp/jaxws repository

2009-11-04 Thread Andrew John Hughes
2009/11/4 Kelly O'Hair : > > > Andrew John Hughes wrote: >> >> 2009/11/4 Kelly O'Hair : >>> >>> Andrew John Hughes wrote: 2009/11/4 Kelly O'Hair : > > I'm basically ok with this, but have one concern. > > There is no longer a default ant value for drops.dir, it is only >>>

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Martin Buchholz
On Wed, Nov 4, 2009 at 09:19, Kelly O'Hair wrote: > Managing the ProblemList (as Jon noted) will be a pain at times. It's even more of a problem as development becomes more distributed, as failures become platform-dependent, etc... I would prefer to see per-file annotations that jtreg can under

Re: 6856630: Restructure jaxp/jaxws repository

2009-11-04 Thread Kelly O'Hair
Andrew John Hughes wrote: 2009/11/4 Kelly O'Hair : Andrew John Hughes wrote: 2009/11/4 Kelly O'Hair : I'm basically ok with this, but have one concern. There is no longer a default ant value for drops.dir, it is only set via the Makefile. Maybe that's ok, just not sure. I think it means th

building OpenJDK on Mac OS X 1.5.8?

2009-11-04 Thread Ray Kiddy
Hey - A bit new to this project. Not sure what the procedure is here. I found this doc to work from and it got me pretty far: http://confluence.concord.org/display/CCTR/Build+OpenJDK+Java+1.7.0+on+Mac+OS+X+10.5 But then after quite a while building, I get the following. Yet, as y

hg: jdk7/build/langtools: Added tag jdk7-b75 for changeset 2485f5641ed0

2009-11-04 Thread kelly . ohair
Changeset: c8083dc525b6 Author:mikejwre Date: 2009-10-30 10:55 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/c8083dc525b6 Added tag jdk7-b75 for changeset 2485f5641ed0 ! .hgtags

hg: jdk7/build/jdk: 3 new changesets

2009-11-04 Thread kelly . ohair
Changeset: 8885b2256507 Author:ohair Date: 2009-10-29 11:17 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/8885b2256507 6896472: Missing libjsig.so causes jdk build failure Reviewed-by: tbell, kvn, phh ! make/java/redist/Makefile Changeset: 185f51018a36 Author:mikejw

hg: jdk7/build/jaxws: Added tag jdk7-b75 for changeset fcf2b8b5d606

2009-11-04 Thread kelly . ohair
Changeset: 27c05c2ad35f Author:mikejwre Date: 2009-10-30 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/27c05c2ad35f Added tag jdk7-b75 for changeset fcf2b8b5d606 ! .hgtags

hg: jdk7/build/jaxp: Added tag jdk7-b75 for changeset 555fb78ee4ce

2009-11-04 Thread kelly . ohair
Changeset: cb7bd40f5031 Author:mikejwre Date: 2009-10-30 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/cb7bd40f5031 Added tag jdk7-b75 for changeset 555fb78ee4ce ! .hgtags

hg: jdk7/build/hotspot: 31 new changesets

2009-11-04 Thread kelly . ohair
Changeset: 528d98fe1037 Author:xlu Date: 2009-09-24 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/528d98fe1037 6880029: JDK 1.6.0_u14p Application crashed very early Reviewed-by: never, ysr, acorn ! src/share/vm/runtime/safepoint.cpp Changeset: 054afbef9081 Au

Re: Building OpenJDK Java 1.7.0 on Mac OS X 10.6

2009-11-04 Thread Maxim Porges
I've diff'd a few of the files from that patch, and it looks like the code I have included the patch from jdk7-b47. I exported my local copy on September 23, 2009 from http://hg.openjdk.java.net/bsd-port/bsd- port, so my guess would be that it was around jdk7-b73 based on the tag dates. S

hg: jdk7/build/corba: 2 new changesets

2009-11-04 Thread kelly . ohair
Changeset: c8a56aff861b Author:mikejwre Date: 2009-10-30 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/c8a56aff861b Added tag jdk7-b75 for changeset 0fb137085952 ! .hgtags Changeset: 6995f81e3b53 Author:ohair Date: 2009-11-04 11:19 -0800 URL: http

hg: jdk7/build: 2 new changesets

2009-11-04 Thread kelly . ohair
Changeset: 2bad7eac71b3 Author:mikejwre Date: 2009-10-30 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/2bad7eac71b3 Added tag jdk7-b75 for changeset d1516b9f2395 ! .hgtags Changeset: 0619361ff7c5 Author:ohair Date: 2009-11-04 11:19 -0800 URL: http://hg.

Re: 6856630: Restructure jaxp/jaxws repository

2009-11-04 Thread Andrew John Hughes
2009/11/4 Kelly O'Hair : > > > Andrew John Hughes wrote: >> >> 2009/11/4 Kelly O'Hair : >>> >>> I'm basically ok with this, but have one concern. >>> >>> There is no longer a default ant value for drops.dir, it is only >>> set via the Makefile. Maybe that's ok, just not sure. >>> I think it means t

Re: 6856630: Restructure jaxp/jaxws repository

2009-11-04 Thread Kelly O'Hair
Andrew John Hughes wrote: 2009/11/4 Kelly O'Hair : I'm basically ok with this, but have one concern. There is no longer a default ant value for drops.dir, it is only set via the Makefile. Maybe that's ok, just not sure. I think it means that a plain 'ant' command will always download from the

Re: 6856630: Restructure jaxp/jaxws repository

2009-11-04 Thread Andrew John Hughes
2009/11/4 Kelly O'Hair : > > I'm basically ok with this, but have one concern. > > There is no longer a default ant value for drops.dir, it is only > set via the Makefile. Maybe that's ok, just not sure. > I think it means that a plain 'ant' command will always download > from the url. Again, maybe

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Kelly O'Hair
Alan Bateman wrote: Kelly O'Hair wrote: : It was more of a balancing act on the test groupings with regards to timings etc., and imageio did have "io" in it's name :^), and most of them ran safely in samevm mode. So we can move them to any other group that is run in samevm mode. Do you ha

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Alan Bateman
Kelly O'Hair wrote: : It was more of a balancing act on the test groupings with regards to timings etc., and imageio did have "io" in it's name :^), and most of them ran safely in samevm mode. So we can move them to any other group that is run in samevm mode. Do you have a better match than

Re: 6856630: Restructure jaxp/jaxws repository

2009-11-04 Thread Kelly O'Hair
I'm basically ok with this, but have one concern. There is no longer a default ant value for drops.dir, it is only set via the Makefile. Maybe that's ok, just not sure. I think it means that a plain 'ant' command will always download from the url. Again, maybe that's fine. So I'm ok with the pus

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Andrew John Hughes
2009/11/4 Kelly O'Hair : > > I need some formal reviewers on these jdk/test/Makefile changes. > > More polish and changes may need to be done later, but there > is value in what I have now, and I need lots of help to improve > things (and fix some of our testcases). > > Here is the bugid and webrev

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Kelly O'Hair
Alan Bateman wrote: Kelly O'Hair wrote: I need some formal reviewers on these jdk/test/Makefile changes. More polish and changes may need to be done later, but there is value in what I have now, and I need lots of help to improve things (and fix some of our testcases). Here is the bugid and

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Kelly O'Hair
Tim Bell wrote: Hi Kelly I need some formal reviewers on these jdk/test/Makefile changes. More polish and changes may need to be done later, but there is value in what I have now, and I need lots of help to improve things (and fix some of our testcases). This is a great start. Here is the

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Kelly O'Hair
Martin Buchholz wrote: One of the things you've done is to create "test sets". I did something like that in my "jtr" script (ask Tim if you can't find it). For each logical component, it's non-trivial to find all the tests for that (e.g. how to test string handling). This is especially true fo

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Jonathan Gibbons
Kelly O'Hair wrote: Jonathan Gibbons wrote: Kelly, Wow, you've been busy. The thing that stood out to me was the use of SLASH_JAVA which is something of a Sun legacy which doesn't apply to folk outside Sun. And, looking at the file as a whole, it's clear there are many different sections

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Kelly O'Hair
Jonathan Gibbons wrote: Kelly, Wow, you've been busy. The thing that stood out to me was the use of SLASH_JAVA which is something of a Sun legacy which doesn't apply to folk outside Sun. And, looking at the file as a whole, it's clear there are many different sections, not all of which ap

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Jonathan Gibbons
Martin, It would be wrong to *just* mark the broken tests as @run othervm, because then we would have no obvious way to distinguish between those tests which are intentionally othervm, and those tests which should be samevm but which are broken and have to be othervm "for now". It would be b

Re: Need reviewers - jdk testing changes 6888927

2009-11-04 Thread Alan Bateman
Kelly O'Hair wrote: I need some formal reviewers on these jdk/test/Makefile changes. More polish and changes may need to be done later, but there is value in what I have now, and I need lots of help to improve things (and fix some of our testcases). Here is the bugid and webrev: 6888927: Fix