Need reviewer: old echo -e issue and some sanity check cleanup

2010-06-14 Thread Kelly O'Hair
Need reviewer, had this change sitting around and forgot about it. 6535379: Restructure echo messages in makefiles, avoid echo -e http://cr.openjdk.java.net/~ohair/openjdk7/sanitycleanup/webrev/ Creates some common patterns for sanity errors into make macros, and changes from "echo" to "pri

Re: Review request: 6960789: com.sun.servicetag API needs to be added in ct.sym

2010-06-14 Thread Jonathan Gibbons
On 06/14/2010 10:03 AM, Mandy Chung wrote: 6960789: com.sun.servicetag API needs to be added in ct.sym Webrev at: http://cr.openjdk.java.net/~mchung/6960789/webrev.00/ This change was missing during the forward port of the service tag support from jdk 6 update to jdk 7 (6581243). Mandy L

Re: Review request: 6960789: com.sun.servicetag API needs to be added in ct.sym

2010-06-14 Thread Alan Bateman
Mandy Chung wrote: 6960789: com.sun.servicetag API needs to be added in ct.sym Webrev at: http://cr.openjdk.java.net/~mchung/6960789/webrev.00/ This change was missing during the forward port of the service tag support from jdk 6 update to jdk 7 (6581243). Mandy Looks fine to me. -Alan.

hg: jdk7/build/jdk: 6961061: make/tools/freetypecheck doesn't build with VS2010 : breaks openjdk builds

2010-06-14 Thread philip . race
Changeset: 57293ed264c4 Author:prr Date: 2010-06-14 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/57293ed264c4 6961061: make/tools/freetypecheck doesn't build with VS2010 : breaks openjdk builds Reviewed-by: ohair ! make/tools/freetypecheck/freetypecheck.c

Review request: 6960789: com.sun.servicetag API needs to be added in ct.sym

2010-06-14 Thread Mandy Chung
6960789: com.sun.servicetag API needs to be added in ct.sym Webrev at: http://cr.openjdk.java.net/~mchung/6960789/webrev.00/ This change was missing during the forward port of the service tag support from jdk 6 update to jdk 7 (6581243). Mandy

Re: DASSERT failure for FindClass("sun/java2d/SurfaceData")

2010-06-14 Thread Pete Brunet
I can run Swingset2 fine with the straight b96 build so it's something I did, perhaps to the build environment. Here are the changes I made: Modifications for VS 2010: - make sanity failed, can't find crtassem.h (MS removed it from VS 2010) modified freetypecheck.c to remove the _MSC_VER secti

Re: DASSERT failure for FindClass("sun/java2d/SurfaceData")

2010-06-14 Thread Raffaello Giulietti
I too cannot run Swing apps with the build of OpenJDK7 described here: http://mail.openjdk.java.net/pipermail/build-dev/2010-May/002955.html But my instructions describe how to use a binary FreeType for the build. This suggests that Denis is probably right about building FreeType form sources, ev

Re: DASSERT failure for FindClass("sun/java2d/SurfaceData")

2010-06-14 Thread Lussier, Denis
I could never get any Swing app to run from my OpenJDK 6 Win32 builds (check out http://openscg.org) until building Freetype myself with Visual Studio. Using VS2003 it was as simple as: - download latest source from freetype.org - convert older ms project file shipped with freetype source to you

DASSERT failure for FindClass("sun/java2d/SurfaceData")

2010-06-14 Thread Pete Brunet
In my first attempt at running a (slightly) modified OpenJDK jdk7 b96 I'm getting a crash at startup running the SwingSet2.jar from JDK6 u20. My unmodified b96 runs SwingSet2 with no crashes. (I built it with VS 2010 Pro.) Looking at the stack trace indicates a DASSERT failure in Java_sun_awt_wi