Re: Preliminary request for review: 7025066 Build system changes to support SE Embedded integration

2011-03-09 Thread David Holmes
Dr Andrew John Hughes said the following on 03/10/11 10:26: On 22:09 Wed 09 Mar , David Holmes wrote: My original reply does not seem to have made it to build-dev. I've updated the webrev again to accommodate openjdk builds that set REDUCED_JRE and/or REDUCED_HEADLESS_JRE. The main changes

hg: jdk7/build/jdk: 7025631: Remove the modules build support from jdk 7

2011-03-09 Thread mandy . chung
Changeset: 6aeed99af874 Author:mchung Date: 2011-03-09 23:11 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/6aeed99af874 7025631: Remove the modules build support from jdk 7 Reviewed-by: alanb, ohair ! make/Makefile ! make/com/sun/crypto/provider/Makefile ! make/com/sun/j

Re: JDK8 Preliminary Repository Layout

2011-03-09 Thread Phil Race
Andrew, Whilst almost everything you wrote is something I agree with (like getting jcheck out there, not adding additional build tools/complexity), the one thing I quite like right now comes up here I'd like to keep is the separate repos. Its not just hotspot, but I've been working on JDK for

Re: Review request: 7025631 "Remove the modules build support from jdk 7"

2011-03-09 Thread Mandy Chung
On 3/9/11 3:34 AM, Alan Bateman wrote: Mandy Chung wrote: 7025631: Remove the modules build support from jdk 7 Webrev at: http://cr.openjdk.java.net/~mchung/7025631/webrev.00/ These changes look okay to me too, just wondering if jdk/make/java/nio/mxbean/Makefile should be removed too.

Re: JDK8 Preliminary Repository Layout

2011-03-09 Thread Dr Andrew John Hughes
On 18:32 Tue 08 Mar , Kelly O'Hair wrote: > > First, if we talk about the mercurial forests, it has nothing to do with the > Mercurial Forest Extension. > What we really have is a set of nested repositories, sometimes called our > "forest" of repositories. > > This email is just about the a

Re: Preliminary request for review: 7025066 Build system changes to support SE Embedded integration

2011-03-09 Thread Dr Andrew John Hughes
On 22:09 Wed 09 Mar , David Holmes wrote: > My original reply does not seem to have made it to build-dev. > > I've updated the webrev again to accommodate openjdk builds that set > REDUCED_JRE and/or REDUCED_HEADLESS_JRE. The main changes are: > Another problem with these webrevs is that yo

Re: Preliminary request for review: 7025066 Build system changes to support SE Embedded integration

2011-03-09 Thread Dr Andrew John Hughes
On 09:33 Wed 09 Mar , David Holmes wrote: > Andrew, > > Dr Andrew John Hughes said the following on 03/09/11 03:24: > > On 10:51 Tue 08 Mar , David Holmes wrote: > Just to clarify for people, BUILD_CLIENT_ONLY refers to building the > client VM only. > Some of these variabl

Re: Preliminary request for review: 7025066 Build system changes to support SE Embedded integration

2011-03-09 Thread David Holmes
My original reply does not seem to have made it to build-dev. I've updated the webrev again to accommodate openjdk builds that set REDUCED_JRE and/or REDUCED_HEADLESS_JRE. The main changes are: - don't try to run freetypecheck when cross-compiling - delete build of freetypecheck from make/tool

Re: Review request: 7025631 "Remove the modules build support from jdk 7"

2011-03-09 Thread Alan Bateman
Mandy Chung wrote: 7025631: Remove the modules build support from jdk 7 Webrev at: http://cr.openjdk.java.net/~mchung/7025631/webrev.00/ These changes look okay to me too, just wondering if jdk/make/java/nio/mxbean/Makefile should be removed too. -Alan.