On 05/12/2011 10:00 PM, Kelly O'Hair wrote:
On May 12, 2011, at 4:33 PM, Omair Majid wrote:
Hi Kelly,
On 05/12/2011 04:39 PM, Kelly O'Hair wrote:
Need reviewers. (Omair, you will want to verify this works for IcedTea).
Some background: this changeset:
http://hg.openjdk.java.net/jdk7/jdk
On May 13, 2011, at 1:06 AM, David Holmes wrote:
> Kelly,
>
> I have trouble following the details of this change.
>
> Here:
>
> + # Relative path from an output directory to the image directory
> + REL_JDK_IMAGE_DIR =
> ../$(OUTPUTDIR_BASENAME-$(DEBUG_NAME))/$(JDK_IMAGE_DIRNAME)
>
In the a
A recent patch (of mine, as it happens) broke builds on Debian and
Gentoo. It was caused by a scanf call:
if (sscanf(chars, "%lx-%*lx", &x) == 1)
which looks pretty innocuous, but it triggers a warning if -Wformat is
turned on:
warning: use of assignment suppression and length modifier
Kelly,
I have trouble following the details of this change.
Here:
+ # Relative path from an output directory to the image directory
+ REL_JDK_IMAGE_DIR =
../$(OUTPUTDIR_BASENAME-$(DEBUG_NAME))/$(JDK_IMAGE_DIRNAME)
there's no indication that REL_JDK_IMAGE_DIR pertains to a debug build,
but t
