Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread David Holmes
On 3/11/2011 6:14 AM, Daniel D. Daugherty wrote: On 11/2/11 1:29 PM, Kelly O'Hair wrote: This change is both a build change and a serviceability change, but I would argue that it is more of a build change since the functionality of the jvmti demos shouldn't have changed with this. Although I am

hg: jdk8/build/langtools: 13 new changesets

2011-11-02 Thread david . katleman
Changeset: 8ff85191a7ac Author:katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8ff85191a7ac Added tag jdk8-b11 for changeset 4bf01f1c4e34 ! .hgtags Changeset: b5d0b8effc85 Author:mcimadamore Date: 2011-10-17 12:54 +0100 URL:

hg: jdk8/build/jdk: 25 new changesets

2011-11-02 Thread david . katleman
Changeset: e1f4b4b4b96e Author:katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e1f4b4b4b96e Added tag jdk8-b11 for changeset 7ab0d613cd1a ! .hgtags Changeset: 7746eb8c610b Author:bae Date: 2011-10-17 15:20 +0400 URL: http://h

hg: jdk8/build/hotspot: 11 new changesets

2011-11-02 Thread david . katleman
Changeset: 02fe430d493e Author:katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/02fe430d493e Added tag jdk8-b11 for changeset 4538caeef7b6 ! .hgtags Changeset: c9d25d93ddfe Author:jcoomes Date: 2011-10-21 16:00 -0700 URL:

hg: jdk8/build/jaxws: Added tag jdk8-b11 for changeset a12ab897a249

2011-11-02 Thread david . katleman
Changeset: e6eed2ff5d5f Author:katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/e6eed2ff5d5f Added tag jdk8-b11 for changeset a12ab897a249 ! .hgtags

hg: jdk8/build/jaxp: Added tag jdk8-b11 for changeset d1b7a4f6dd20

2011-11-02 Thread david . katleman
Changeset: ca977d167697 Author:katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/ca977d167697 Added tag jdk8-b11 for changeset d1b7a4f6dd20 ! .hgtags

hg: jdk8/build: Added tag jdk8-b11 for changeset 1defbc57940a

2011-11-02 Thread david . katleman
Changeset: 8e2104d565ba Author:katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/8e2104d565ba Added tag jdk8-b11 for changeset 1defbc57940a ! .hgtags

hg: jdk8/build/corba: Added tag jdk8-b11 for changeset 0199e4fef5cc

2011-11-02 Thread david . katleman
Changeset: 31d70911b712 Author:katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/31d70911b712 Added tag jdk8-b11 for changeset 0199e4fef5cc ! .hgtags

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Keith McGuigan
Didn't Dan Dougherty review this too? Is he a "reviewer" for this project? If it helps you can put me down as a reviewer (kamg). On Nov 2, 2011, at 2:54 PM, Neil Richards wrote: On Wed, 2011-11-02 at 14:07 -0400, Zhengyu Gu wrote: Hi Neil, My understanding is that you need to have at le

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Kelly O'Hair
This change is both a build change and a serviceability change, but I would argue that it is more of a build change since the functionality of the jvmti demos shouldn't have changed with this. Although I am listed as a member of the serviceability "group", I'm not exactly sure who leads that gr

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Neil Richards
On Wed, 2011-11-02 at 14:07 -0400, Zhengyu Gu wrote: > Hi Neil, > > My understanding is that you need to have at least two reviewers who > have 'reviewer' privilege, (and I don't have 'reviewer' privilege). > I had a quick leaf through the OpenJDK Bylaws. It looks like the number of necessary

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Zhengyu Gu
Hi Neil, My understanding is that you need to have at least two reviewers who have 'reviewer' privilege, (and I don't have 'reviewer' privilege). Yes, I am tied up, if you can handle the push, that will be great. What java bug id you need? can you use CR 6988099? BTW, here is the link to al

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Neil Richards
On Thu, 2011-10-20 at 09:21 -0700, Kelly O'Hair wrote: > Looks good. > > > -kto > Hi Zhengyu, Given Kelly's blessing, are you now happy to push this change to jdk8? (If you're otherwise tied up, I can drive the mechanics of the push if you provide me with a suitable java bug id to use.) Regar