Re: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation

2011-11-28 Thread David Holmes
Thanks Stuart - looks okay to me. David On 29/11/2011 2:00 PM, Stuart Marks wrote: On 11/28/11 7:00 PM, David Holmes wrote: On 29/11/2011 10:42 AM, Stuart Marks wrote: Please review this change to add to the javac make rule some messages about the number of files being compiled, the current

Re: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation

2011-11-28 Thread Stuart Marks
On 11/28/11 7:00 PM, David Holmes wrote: On 29/11/2011 10:42 AM, Stuart Marks wrote: Please review this change to add to the javac make rule some messages about the number of files being compiled, the current working directory, and a new message to demarcate the end of javac output. This will

Re: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation

2011-11-28 Thread David Holmes
Hi Stuart, On 29/11/2011 10:42 AM, Stuart Marks wrote: Please review this change to add to the javac make rule some messages about the number of files being compiled, the current working directory, and a new message to demarcate the end of javac output. This will help capture and analyze javac

JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011

2011-11-28 Thread Xiomara Jayasena
A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st. We would like to invite you to participate. To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8. If you decide to participate then pl

please review fix for 7116322, enhance javac make rule with a little bit of instrumentation

2011-11-28 Thread Stuart Marks
Please review this change to add to the javac make rule some messages about the number of files being compiled, the current working directory, and a new message to demarcate the end of javac output. This will help capture and analyze javac output, in particular, warning messages. Thanks. s'm

Re: (XS) Request for review: 7109092 - link changes for embedded builds

2011-11-28 Thread Kelly O'Hair
Looks ok to me. -kto On Nov 22, 2011, at 10:55 PM, David Holmes wrote: > We need to make an adjustment to the link instructions used for libjava in > embedded builds, as defined in Defs-embedded.gmk > > webrev: http://cr.openjdk.java.net/~dholmes/7109092/webrev/ > > Summary: system soft-float

Re: jdk/src/solaris - time to re-visit it?

2011-11-28 Thread Ulf Zibis
Additionaly I think, 'share' should be replaced by 'common'. 'share', as a verb, seems ugly along 'posix', 'winapi' to me. -Ulf Am 28.11.2011 17:20, schrieb Fredrik Öhrström: 2011-11-28 16:46, Ulf Zibis skrev: I guess you meant: --shared --posix |--SYSV ||--solaris

Re: jdk/src/solaris - time to re-visit it?

2011-11-28 Thread Fredrik Öhrström
2011-11-28 16:46, Ulf Zibis skrev: > I guess you meant: > --shared > --posix >|--SYSV >||--solaris >||--aix >| >|--gnu >||--linux >|| >|--BSD > |--darwin > |--freebsd > > --winapi > |--win32

Re: jdk/src/solaris - time to re-visit it?

2011-11-28 Thread Ulf Zibis
Am 27.11.2011 22:29, schrieb Mike Duigou: Only if necessary hopefully. As we have shared and platform code we might have shared |--posix ||--SYSV |||--solaris |||--aix || ||--gnu |||--linux ||| ||--BSD | |--dar