Re: please review 7122061: enable -Werror in various jdk build steps

2011-12-15 Thread David Holmes
Hi Stuart, On 16/12/2011 12:59 PM, Stuart Marks wrote: The webrev is here: http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.0/ Looks fine but ... This defines the JAVAC_MAX_WARNINGS and JAVAC_WARNINGS_FATAL variables in a variety of Makefiles within the jdk repository. This essenti

Re: please review 7122061: enable -Werror in various jdk build steps

2011-12-15 Thread Kelly O'Hair
Looks ok. -kto On Dec 15, 2011, at 6:59 PM, Stuart Marks wrote: > The webrev is here: > > http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.0/ > > This defines the JAVAC_MAX_WARNINGS and JAVAC_WARNINGS_FATAL variables in a > variety of Makefiles within the jdk repository. This essenti

please review 7122061: enable -Werror in various jdk build steps

2011-12-15 Thread Stuart Marks
The webrev is here: http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.0/ This defines the JAVAC_MAX_WARNINGS and JAVAC_WARNINGS_FATAL variables in a variety of Makefiles within the jdk repository. This essentially adds -Xlint:all -Werror to the javac command lines, so that henceforth i

hg: jdk8/build/jdk: 2 new changesets

2011-12-15 Thread michael . fang
Changeset: 60dd940eb58e Author:yhuang Date: 2011-12-12 18:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/60dd940eb58e 7003124: In Bulgarian Locale DateFormat is wrong Reviewed-by: naoto, peytoia ! src/share/classes/sun/text/resources/FormatData_bg.java ! test/sun/text/