Similar to jaxp change, but the source normalization was not needed.
7150322: Stop using drop source bundles in jaxws
http://cr.openjdk.java.net/~ohair/openjdk8/infra-jaxws/webrev/
I'm working on helping to get the jdk8 build-infra changes integrated, this is
for jaxws.
This is just the changes
A TAB takes you to a specific TAB spot, default is one TAB stop every 8
characters in a line.
So the conversion is not just 'replace TAB with N characters'.
This is one of the issues with TABs, they aren't as predictable as people might
think, especially
when mixed with spaces or placed in any lo
On 03/02/2012 03:04 PM, David Holmes wrote:
On 3/03/2012 3:12 AM, Kelly O'Hair wrote:
I don't understand the question. It only changes TAB characters,
removes trailing whitespace on lines,
and duplicate blank lines at the end of the file.
I think the issue is what does it replace a TAB with? 4
Changeset: 38207a5797ab
Author:ohair
Date: 2012-03-02 15:33 -0800
URL: http://hg.openjdk.java.net/jdk8/build/rev/38207a5797ab
6625113: Add the normalize and rmkw perl script to the openjdk repository or
openjdk site?
Reviewed-by: darcy
+ make/scripts/normalizer.pl
On 3/03/2012 3:12 AM, Kelly O'Hair wrote:
I don't understand the question. It only changes TAB characters, removes
trailing whitespace on lines,
and duplicate blank lines at the end of the file.
I think the issue is what does it replace a TAB with? 4 spaces for JDK
or 2 spaces for Hotspot?
It looks OK to me but I'm not an ant expert.
-phil.
On 3/2/2012 12:57 PM, Kelly O'Hair wrote:
7150324: Stop using drop bundles in jaxp
http://cr.openjdk.java.net/~ohair/openjdk8/infra-jaxp/webrev/
I'm working on helping to get the jdk8 build-infra changes integrated, this is
for jaxp.
This i
7150324: Stop using drop bundles in jaxp
http://cr.openjdk.java.net/~ohair/openjdk8/infra-jaxp/webrev/
I'm working on helping to get the jdk8 build-infra changes integrated, this is
for jaxp.
This is just the changes to the build files to remove the use of the drop
bundles and add a new Makefi
It IS the script that was used on the original sources, so it has value being
added 'as is'.
As to whether replacing the TABs in string literals is a bug, depends on your
point of view, but
even if you called it a bug, I'm just not sure it's worth fixing at this point.
Like I've said, this scrip
I don't understand the question. It only changes TAB characters, removes
trailing whitespace on lines,
and duplicate blank lines at the end of the file.
-kto
On Mar 2, 2012, at 1:00 AM, Staffan Larsen wrote:
> Does this handle the difference between indents in HotSpot (indent 2) vs the
> JDK (
On Mar 2, 2012, at 12:06 AM, Dmitry Samersoff wrote:
> David,
>
> On 2012-03-02 11:55, David Holmes wrote:
>> In what circumstances would a literal with an embedded tab be valid?
>> AFAIK we should always be using /t.
>
> It's a bad practice and probably we don't have such places in JDK,
> but
Kelly,
As far as I agree that plain tab should not be used within string
constant I'm against of adding script that have clear visible bug in it.
-Dmitry
On 2012-03-02 20:56, Kelly O'Hair wrote:
>
> On Mar 1, 2012, at 11:52 PM, Dmitry Samersoff wrote:
>
>> Kelly,
>>
>> 1.
>> Why perl? As far
On Mar 1, 2012, at 11:55 PM, David Holmes wrote:
> On 2/03/2012 5:52 PM, Dmitry Samersoff wrote:
>> Kelly,
>>
>> 1.
>> Why perl? As far as I know this it the only dependency to perl
>> in build system.
>>
>> I think we have to count and minimize set of third-party
>> utilities and interpret
On Mar 1, 2012, at 11:52 PM, Dmitry Samersoff wrote:
> Kelly,
>
> 1.
> Why perl? As far as I know this it the only dependency to perl
> in build system.
>
> I think we have to count and minimize set of third-party
> utilities and interpreters we are using. So I'm for python -
> mercurial marry
* Andrew Hughes [2012-03-02 10:09]:
> - Original Message -
> > * Andrew Hughes [2012-03-01 15:40]:
> > > - Original Message -
> > > > * Kelly O'Hair [2012-02-29 20:39]:
> > > > > The sample.makefile.txt files may not even be used during the
> > > > > build, I'm not sure.
> > > >
- Original Message -
> * Andrew Hughes [2012-03-01 15:40]:
> > - Original Message -
> > > * Kelly O'Hair [2012-02-29 20:39]:
> > > > The sample.makefile.txt files may not even be used during the
> > > > build, I'm not sure.
> > > > They may have only been supplied as documentation
Hi,
the dependency on ant for the langtools repo, encoded into the build
tools CompilePropertiesTask and GenStubs,
can be separated into a separate package.
This enables build-infra makefiles to compile langtools without the
ant.jar simply by avoiding the ant specific package.
Ant can of course s
Does this handle the difference between indents in HotSpot (indent 2) vs the
JDK (indent 4)?
/Staffan
On 1 mar 2012, at 22:32, Kelly O'Hair wrote:
>
> Need reviewer. Adding the whitespace normalizer script as a convenience to
> the jdk developers.
>
> 6625113: Add the normalize and rmkw per
David,
On 2012-03-02 11:55, David Holmes wrote:
> In what circumstances would a literal with an embedded tab be valid?
> AFAIK we should always be using /t.
It's a bad practice and probably we don't have such places in JDK,
but it's perfectly valid for Java language and I see no reason to
replace
18 matches
Mail list logo
