hg: jdk8/build/jdk: 14 new changesets

2012-03-15 Thread michael . fang
Changeset: 9288904e0027 Author:mfang Date: 2012-02-08 10:18 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9288904e0027 Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launc

Re: RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

2012-03-15 Thread Kelly O'Hair
On Mar 15, 2012, at 12:57 PM, Fredrik Öhrström wrote: > > - [email protected] skrev: > >> I don't know, and I don't have the expertise in the build system to >> know how other LANG settings would affect the build. Perhaps somebody else on >> build-dev knows. Meanwhile, we're patching

Re: RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

2012-03-15 Thread Fredrik Öhrström
- [email protected] skrev: > I don't know, and I don't have the expertise in the build system to > know how other LANG settings would affect the build. Perhaps somebody else on > build-dev knows. Meanwhile, we're patching things up this way, even though it > makes things a bit messier.

Re: RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

2012-03-15 Thread Michael McMahon
It definitely works with LANG=en_US.UTF-8 (and other en country variants). It definitely doesn't**work in the zh_CN locale, as was reported recently. The reason evidently is a dependency in the build on the output format of the date command. Which other locales it works in, I don't know. So, I

Re: RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

2012-03-15 Thread Mike Duigou
I am curious why fixing CR 7151897 wasn't pursued instead? It would be nice to move out of the LANG=C stone age. More environments are moving to localized defaults. Is there a compelling reason to require LANG=C? It seems like our build process should not be dependent upon the host environment

Re: RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

2012-03-15 Thread Kelly O'Hair
On Mar 15, 2012, at 11:57 AM, Stuart Marks wrote: > I agree, there's a larger question about LANG that needs to be asked here. > > From a pragmatic point of view, I ran into a build issue that boiled down to > the absence of LANG in my environment in certain cases (ssh vs VNC). > README-builds

Re: RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

2012-03-15 Thread Stuart Marks
I agree, there's a larger question about LANG that needs to be asked here. From a pragmatic point of view, I ran into a build issue that boiled down to the absence of LANG in my environment in certain cases (ssh vs VNC). README-builds.html recommends setting LANG=C for OpenSolaris and all the

Re: RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

2012-03-15 Thread Stuart Marks
Looks good to me too. I've updated the Mac build instructions on the wiki to state that LANG should be set. s'marks On 3/15/12 9:30 AM, Kelly O'Hair wrote: Looks fine to me. -kto On Mar 15, 2012, at 9:18 AM, Michael McMahon wrote: Can I get the following jdk8 change reviewed please? It is

Re: RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

2012-03-15 Thread Kelly O'Hair
Looks fine to me. -kto On Mar 15, 2012, at 9:18 AM, Michael McMahon wrote: > Can I get the following jdk8 change reviewed please? > > It is a simple sanity check on Mac OS X to ensure that > LANG is set in the environment. Currently, the build fails > if it's not set, but the failure is quite o

RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

2012-03-15 Thread Michael McMahon
Can I get the following jdk8 change reviewed please? It is a simple sanity check on Mac OS X to ensure that LANG is set in the environment. Currently, the build fails if it's not set, but the failure is quite obscure. http://cr.openjdk.java.net/~michaelm/7151898/webrev.1/ Thanks Michael.