Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

Ok, thanks! Thumb up. Thanks, Serguei On 3/17/12 6:29 PM, Daniel D. Daugherty wrote: Thanks for the review. Replies embedded below... Dan, I've reviewed this: http://cr.openjdk.java.net/~dcubed/fds_revamp/7102323-webrev/1-hotspot-full/ Wow, you fixed two existing bugs in the make file:

Re: Review Request: 7141246 build-infra merge: Introduce new JVM_VARIANT* to control which kind of jvm gets built

Hi Erik, On 16/03/2012 7:24 PM, Erik Joelsson wrote: http://cr.openjdk.java.net/~erikj/7141246/webrev.03/ Looks fine. Removed all references to "minimal". Also cleaned up the defaults section a bit. Minor nit, when you say: # On 32