Re: Review Request: Build-infra M1

2012-03-21 Thread David Holmes
Hi Erik, On 22/03/2012 12:07 AM, Erik Joelsson wrote: As outlined in [1], the build-infra project would like to push the current work into jdk8 in order to expose it to a wider audience. The webrevs are made against the jdk8/build forest. In each repository, there are two kinds of changes: 1. C

Re: Patch to fix build breakage with GCC 4.7

2012-03-21 Thread David Holmes
On 22/03/2012 12:30 PM, Daniel D. Daugherty wrote: That would be this: Changeset: fb3a2cafc230 Author: andrew Date: 2012-03-08 14:04 + URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb3a2cafc230 Thanks Dan! I see it came in through the build repo which is why I couldn't find it. Now I

Re: Patch to fix build breakage with GCC 4.7

2012-03-21 Thread Daniel D. Daugherty
That would be this: Changeset: fb3a2cafc230 Author:andrew Date: 2012-03-08 14:04 + URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb3a2cafc230 7150392: Linux build breaks with GCC 4.7 due to unrecognized option Summary: Remove -mimpure-text option. Reviewed-by: ohair, dholm

Re: Patch to fix build breakage with GCC 4.7

2012-03-21 Thread David Holmes
Did this get pushed somewhere? David On 3/03/2012 1:11 AM, Deepak Bhole wrote: * Andrew Hughes [2012-03-02 10:09]: - Original Message - * Andrew Hughes [2012-03-01 15:40]: - Original Message - * Kelly O'Hair [2012-02-29 20:39]: The sample.makefile.txt files may not even

hg: jdk8/build/langtools: Added tag jdk8-b30 for changeset 08a3425f39f8

2012-03-21 Thread david . katleman
Changeset: b28cfbe7e8b1 Author:katleman Date: 2012-03-15 15:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b28cfbe7e8b1 Added tag jdk8-b30 for changeset 08a3425f39f8 ! .hgtags

hg: jdk8/build/jdk: 2 new changesets

2012-03-21 Thread david . katleman
Changeset: c373b5baa1e9 Author:katleman Date: 2012-03-15 15:17 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c373b5baa1e9 Added tag jdk8-b30 for changeset cdbb33303ea3 ! .hgtags Changeset: 27f0c08c427c Author:katleman Date: 2012-03-21 12:18 -0700 URL: htt

hg: jdk8/build/jaxp: Added tag jdk8-b30 for changeset 3be30c25a825

2012-03-21 Thread david . katleman
Changeset: 94aabe098916 Author:katleman Date: 2012-03-15 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/94aabe098916 Added tag jdk8-b30 for changeset 3be30c25a825 ! .hgtags

hg: jdk8/build/jaxws: Added tag jdk8-b30 for changeset 6882b10e85d6

2012-03-21 Thread david . katleman
Changeset: 4c41c6d0e15d Author:katleman Date: 2012-03-15 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/4c41c6d0e15d Added tag jdk8-b30 for changeset 6882b10e85d6 ! .hgtags

hg: jdk8/build/hotspot: Added tag jdk8-b30 for changeset d61761bf3050

2012-03-21 Thread david . katleman
Changeset: 02ba95965d78 Author:katleman Date: 2012-03-15 15:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/02ba95965d78 Added tag jdk8-b30 for changeset d61761bf3050 ! .hgtags

hg: jdk8/build: Added tag jdk8-b30 for changeset 6cea54809b51

2012-03-21 Thread david . katleman
Changeset: 0b66f43b89a6 Author:katleman Date: 2012-03-15 15:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/0b66f43b89a6 Added tag jdk8-b30 for changeset 6cea54809b51 ! .hgtags

hg: jdk8/build/corba: 2 new changesets

2012-03-21 Thread david . katleman
Changeset: d6b04e3e40e2 Author:katleman Date: 2012-03-15 15:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/d6b04e3e40e2 Added tag jdk8-b30 for changeset 4605f8418bf5 ! .hgtags Changeset: 1954151dfae8 Author:katleman Date: 2012-03-21 12:18 -0700 URL: h

Re: RFR: 7155585: Fix ifeq errors in makefiles [macosx]

2012-03-21 Thread Dmitry Samersoff
Looks good for me too. -Dmitry On 2012-03-21 19:45, Fredrik Öhrström wrote: > 2012-03-21 16:03, Michael McMahon skrev: >> Could I get the following change reviewed please for jdk 8? >> >> It is to fix a number of minor build warnings caused by the macosx changes. >> >> http://cr.openjdk.java.net/

Re: Review Request: Build-infra M1

2012-03-21 Thread Fredrik Öhrström
2012-03-21 16:43, Andrew Hughes skrev: > I haven't tried this out yet, but I'll try and give it a spin in build-infra. > > One thing that did stand out from the patch is that generated files such as > configure are being checked in. For updates to this, is there a plan to > mandate the use of a sp

Re: RFR: 7155585: Fix ifeq errors in makefiles [macosx]

2012-03-21 Thread Fredrik Öhrström
2012-03-21 16:03, Michael McMahon skrev: > Could I get the following change reviewed please for jdk 8? > > It is to fix a number of minor build warnings caused by the macosx changes. > > http://cr.openjdk.java.net/~michaelm/7155585/webrev.1/ > > Thanks > Michael Looks good. //Fredrik

Re: Review Request: Build-infra M1

2012-03-21 Thread Jonathan Gibbons
Erik, Fredrik, The need to run GenStubs in the LangTools build is a somewhat transient one. During JDK 7 we needed it; right now, we don't, but based on the work going into other forests, we will need it again soon, when Lambda and Jigsaw make it into JDK 8. In the proposed Makefiles, the us

Re: RFR: 7155585: Fix ifeq errors in makefiles [macosx]

2012-03-21 Thread Andrew Hughes
- Original Message - > Could I get the following change reviewed please for jdk 8? > > It is to fix a number of minor build warnings caused by the macosx > changes. > > http://cr.openjdk.java.net/~michaelm/7155585/webrev.1/ > > Thanks > Michael > Looks good to me. Pretty obvious fix :

Re: Review Request: Build-infra M1

2012-03-21 Thread Andrew Hughes
- Original Message - > As outlined in [1], the build-infra project would like to push the > current work into jdk8 in order to expose it to a wider audience. > The webrevs are made against the jdk8/build forest. In each > repository, there are two kinds of changes: > > 1. Changes to old mak

RFR: 7155585: Fix ifeq errors in makefiles [macosx]

2012-03-21 Thread Michael McMahon
Could I get the following change reviewed please for jdk 8? It is to fix a number of minor build warnings caused by the macosx changes. http://cr.openjdk.java.net/~michaelm/7155585/webrev.1/ Thanks Michael

Review Request: Build-infra M1

2012-03-21 Thread Erik Joelsson
As outlined in [1], the build-infra project would like to push the current work into jdk8 in order to expose it to a wider audience. The webrevs are made against the jdk8/build forest. In each repository, there are two kinds of changes: 1. Changes to old makefiles