Re: Where does 'make sanity' look for the ANT version?

2012-03-27 Thread Martijn Verburg
Hi Stuart, Thanks for looking into that for me, I'll keep a note of the location of Sanity.gmk going forwards. I have managed to resolve the issue, it was a curious case where my 1.8.2 ANT install couldn't find $ALT_BOOTDIR//lib/tools.jar and therefore 'failed', the build then defaulted back to a

Re: Where does 'make sanity' look for the ANT version?

2012-03-27 Thread Stuart Marks
Hi Martijn! One of my colleagues ran into this the other day. I don't know all the details and the solution but I have a clue that might help you move forward. In make/common/shared/Sanity.gmk there are the lines, _ANT_VER:=$(shell $(ANT) -version 2>&1 ) ANT_VER:=$(call GetVersion,"$(_ANT_VE

Re: Review Request: Build-infra M1

2012-03-27 Thread Fredrik Öhrström
2012-03-27 17:21, Michael McMahon skrev: Right. Configure doesn't need to be re-run, but presumably there is some build meta-information linking sources to target libraries etc. Say a new native library libfoo were to be added with associated C (and Java) sources. Where would this get added t

Re: Review Request: Build-infra M1

2012-03-27 Thread Michael McMahon
On 27/03/12 16:04, Fredrik Öhrström wrote: 2012-03-27 16:39, Michael McMahon skrev: A few more things I'd like to understand are: 1) In what circumstances exactly would the configure script have to be re-run? You run configure once to setup a particular build configuration. After it is run

Re: Review Request: Build-infra M1

2012-03-27 Thread Fredrik Öhrström
2012-03-27 16:39, Michael McMahon skrev: A few more things I'd like to understand are: 1) In what circumstances exactly would the configure script have to be re-run? You run configure once to setup a particular build configuration. After it is run, you only need to run make for the build co

Re: Review Request: Build-infra M1

2012-03-27 Thread Michael McMahon
A few more things I'd like to understand are: 1) In what circumstances exactly would the configure script have to be re-run? 2) Can you give examples of the kind of build changes that would be needed :- - when a small'ish change is made (eg adding a couple of new source files, or renami

Re: Review Request: Build-infra M1

2012-03-27 Thread Alan Bateman
This isn't really an issue for the first push, more of a question as to how this will all look once the remaining make files has been converted. My question relates to jdk/makefiles/CompileJavaClasses.gmk and CompileNativeLibraries.gmk and how they will be maintained more longer term. Is the

Re: Need JDK Reviewer for SIMPLE change! Free Karma!

2012-03-27 Thread Nils Loodin
Thank you sir, your Karma-points will be transferred to you within three Karma-bank days! Regards Nils Loodin On Mar 27, 2012, at 12:49 , David Holmes wrote: > On 27/03/2012 6:10 PM, Nils Loodin wrote: >> Resending this. Simple change, just need a reviewer from a JDK reviewer :) > > Looks good

Re: Need JDK Reviewer for SIMPLE change! Free Karma!

2012-03-27 Thread David Holmes
On 27/03/2012 6:10 PM, Nils Loodin wrote: Resending this. Simple change, just need a reviewer from a JDK reviewer :) Looks good to me. David - Regards Nils Loodin On Mar 24, 2012, at 00:45 , Nils Loodin wrote: Removed a folder in a jar-file and the classes into other folders, so some

Need JDK Reviewer for SIMPLE change! Free Karma!

2012-03-27 Thread Nils Loodin
Resending this. Simple change, just need a reviewer from a JDK reviewer :) Regards Nils Loodin On Mar 24, 2012, at 00:45 , Nils Loodin wrote: > Removed a folder in a jar-file and the classes into other folders, so some of > the lines in Release.gmk became unnecessary. > This should be cleaned u