Re: code review request for initial JDK FDS support (7071907)

2012-04-12 Thread Daniel D. Daugherty
Thanks Serguei! Dan On 4/12/12 4:02 PM, [email protected] wrote: Looks good. Thanks, Serguei On 4/12/12 2:03 PM, Daniel D. Daugherty wrote: The wonderful T&L nightly testing caught an error in my changes that were reviewed on this thread. On Linux and Solaris, I installed the .debu

Re: code review request for initial JDK FDS support (7071907)

2012-04-12 Thread [email protected]
Looks good. Thanks, Serguei On 4/12/12 2:03 PM, Daniel D. Daugherty wrote: The wonderful T&L nightly testing caught an error in my changes that were reviewed on this thread. On Linux and Solaris, I installed the .debuginfo files for programs in $JAVA_HOME/bin. I made a mistake in the way I inte

Re: code review request for initial JDK FDS support (7071907)

2012-04-12 Thread Daniel D. Daugherty
Thanks Kumar! Dan On 4/12/12 3:42 PM, Kumar Srinivasan wrote: On 4/12/2012 2:03 PM, Daniel D. Daugherty wrote: The wonderful T&L nightly testing caught an error in my changes The change looks good to me. Thanks Kumar that were reviewed on this thread. On Linux and Solaris, I installed t

Re: code review request for initial JDK FDS support (7071907)

2012-04-12 Thread Kumar Srinivasan
On 4/12/2012 2:03 PM, Daniel D. Daugherty wrote: The wonderful T&L nightly testing caught an error in my changes The change looks good to me. Thanks Kumar that were reviewed on this thread. On Linux and Solaris, I installed the .debuginfo files for programs in $JAVA_HOME/bin. I made a mista

Re: code review request for initial JDK FDS support (7071907)

2012-04-12 Thread Daniel D. Daugherty
The wonderful T&L nightly testing caught an error in my changes that were reviewed on this thread. On Linux and Solaris, I installed the .debuginfo files for programs in $JAVA_HOME/bin. I made a mistake in the way I interpreted what I was seeing in the Windows code and in $JAVA_HOME/jre/bin. Long

Re: First build-infra push to jdk8 -- try out the new build system!

2012-04-12 Thread Kelly O'Hair
On Apr 12, 2012, at 2:47 AM, Magnus Ihse Bursie wrote: > The build-infra project [1] has been working for a while with creating a new > build system. The goals of the project include, but are not limited to, > improved build performance and improved ease of use. > > The first part of this proj

Re: code review request for initial JDK FDS support (7071907)

2012-04-12 Thread Kelly O'Hair
On Apr 12, 2012, at 7:44 AM, Daniel D. Daugherty wrote: >> >> Why do we need to change compiler flags besides symbol generation ? >> >> e.g. for gcc -O3 -g3 is perfectly valid combination. > > You'd have to dig into the history of why a FASTDEBUG flavor build > chose the options that it did. A

hg: jdk8/build/jdk: 2 new changesets

2012-04-12 Thread kelly . ohair
Changeset: cf5b15ae858a Author:ohair Date: 2012-04-12 08:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cf5b15ae858a 7160976: Fix missing file in new build infrastructure: Defs-utils.gmk Reviewed-by: ihse + makefiles/common/shared/Defs-utils.gmk Changeset: 468cf87890b

Re: code review request for initial JDK FDS support (7071907)

2012-04-12 Thread Dmitry Samersoff
Dan, OK. Sorry for disturbing you. -Dmitry On 2012-04-12 18:44, Daniel D. Daugherty wrote: On 4/12/12 8:39 AM, Dmitry Samersoff wrote: Dan, We link two semantically different options together and it make me uncomfortable with this fix. This JDK fix has the exact same semantics as the HotSp

Re: code review request for initial JDK FDS support (7071907)

2012-04-12 Thread Daniel D. Daugherty
On 4/12/12 8:39 AM, Dmitry Samersoff wrote: Dan, We link two semantically different options together and it make me uncomfortable with this fix. This JDK fix has the exact same semantics as the HotSpot changes that I did for FDS. As I keep saying over and over and over, a Full Debug Symbols b

Re: code review request for initial JDK FDS support (7071907)

2012-04-12 Thread Dmitry Samersoff
Dan, We link two semantically different options together and it make me uncomfortable with this fix. Why do we need to change compiler flags besides symbol generation ? e.g. for gcc -O3 -g3 is perfectly valid combination. -Dmitry On 2012-04-12 17:50, Daniel D. Daugherty wrote: On 4/11/12

Request for review: Defs-util.gmk missing in new build system, preventing build

2012-04-12 Thread Magnus Ihse Bursie
Background: Building with the new build system fails with ".../common/shared/Defs-utils.gmk: No such file or directory" in the build forest, but not in the build-infra forest. It turned out that a file got missing (!) when we did the integration from the build-infra forest to the build forest.

Re: code review request for initial JDK FDS support (7071907)

2012-04-12 Thread Daniel D. Daugherty
On 4/11/12 7:24 PM, Mikael Vidstedt wrote: On 2012-04-10 14:53, Daniel D. Daugherty wrote: On 4/10/12 3:47 PM, Dmitry Samersoff wrote: 1. 239 # If Full Debug Symbols is enabled, then we want the same debug and 240 # optimization flags as used by FASTDEBUG. We also want all the 241 # deb

First build-infra push to jdk8 -- try out the new build system!

2012-04-12 Thread Magnus Ihse Bursie
The build-infra project [1] has been working for a while with creating a new build system. The goals of the project include, but are not limited to, improved build performance and improved ease of use. The first part of this project has now been pushed to the jdk8 master forest. This means tha

Re: 'One-off' directory error when running jtreg

2012-04-12 Thread Martijn Verburg
Hi all, That did trick, thanks all. Will try the build-infra build next. Cheers, Martijn On 9 April 2012 21:01, Kelly O'Hair wrote: > Set PRODUCT_HOME manually. > The Makefile can only guess where the build might be, and although we > could add in a second guess, that > could be a problem too