hg: jdk8/build/jdk: 7171653: 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash

2012-05-29 Thread david . holmes
Changeset: 8b4dd321b8a2 Author:dholmes Date: 2012-05-30 00:37 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8b4dd321b8a2 7171653: 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash Reviewed-by: ohair, anthony ! make/sun/xawt/Mak

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-29 Thread Kelly O'Hair
On May 29, 2012, at 10:55 AM, Andrew Haley wrote: > On 05/29/2012 06:12 PM, Kelly O'Hair wrote: >> >> You should be able to do something like: >> >> # Turn off aliasing with GCC for ExtensionSubtables.cpp >> ifeq ($(PLATFORM), linux) >> CXXFLAGS += $(CXXFLAGS_$(@F)) >> CC_NEWER_THAN_43 := \ >

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-29 Thread Damon Hart-Davis
That is indeed the sort of horror we used to implement out DontOptimise(something.cpp) and DontOptimiseMuch(somethingelse.cpp) macros at a now-famously-defunct investment bank. The code outlived the bank... B^> Rgds Damon On 29 May 2012, at 18:12, Kelly O'Hair wrote: > > You should be abl

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-29 Thread Andrew Haley
On 05/29/2012 06:12 PM, Kelly O'Hair wrote: > > You should be able to do something like: > > # Turn off aliasing with GCC for ExtensionSubtables.cpp > ifeq ($(PLATFORM), linux) > CXXFLAGS += $(CXXFLAGS_$(@F)) > CC_NEWER_THAN_43 := \ > $(shell $(EXPR) $(CC_MAJORVER) \> 4 \| \ >

Re: Bug in FDS for Solaris?

2012-05-29 Thread Daniel D. Daugherty
Definitely something wrong here... When I originally did these changes, here was the thinking: 230 # If Full Debug Symbols is enabled, then we want the same debug and 231 # optimization flags as used by FASTDEBUG. We also want all the 232 # debug info in one place (-xs). 233 #

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-29 Thread Kelly O'Hair
You should be able to do something like: # Turn off aliasing with GCC for ExtensionSubtables.cpp ifeq ($(PLATFORM), linux) CXXFLAGS += $(CXXFLAGS_$(@F)) CC_NEWER_THAN_43 := \ $(shell $(EXPR) $(CC_MAJORVER) \> 4 \| \ \( $(CC_MAJORVER) = 4 \& $(CC_MINORVER) \> 3 \) ) ifeq

Re: RFR: 7171653 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash

2012-05-29 Thread Kelly O'Hair
Build-dev please. -kto On May 27, 2012, at 6:10 PM, David Holmes wrote: > I have a review from AWT (thanks Anthony), can I have one from build please. > > Any preference as to where to push this? > > Thanks, > David > > On 25/05/2012 4:20 PM, David Holmes wrote: >> This is a tweak to the cros

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-29 Thread Phil Race
I have one concern It sounds like the option is new in gcc 4.4 : http://gcc.gnu.org/gcc-4.4/porting_to.html I am not sure you can assume that since .. http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html#gcc " The GNU gcc compiler version should be 4.3 or newer." And I sugges

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-29 Thread Andrew Hughes
- Original Message - > In anticipation of the updated fix I created > 7171223 : Building ExtensionSubtables.cpp should use > -fno-strict-aliasing > > -phil. > > > Ok for jdk8? If so, can I have a bug ID for this please? > > > > Thanks, > > Thanks for the bug ID, Phil. Here's the revi

Bug in FDS for Solaris?

2012-05-29 Thread Magnus Ihse Bursie
When converting old makefiles to the new build-infra, we discovered what seems to be a bug for Full Debug Symbols on Solaris. In the file make/common/Defs-solaris.gmk, the following code (somewhat edited) was added: ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) ifeq ($(LIBRARY_SUPPORTS_FULL_DEBUG_S