Greetings,
I've updated the fix to (hopefully) address Kelly's and David H's
concerns. Here is the URL for code review round 1:
http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/1/
Brief summary of changes relative to code review round 0:
- removed definition of GENERATED from both
You still have repeated patterns like:
131 ( set -e ; \
132 cd $(XLIBJVM_DIR) ; \
133 $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \
134 )
When
131 ( cd $(XLIBJVM_DIR) $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO)
$(LIBJVM_DB) )
does
On 6/20/12 10:41 AM, Kelly O'Hair wrote:
You still have repeated patterns like:
131 ( set -e ; \
132 cd $(XLIBJVM_DIR) ; \
133 $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \
134 )
When
131 ( cd $(XLIBJVM_DIR)
On 6/20/12 10:44 AM, Daniel D. Daugherty wrote:
On 6/20/12 10:41 AM, Kelly O'Hair wrote:
You still have repeated patterns like:
131 ( set -e ; \
132 cd $(XLIBJVM_DIR) ; \
133 $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO)
$(LIBJVM_DB) ; \
134 )
When
Kelly,
The JPRT job testing the latest HSX-24 version has finished and I
have identical test results to the original version of this fix.
The JPRT job testing the latest HSX-23.2 version is still running,
but so far there are no issues.
Could you let me know if this latest version resolves your
Looks fine.
-kto
On Jun 20, 2012, at 12:04 PM, Daniel D. Daugherty wrote:
Kelly,
The JPRT job testing the latest HSX-24 version has finished and I
have identical test results to the original version of this fix.
The JPRT job testing the latest HSX-23.2 version is still running,
but so
Thanks!
Dan
On 6/20/12 3:03 PM, David Holmes wrote:
Looks good to me Dan!
Thanks,
David
On 21/06/2012 3:02 AM, Daniel D. Daugherty wrote:
On 6/20/12 10:44 AM, Daniel D. Daugherty wrote:
On 6/20/12 10:41 AM, Kelly O'Hair wrote:
You still have repeated patterns like:
131 ( set -e ; \
132
Looks good to me Dan!
Thanks,
David
On 21/06/2012 3:02 AM, Daniel D. Daugherty wrote:
On 6/20/12 10:44 AM, Daniel D. Daugherty wrote:
On 6/20/12 10:41 AM, Kelly O'Hair wrote:
You still have repeated patterns like:
131 ( set -e ; \
132 cd $(XLIBJVM_DIR) ; \
133 $(ADD_GNU_DEBUGLINK)
Changeset: 02c6c67c1bb7
Author:katleman
Date: 2012-06-14 13:13 -0700
URL: http://hg.openjdk.java.net/jdk8/build/rev/02c6c67c1bb7
Added tag jdk8-b43 for changeset 661c9aae602b
! .hgtags
Changeset: e4f81a817447
Author:katleman
Date: 2012-06-20 15:22 -0700
URL:
Changeset: 439d9bf8e4ff
Author:katleman
Date: 2012-06-14 13:14 -0700
URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/439d9bf8e4ff
Added tag jdk8-b43 for changeset cd879aff5d3c
! .hgtags
Changeset: b38fb5f31e31
Author:katleman
Date: 2012-06-14 13:14 -0700
URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b38fb5f31e31
Added tag jdk8-b43 for changeset e77b8e0ed1f8
! .hgtags
Changeset: 6e2633440960
Author:amurillo
Date: 2012-06-01 15:30 -0700
URL:
Changeset: f6a417540ef1
Author:katleman
Date: 2012-06-14 13:14 -0700
URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/f6a417540ef1
Added tag jdk8-b43 for changeset f00c12994562
! .hgtags
Changeset: db471a7af031
Author:katleman
Date: 2012-06-14 13:14 -0700
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/db471a7af031
Added tag jdk8-b43 for changeset b3246687c369
! .hgtags
Changeset: 59cbead12ff4
Author:katleman
Date: 2012-06-14 13:14 -0700
URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/59cbead12ff4
Added tag jdk8-b43 for changeset f8c64d835b28
! .hgtags
I just cloned the complete TL JDK8 forest by cloning the top repo then
using get_source.sh to clone the other repos (open and closed).
At the top-level hgdefpath shows
/export/users/dh198349/jdk8 hg defpath
default = http://hg.openjdk.java.net/jdk8/tl/
default-push = None
I then went
15 matches
Mail list logo
