Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-14 Thread Omair Majid
On 08/14/2012 05:04 PM, Kumar Srinivasan wrote: > Hi Omair, > > Thumbs up!. please let me know when you actually push I will set the CR, > so that > the integrator does not get confused, and I don't get awt push > notifications. Pushed: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f003387c33ad >

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-14 Thread Naoto Sato
Thanks, Erik! I incorporated your build-infra changes into the main changeset, and created a new combined webrev as follows: http://cr.openjdk.java.net/~naoto/6336885/webrev.02/ Naoto On 8/13/12 11:40 PM, Erik Joelsson wrote: I finished making the changes yesterday, but didn't manage to get

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-14 Thread Kumar Srinivasan
Hi Omair, Thumbs up!. please let me know when you actually push I will set the CR, so that the integrator does not get confused, and I don't get awt push notifications. And once again thanks for doing this... Kumar On 08/14/2012 07:13 AM, Kumar Srinivasan wrote: I see your point. As I tol

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-14 Thread Naoto Sato
Hi David, We are planning to push the changes through T/L repos. Although I think it's unlikely that our changes and JSR 292 ones would interfere, it would be good to push them in a later promotion build. I will shoot for the next one after the "flag day." Naoto On 8/13/12 11:57 PM, David H

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-14 Thread Omair Majid
On 08/14/2012 07:13 AM, Kumar Srinivasan wrote: > >> I see your point. As I told you we'll be open-sourcing a JAWT-specific >> test under 7190587. This test already provides support for Linux, >> Solaris, and Windows platforms, and even does a little more than just >> loads the jawt library. Awes

Re: webrev failure?

2012-08-14 Thread Martijn Verburg
Hi Mark, > On Sun, Aug 12, 2012 at 12:39:57PM +0100, Martijn Verburg wrote: >> Aha! :-). Any ideas on how far I need to downgrade the version of hg? >> (I'm 2.3 at the moment). > > I am at 2.2.3. The hgforest extension as maintained at > http://icedtea.classpath.org/hg/hgforest > (which is a merg

Re: webrev failure?

2012-08-14 Thread Martijn Verburg
Hi Chris, > Martin, > > Unless you have changes that span multiple repositories, then it can be > quite straight forward to run webrev ( without '-f ) on just the individual > repository that you are changing. It will run with simply 'hg out'. That did seem to work, thanks. > If you have changes

Re: jdk8 makefile changes

2012-08-14 Thread Magnus Ihse Bursie
On 2012-07-10 16:23, Kumar Srinivasan wrote: It looks like autoconf has messed up. From the config.log HOSTCC='C:/PROGRA~1/MSVS10/VC/BIN/cl.exe' HOSTCXX='C:/PROGRA~1/MSVS10/VC/BIN/cl.exe' HOSTLD='C:/devtools/cygwin/bin/link.exe' It has picked cl.exe correctly, oopsie on link.exe. You have

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-14 Thread Andrew Hughes
- Original Message - > > > - Original Message - > >> I have pointed out some changes below, but there is a serious > >> problem. > >> You are checking for the system arch using uname but the > >> java architecture may not be the same. > >> > >> For example we run 32-bit jdk on a 6

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-14 Thread Kumar Srinivasan
- Original Message - I have pointed out some changes below, but there is a serious problem. You are checking for the system arch using uname but the java architecture may not be the same. For example we run 32-bit jdk on a 64bit system, this will cause test failures since we will be u

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-14 Thread Kumar Srinivasan
I see your point. As I told you we'll be open-sourcing a JAWT-specific test under 7190587. This test already provides support for Linux, Solaris, and Windows platforms, and even does a little more than just loads the jawt library. So it looks there's still some value in Kumar's test as well.

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-14 Thread Andrew Hughes
- Original Message - > Hello, > > Please review the JDK8 changes for JEP 127: Improve Locale Data > Packaging and Adopt Unicode CLDR Data > (http://openjdk.java.net/jeps/127). The webrev is located at: > > http://cr.openjdk.java.net/~naoto/6336885/webrev.00/ > > The main bug id for this

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-14 Thread Anthony Petrov
I see your point. As I told you we'll be open-sourcing a JAWT-specific test under 7190587. This test already provides support for Linux, Solaris, and Windows platforms, and even does a little more than just loads the jawt library. So it looks there's still some value in Kumar's test as well. Y

Re: [PATCH] Update RPATH to make loading libjawt possible

2012-08-14 Thread Andrew Hughes
- Original Message - > I have pointed out some changes below, but there is a serious > problem. > You are checking for the system arch using uname but the > java architecture may not be the same. > > For example we run 32-bit jdk on a 64bit system, this will cause test > failures > since

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-14 Thread Magnus Ihse Bursie
On 2012-08-14 09:24, Erik Joelsson wrote: And I'm done. http://cr.openjdk.java.net/~erikj/6336885/webrev.build-infra.00/ This is a patch on top of your latest webrev that I have verified to produce the same result on linux.

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-14 Thread Erik Joelsson
And I'm done. http://cr.openjdk.java.net/~erikj/6336885/webrev.build-infra.00/ This is a patch on top of your latest webrev that I have verified to produce the same result on linux. This part will need some more eyes from b