Re: Review request: Build infra update

2012-10-09 Thread David Holmes
On 9/10/2012 9:13 PM, Erik Joelsson wrote: On 2012-10-09 12:59, David Holmes wrote: On 9/10/2012 6:06 PM, Erik Joelsson wrote: Not exactly sure what you mean with the duplication other than the comment in the last rule being wrong. One rule is for copying from jdk/lib and the other from images/

Re: Review request: Build infra update

2012-10-09 Thread Erik Joelsson
On 2012-10-09 12:59, David Holmes wrote: On 9/10/2012 6:06 PM, Erik Joelsson wrote: Not exactly sure what you mean with the duplication other than the comment in the last rule being wrong. One rule is for copying from jdk/lib and the other from images/lib. Both sources contain files that are g

Re: Review request: Build infra update

2012-10-09 Thread David Holmes
On 9/10/2012 6:06 PM, Erik Joelsson wrote: Not exactly sure what you mean with the duplication other than the comment in the last rule being wrong. One rule is for copying from jdk/lib and the other from images/lib. Both sources contain files that are going into the image. I thought you were on

Re: Review request: Build infra update

2012-10-09 Thread Magnus Ihse Bursie
On 2012-10-08 17:09, Erik Joelsson wrote: After achieving the milestone of equivalent images from the new and old build, this is a good time to refresh build-infra in jdk8. Here is a webrev with the proposed changes: http://cr.openjdk.java.net/~erikj/build-infra5/webrev.01/

Re: Review request: Build infra update

2012-10-09 Thread Erik Joelsson
Oh and thanks for the review of course! /Erik On 2012-10-09 10:06, Erik Joelsson wrote: Not exactly sure what you mean with the duplication other than the comment in the last rule being wrong. One rule is for copying from jdk/lib and the other from images/lib. Both sources contain files that a

Re: Review request: Build infra update

2012-10-09 Thread Erik Joelsson
Not exactly sure what you mean with the duplication other than the comment in the last rule being wrong. One rule is for copying from jdk/lib and the other from images/lib. Both sources contain files that are going into the image. /Erik On 2012-10-09 04:10, David Holmes wrote: Hi Erik, In I