Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-10-31 Thread David Holmes
No takers so far - don't be shy, it's not a difficult one I promise :) Updated webrev: http://cr.openjdk.java.net/~dholmes/8002034/webrev.01/ Because of the multiple sub-make invocations that occur during a build the FDS logic gets processed numerous times, many of which are not needed and whi

Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

2012-10-31 Thread David Holmes
Hi Jon, On 1/11/2012 12:09 PM, Jonathan Gibbons wrote: David, For a long time now, the JDK 8 langtools repo has accepted -source 8 and -target 8, so this should not affect which version of langtools you need to use. Of course, you do need to make sure that these options are not used with the bo

hg: jdk8/build/langtools: 14 new changesets

2012-10-31 Thread david . katleman
Changeset: 16498acd21b5 Author:katleman Date: 2012-10-25 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/16498acd21b5 Added tag jdk8-b62 for changeset b47bb81ba962 ! .hgtags Changeset: c75be5bc5283 Author:jjg Date: 2012-10-09 19:10 -0700 URL: ht

hg: jdk8/build/jdk: 79 new changesets

2012-10-31 Thread david . katleman
Changeset: 65d2c6726487 Author:katleman Date: 2012-10-25 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/65d2c6726487 Added tag jdk8-b62 for changeset 50b8b17449d2 ! .hgtags Changeset: 117eed515e42 Author:bae Date: 2012-10-23 13:10 +0400 URL: http://h

Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

2012-10-31 Thread Jonathan Gibbons
David, For a long time now, the JDK 8 langtools repo has accepted -source 8 and -target 8, so this should not affect which version of langtools you need to use. Of course, you do need to make sure that these options are not used with the bootstrap javac, which will typically be from JDK 7. -

hg: jdk8/build/jaxws: 2 new changesets

2012-10-31 Thread david . katleman
Changeset: c27ea8d489e8 Author:katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/c27ea8d489e8 Added tag jdk8-b62 for changeset d265b9b4c0f5 ! .hgtags Changeset: 86989f702267 Author:katleman Date: 2012-10-31 18:30 -0700 URL: h

hg: jdk8/build/jaxp: 6 new changesets

2012-10-31 Thread david . katleman
Changeset: a96e34e038f5 Author:katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/a96e34e038f5 Added tag jdk8-b62 for changeset 5d0fa0108d02 ! .hgtags Changeset: 53a2a4893c8f Author:joehw Date: 2012-10-09 14:19 -0700 URL: http:

hg: jdk8/build/hotspot: 38 new changesets

2012-10-31 Thread david . katleman
Changeset: 556dd9e475c6 Author:katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/556dd9e475c6 Added tag jdk8-b62 for changeset dccd40de8db1 ! .hgtags Changeset: d0e7716b179e Author:amurillo Date: 2012-10-19 11:26 -0700 URL:

hg: jdk8/build: 6 new changesets

2012-10-31 Thread david . katleman
Changeset: 4e984be114bd Author:katleman Date: 2012-10-25 09:52 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/4e984be114bd Added tag jdk8-b62 for changeset 8a3fe0ae06a8 ! .hgtags Changeset: 4bde5640fb36 Author:alanb Date: 2012-10-09 13:25 +0100 URL: http://hg.

hg: jdk8/build/corba: 6 new changesets

2012-10-31 Thread david . katleman
Changeset: bbaef650c3d2 Author:katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/bbaef650c3d2 Added tag jdk8-b62 for changeset 08afb9c6f44f ! .hgtags Changeset: 679e8ad9874f Author:coffeys Date: 2012-10-09 20:14 +0100 URL: ht

Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

2012-10-31 Thread David Holmes
Hi Kumar, So after this jdk8 builds will have to use current langtools javac in order to work? The corresponding changes to the new build system will be needed as well. David On 1/11/2012 3:43 AM, Kumar Srinivasan wrote: Hello, Please review changes to rev up the default -source and -targe

Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

2012-10-31 Thread Chris Hegarty
Looks fine Kumar. -Chris On 31 Oct 2012, at 17:43, Kumar Srinivasan wrote: > Hello, > > Please review changes to rev up the default -source and -target for jdk > compilation, > thus producing v52.0 class files. > > Bug is here: > https://jbs.oracle.com/bugs/browse/JDK-8001191 > > Webrev is

Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

2012-10-31 Thread Kumar Srinivasan
Looks good. make/java/invoke/Makefile: I have had good success in the lambda repo with just removing the version directives from this file. They date from early days of 292 and are no longer relevant. The package compiles just fine using the global default now. Lets address this as separa

Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

2012-10-31 Thread Mike Duigou
Looks good. make/java/invoke/Makefile: I have had good success in the lambda repo with just removing the version directives from this file. They date from early days of 292 and are no longer relevant. The package compiles just fine using the global default now. On Oct 31 2012, at 10:43 , Kumar

Re: [8]Review request: 8001231 : Move locale data out of rt.jar (except the US locale)

2012-10-31 Thread Naoto Sato
Thank you for the review, Alan. On 10/31/12 3:06 AM, Alan Bateman wrote: I looked through the changes and they look fine to me, it's good to have this separation. Also good to see that you've also updated the makefiles for the new build system. If we were continuing with the old build system the

RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

2012-10-31 Thread Kumar Srinivasan
Hello, Please review changes to rev up the default -source and -target for jdk compilation, thus producing v52.0 class files. Bug is here: https://jbs.oracle.com/bugs/browse/JDK-8001191 Webrev is here: http://cr.openjdk.java.net/~ksrini/8001191/webrev.0/ Note: this webrev is generated agains

Re: [8]Review request: 8001231 : Move locale data out of rt.jar (except the US locale)

2012-10-31 Thread Erik Joelsson
I have looked through and compared the build output of old and new build. It looks good to me. /Erik On 2012-10-30 17:33, Naoto Sato wrote: Hello, I need someone to review my changes to the following bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001231 The fix is to move locale d

Re: [8]Review request: 8001231 : Move locale data out of rt.jar (except the US locale)

2012-10-31 Thread Alan Bateman
On 30/10/2012 16:33, Naoto Sato wrote: Hello, I need someone to review my changes to the following bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001231 The fix is to move locale data out of rt.jar into localedata.jar which will be optional in the compact profile (http://openjdk.ja

RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-10-31 Thread David Holmes
http://cr.openjdk.java.net/~dholmes/8002034/webrev/ This mainly addresses JDK-8002034 Allow Full Debug Symbols when cross-compiling The initial FDS work simply disables FDS when cross-compilation is involved. But we're now ready to deal with the cross-compilation case (and even if we weren't