Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

2012-11-02 Thread Kumar Srinivasan
Hi David, Kelly, Erik, as Kelly stated the jdk only build, uses the compiler from the import JDK, this works with -source 8 -target, which was prepped by Joe earlier. I also checked with a jdk only jprt build submission, which exposed another location that needed a bump. I have fixed the new in

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-02 Thread Dmitry Samersoff
David, Other projects e.g. linux kernel sets CROSS_COMPILE, to specify the prefix for all executables used during compilation. e.g. make CROSS_COMPILE=ia64-linux- will cause CC=ia64-linux-gcc OBJCOPY=ia64-linux-objcopy etc Could we adopt this convention? -Dmitry On 2012-11-02 06:39

Re: Request for Review: Add hotspot support for building with mingw/msys on build-infra (the new build)

2012-11-02 Thread Kelly O'Hair
On Nov 2, 2012, at 1:27 AM, Fredrik Öhrström wrote: > 2012-10-26 17:02, Kelly O'Hair skrev: >> I tend to disagree, having multiple words in CC is unconventional, and if we >> do that, we need to consider the consequences of straying from the typical >> make convention. But I'd rather not get in

Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

2012-11-02 Thread Kumar Srinivasan
Hello Erik, For the new build, the change is done in jdk/makefiles/Setup.gmk, in the macro call for GENERATE_JDKBYTECODE. Would be nice if that change went in the same changeset. Thanks for the tip. This change is only for the jdk repo. Don't we need to change the other repos (jaxp, jaxws

Re: Request for Review: Add hotspot support for building with mingw/msys on build-infra (the new build)

2012-11-02 Thread Fredrik Öhrström
2012-10-26 17:02, Kelly O'Hair skrev: I tend to disagree, having multiple words in CC is unconventional, and if we do that, we need to consider the consequences of straying from the typical make convention. But I'd rather not get into what is theoretically wrong or right, it just needs to work,