Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

Fredrik, On 2012-11-12 22:04, Kelly O'Hair wrote: > > Interesting. I guess I would have done something like: >if [ "`cat file | wc -w`" -ne 0 ] ; then check if we have words... > ;^) I'm for this variant, because it meaning is obvious. -Dmitry -- Dmitry Samersoff Oracle Java devel

Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

On Nov 12, 2012, at 9:32 AM, Fredrik Öhrström wrote: > 12 nov 2012 kl. 17:45 skrev Kelly O'Hair: > >> Looks ok. >> >> xargs used to prune whitespace? That was a new one on me. ;^) > > After reading through this one: > http://stackoverflow.com/questions/369758/how-to-trim-whitespace-from-bash-v

Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

12 nov 2012 kl. 17:45 skrev Kelly O'Hair: > Looks ok. > > xargs used to prune whitespace? That was a new one on me. ;^) After reading through this one: http://stackoverflow.com/questions/369758/how-to-trim-whitespace-from-bash-variable I can only say that it seemed like the easiest solution.

Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

Looks ok. xargs used to prune whitespace? That was a new one on me. ;^) -kto On Nov 12, 2012, at 5:34 AM, Erik Joelsson wrote: > Here is a collection of changes found by comparing build-infra with > jdk8/build that all relate to sjavac that will be needed when sjavac makes it > into jdk8/tl.

Re: Review Request: 8002026: build-infra: deploy repository building

Looks ok. -kto On Nov 12, 2012, at 6:44 AM, Erik Joelsson wrote: > This is the open part of this change. It only changes the compare script to > handle the deploy build artifacts. > > http://cr.openjdk.java.net/~erikj/8002026/webrev.root.01/ >

Re: Review Request: 8001965: build-infra: Large compare diffs between new and old on mac

Looks fine to me. -kto On Nov 12, 2012, at 5:50 AM, Erik Joelsson wrote: > The first part of the fix for this bug already went in with a bulk integ of > build-infra earlier. Here is a webrev for fixing the last problem. The wrong > icon source file was used when building closed: > > http://cr

Review Request: 8002026: build-infra: deploy repository building

This is the open part of this change. It only changes the compare script to handle the deploy build artifacts. http://cr.openjdk.java.net/~erikj/8002026/webrev.root.01/ /Erik

Review Request: 8001965: build-infra: Large compare diffs between new and old on mac

The first part of the fix for this bug already went in with a bulk integ of build-infra earlier. Here is a webrev for fixing the last problem. The wrong icon source file was used when building closed: http://cr.openjdk.java.net/~erikj/8001965/webrev.jdk.01/

Review Request: 8003274: build-infra: Makefile changes needed for sjavac

Here is a collection of changes found by comparing build-infra with jdk8/build that all relate to sjavac that will be needed when sjavac makes it into jdk8/tl. Fredrik is likely the author of all of them. http://cr.openjdk.java.net/~erikj/8003274/webrev.root.01/