Re: Review Request: 8003945: build-infra: problems finding compiler when using --with-dev-kit

2012-11-28 Thread Kelly O'Hair
I'm not crazy about the --with-dev-kit either. In the future I think we need to discuss when we want to add new --with-* options. -kto On Nov 28, 2012, at 12:36 AM, Fredrik Öhrström wrote: > I am not really fond of --with-dev-kit, but now its there. However the > --sysroot > compiler lookup no

Re: solaris builds and new infra.....

2012-11-28 Thread Kelly O'Hair
On Nov 28, 2012, at 12:27 PM, Alan Bateman wrote: > On 28/11/2012 19:45, Kumar Srinivasan wrote: >> Hi, >> >> Is it possible for the new infra, to produce a composite image of both >> server and >> client VMs on Solaris 32-bit > --with-jvm-variants=client,server --with-target-bits=32 > >> >>

Review Request: 8004131: move jdi tests out of core testset

2012-11-28 Thread Stuart Marks
Hi all, The JDI tests have proven to be fairly unstable and are causing a lot of spurious failures in our JPRT and nightly jobs. Instead of moving all the tests into the problem list, we've decided to move the 'jdk_jdi' test target out of the 'core' testset so they won't get run regularly unti

hg: jdk8/build/langtools: 21 new changesets

2012-11-28 Thread david . katleman
Changeset: b5d326a809a1 Author:katleman Date: 2012-11-15 15:40 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b5d326a809a1 Added tag jdk8-b65 for changeset 5f2faba89cac ! .hgtags Changeset: e6b1abdc11ca Author:rfield Date: 2012-11-13 08:06 -0800 URL:

hg: jdk8/build/jdk: 28 new changesets

2012-11-28 Thread david . katleman
Changeset: c87df8b1f55e Author:katleman Date: 2012-11-15 15:40 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c87df8b1f55e Added tag jdk8-b65 for changeset 130d3a54d28b ! .hgtags Changeset: 03d22c98b30a Author:ceisserer Date: 2012-11-13 16:12 -0800 URL: ht

hg: jdk8/build/jaxws: Added tag jdk8-b65 for changeset fbe54291c9d3

2012-11-28 Thread david . katleman
Changeset: 3eb7f11cb4e0 Author:katleman Date: 2012-11-15 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/3eb7f11cb4e0 Added tag jdk8-b65 for changeset fbe54291c9d3 ! .hgtags

hg: jdk8/build/jaxp: Added tag jdk8-b65 for changeset 5cf3c69a93d6

2012-11-28 Thread david . katleman
Changeset: e6af1ad464e3 Author:katleman Date: 2012-11-15 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/e6af1ad464e3 Added tag jdk8-b65 for changeset 5cf3c69a93d6 ! .hgtags

hg: jdk8/build/hotspot: 24 new changesets

2012-11-28 Thread david . katleman
Changeset: 4e3e685dbc9d Author:katleman Date: 2012-11-15 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4e3e685dbc9d Added tag jdk8-b65 for changeset 0f7290a03b24 ! .hgtags Changeset: 3be318ecfae5 Author:amurillo Date: 2012-11-09 08:36 -0800 URL:

hg: jdk8/build/corba: Added tag jdk8-b65 for changeset 5132f7900a8f

2012-11-28 Thread david . katleman
Changeset: 65771ad1ca55 Author:katleman Date: 2012-11-15 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/65771ad1ca55 Added tag jdk8-b65 for changeset 5132f7900a8f ! .hgtags

hg: jdk8/build: 2 new changesets

2012-11-28 Thread david . katleman
Changeset: 0e1b5886b06c Author:katleman Date: 2012-11-15 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/0e1b5886b06c Added tag jdk8-b65 for changeset b772de306dc2 ! .hgtags Changeset: 13bb8c326e7b Author:katleman Date: 2012-11-28 14:03 -0800 URL: http://

Re: solaris builds and new infra.....

2012-11-28 Thread Alan Bateman
On 28/11/2012 19:45, Kumar Srinivasan wrote: Hi, Is it possible for the new infra, to produce a composite image of both server and client VMs on Solaris 32-bit --with-jvm-variants=client,server --with-target-bits=32 For extra credits is it possible to build the 64 bit image as well and ha

Re: solaris builds and new infra.....

2012-11-28 Thread Kelly O'Hair
--with-jvm-variants=client,server No extra credit for me. ;^) -kto On Nov 28, 2012, at 11:45 AM, Kumar Srinivasan wrote: > Hi, > > Is it possible for the new infra, to produce a composite image of both server > and > client VMs on Solaris 32-bit > > For extra credits is it possible to build

solaris builds and new infra.....

2012-11-28 Thread Kumar Srinivasan
Hi, Is it possible for the new infra, to produce a composite image of both server and client VMs on Solaris 32-bit For extra credits is it possible to build the 64 bit image as well and have it merged into a composite image of 32-bit variants ? Thanks Kumar

hg: jdk8/build/langtools: 8003844: build-infra: docs target isn't working properly

2012-11-28 Thread erik . joelsson
Changeset: da48ab364ea4 Author:erikj Date: 2012-11-28 13:37 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/da48ab364ea4 8003844: build-infra: docs target isn't working properly Summary: Adding resources to bootstrap javadoc.jar. Adding missing .js resource suffix Re

hg: jdk8/build/jdk: 5 new changesets

2012-11-28 Thread erik . joelsson
Changeset: 44e845bb5f76 Author:erikj Date: 2012-11-28 09:47 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/44e845bb5f76 8003960: build-infra: Jarsigner launcher has wrong classname Summary: Fixed package name in launcher Reviewed-by: alanb, ohair, ohrstrom ! makefiles/Com

hg: jdk8/build: 3 new changesets

2012-11-28 Thread erik . joelsson
Changeset: f8b0bacd4de5 Author:erikj Date: 2012-11-28 13:15 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/f8b0bacd4de5 8001460: build-infra: Linker warnings on macosx Summary: Only linking against jvm variant specific dirs if they are expected to exist. Reviewed-by: ohair !

Re: Review Request: 8004104: build-infra: Minor cleanup

2012-11-28 Thread Fredrik Öhrström
Looks good! 2012/11/28 Erik Joelsson : > Here is a bit of cleanup. > > * A bunch of unnecessary excludes of java-files, since they are in the > platform specific parts of the source anyway. > * An LDFLAGS that should be posix only and was causing a link warning on > windows. > > http://cr.openjdk.

Review Request: 8004104: build-infra: Minor cleanup

2012-11-28 Thread Erik Joelsson
Here is a bit of cleanup. * A bunch of unnecessary excludes of java-files, since they are in the platform specific parts of the source anyway. * An LDFLAGS that should be posix only and was causing a link warning on windows. http://cr.openjdk.java.net/~erikj/8004104/webrev.jdk.01/ /Erik

Re: Review Request: 8003482: build-infra: Use correct manifest in security jars

2012-11-28 Thread Fredrik Öhrström
Ah, but make is smarter than that. Take for example this makefile: myprog.sh : echo "#!/bin/sh" > $@ sleep 3 echo "echo Hello World!" >> $@ echo >> $@ chmod a+x $@ If you press ctrl-c during the sleep, then make will remove the half baked myprog.sh and pri

Re: Review Request: 8003482: build-infra: Use correct manifest in security jars

2012-11-28 Thread Erik Joelsson
In this case it's rather to protect against unfortunately timed ctrl-c or other external interruptions. /Erik On 2012-11-28 09:26, Fredrik Öhrström wrote: Looks ok. However the practice of using [email protected] is unnecessary if there is no reasonable risk of failure in the recipe. //Fredrik 2012/11/

Re: Review Request: 8003300: build-infra: fails on solaris when objcopy is not found

2012-11-28 Thread Fredrik Öhrström
Looks good. 2012/11/19 Erik Joelsson : > This is a simple fix for when objcopy is missing. > > http://cr.openjdk.java.net/~erikj/8003300/webrev.root.01/ > > /Erik

Re: Review Request: 8003945: build-infra: problems finding compiler when using --with-dev-kit

2012-11-28 Thread Fredrik Öhrström
I am not really fond of --with-dev-kit, but now its there. However the --sysroot compiler lookup no longer works. Which causes the cross compiles started using --with-builddeps-server to fail.. //Fredrik 2012/11/27 Erik Joelsson : > This fix changes how configure looks for the compiler when -

Re: Review Request: 8004045: build-infra: Error 12 from zip when updating src.zip

2012-11-28 Thread Fredrik Öhrström
Looks good. 2012/11/27 Erik Joelsson : > Small fix for common annoyance when rebuilding images. The zip utility > returns 12 when it has nothing to do. This happens because we run it > multiple times, once for each source root, when updating src.zip, even if > only sources in one of the roots have

Re: Review Request: 8003528: build-infra: Diffs in libjava and hotspot libs on solaris.

2012-11-28 Thread Fredrik Öhrström
Looks good. 2012/11/26 Erik Joelsson : > This fixes a difference between old and new build in libjava.so. It also > adds more exceptions for unavoidable differences in libs from hotspot. > > This also fixes part of 8001460: build-infra: Linker warnings on macosx > > http://cr.openjdk.java.net/~eri

Re: Review Request: 8003844: build-infra: docs target isn't working properly

2012-11-28 Thread Fredrik Öhrström
Looks good! 2012/11/26 Erik Joelsson : > I have fixed the docs target and added support for comparing the generated > docs with the old build. > > http://cr.openjdk.java.net/~erikj/8003844/webrev.01/ > > /Erik

Re: Review Request: 8003477: build-infra: Remove explicit source file listings for libs when possible

2012-11-28 Thread Fredrik Öhrström
Great! 2012/11/26 Erik Joelsson : > This is a bit of a cleanup in CompileNativeLibraries.gmk, removing explicit > listings of source files when they aren't necessary. For some libraries, it > still makes sense to list files to include rather than exclude and those > still have include lists. > > h

Re: Review Request: 8003482: build-infra: Use correct manifest in security jars

2012-11-28 Thread Fredrik Öhrström
Looks ok. However the practice of using [email protected] is unnecessary if there is no reasonable risk of failure in the recipe. //Fredrik 2012/11/26 Erik Joelsson : > This patch converts 7197071 to the new build-system. > > http://cr.openjdk.java.net/~erikj/8003482/webrev.jdk.01/ > > /Erik