Re: Review Request: 8004131: move jdi tests out of core testset

2012-11-29 Thread Stuart Marks
Thanks guys, pushed into tl and tl/jdk. s'marks On 11/29/12 1:18 AM, Chris Hegarty wrote: Thanks Stuart, looks good. -Chris. On 11/29/2012 08:14 AM, Alan Bateman wrote: On 29/11/2012 02:08, Stuart Marks wrote: Hi all, The JDI tests have proven to be fairly unstable and are causing a lot of

Re: solaris builds and new infra.....

2012-11-29 Thread David Katleman
On 11/28/2012 8:01 PM, Kelly O'Hair wrote: On Nov 28, 2012, at 12:27 PM, Alan Bateman wrote: On 28/11/2012 19:45, Kumar Srinivasan wrote: Hi, Is it possible for the new infra, to produce a composite image of both server and client VMs on Solaris 32-bit --with-jvm-variants=client,server --

Re: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

2012-11-29 Thread Fredrik Öhrström
2012-11-29 15:36, Erik Joelsson skrev: I just submitted a patch to build-infra for the dual generation on all platforms since it breaks comparisons between old and new build. In general, we can't change behavior in new build without also changing the old before the old is removed. Removing si

Re: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

2012-11-29 Thread Fredrik Öhrström
2012-11-29 15:27, Fredrik Öhrström skrev: The GensrcX11Wrapper.gmk makefile creates a new sizes.32 or sizes.64 by running a generated C program that performs many sizeof calculations on X11 structures. This is cross compileable. That "not" was accidently dropped. Obviously this is NOT cross com

Re: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

2012-11-29 Thread Erik Joelsson
I just submitted a patch to build-infra for the dual generation on all platforms since it breaks comparisons between old and new build. In general, we can't change behavior in new build without also changing the old before the old is removed. Removing sizes.64-solaris-i386 breaks the old build

Re: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

2012-11-29 Thread Anthony Petrov
CC'ing awt-dev@, Yuri, and Artem. -- best regards, Anthony On 11/29/12 18:27, Fredrik Öhrström wrote: The GensrcX11Wrapper.gmk makefile creates a new sizes.32 or sizes.64 by running a generated C program that performs many sizeof calculations on X11 structures. This is cross compileable. Fortu

Re: Review Request: JDK-8004145: build-infra: hgforest.sh cannot be interrupted safely.

2012-11-29 Thread David Chase
Would it make sense to use "$@" instead of $* in the argument expansion? This occurs in get_source.sh, also in the new hgforest.sh. The use of "$@" I believe preserves the command line argument parsing: Assume this is script "asdf": #!/bin/bash echo quote-dollar-at-quote for i in "$@" ; do ech

Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

2012-11-29 Thread Fredrik Öhrström
The GensrcX11Wrapper.gmk makefile creates a new sizes.32 or sizes.64 by running a generated C program that performs many sizeof calculations on X11 structures. This is cross compileable. Fortunately the sizes.32 and sizes.64 offset files are very stable. Thus we can commit them to the source c

Review Request: JDK-8004145: build-infra: hgforest.sh cannot be interrupted safely.

2012-11-29 Thread Fredrik Öhrström
This patch makes sure that pressing ctrl-c when running "sh get_source.sh" actually sends a nice TERM signal to the background mercurial processes so that they can do a nice rollback, if they need to. Really useful, when that clone has stalled, because your network is down, and you want to stop

Re: Review Request: 8004131: move jdi tests out of core testset

2012-11-29 Thread Chris Hegarty
Thanks Stuart, looks good. -Chris. On 11/29/2012 08:14 AM, Alan Bateman wrote: On 29/11/2012 02:08, Stuart Marks wrote: Hi all, The JDI tests have proven to be fairly unstable and are causing a lot of spurious failures in our JPRT and nightly jobs. Instead of moving all the tests into the pro

Re: solaris builds and new infra.....

2012-11-29 Thread Alan Bateman
On 29/11/2012 04:01, Kelly O'Hair wrote: On Nov 28, 2012, at 12:27 PM, Alan Bateman wrote: : I don't know about that, but the "overlay-images" will create the 64-bit overlay that we are used to. Personally I think we should get rid of the overlay have have separate 32-bit and 64-bit images li

Re: Review Request: 8003945: build-infra: problems finding compiler when using --with-dev-kit

2012-11-29 Thread Erik Joelsson
Is this change breaking --with-sysroot or was it already broken? /Erik On 2012-11-28 09:36, Fredrik Öhrström wrote: I am not really fond of --with-dev-kit, but now its there. However the --sysroot compiler lookup no longer works. Which causes the cross compiles started using --with-builddeps-se

Re: Review Request: 8004131: move jdi tests out of core testset

2012-11-29 Thread Alan Bateman
On 29/11/2012 02:08, Stuart Marks wrote: Hi all, The JDI tests have proven to be fairly unstable and are causing a lot of spurious failures in our JPRT and nightly jobs. Instead of moving all the tests into the problem list, we've decided to move the 'jdk_jdi' test target out of the 'core' te