Re: solaris builds and new infra.....

2012-11-30 Thread Alan Bateman
On 30/11/2012 17:05, Kelly O'Hair wrote: : The overlay image has been one of these special cases that I would like to avoid, but at the same time, building two rt.jar files for the 32bit and 64bit images seems pretty silly too. So for the sake of simplicity, I'm willing to take the "build two r

Re: Review Request: 8003819: build-infra: backslashes at end of LIB and INCLUDE in spec.gmk

2012-11-30 Thread Kelly O'Hair
Looks good. -kto On Nov 30, 2012, at 4:40 AM, Erik Joelsson wrote: > This fixes a problem where the LIB and INCLUDE variables end up with a \ at > the end in spec.gmk. These variables are set in vcvars.bat and configure > extracts them to spec.gmk. Normally they do not end with a backslash, bu

Re: solaris builds and new infra.....

2012-11-30 Thread Kelly O'Hair
On Nov 29, 2012, at 1:13 AM, Alan Bateman wrote: > On 29/11/2012 04:01, Kelly O'Hair wrote: >> On Nov 28, 2012, at 12:27 PM, Alan Bateman wrote: >> >>> : >>> I don't know about that, but the "overlay-images" will create the 64-bit >>> overlay that we are used to. Personally I think we should ge

Re: Review Request: 8003414: build-infra: fails on on windows

2012-11-30 Thread Fredrik Öhrström
Looks good. 2012/11/30 Erik Joelsson : > This patch adds an extra check for validating that the windows sdk found by > configure is actually valid. > > http://cr.openjdk.java.net/~erikj/8003414/webrev.01/ > > /Erik

Re: Review Request: 8003819: build-infra: backslashes at end of LIB and INCLUDE in spec.gmk

2012-11-30 Thread Fredrik Öhrström
Looks good. 2012/11/30 Erik Joelsson : > This fixes a problem where the LIB and INCLUDE variables end up with a \ at > the end in spec.gmk. These variables are set in vcvars.bat and configure > extracts them to spec.gmk. Normally they do not end with a backslash, but if > these variables are alrea

Review Request: 8003819: build-infra: backslashes at end of LIB and INCLUDE in spec.gmk

2012-11-30 Thread Erik Joelsson
This fixes a problem where the LIB and INCLUDE variables end up with a \ at the end in spec.gmk. These variables are set in vcvars.bat and configure extracts them to spec.gmk. Normally they do not end with a backslash, but if these variables are already set before running configure, they might.

Review Request: 8003414: build-infra: fails on on windows

2012-11-30 Thread Erik Joelsson
This patch adds an extra check for validating that the windows sdk found by configure is actually valid. http://cr.openjdk.java.net/~erikj/8003414/webrev.01/ /Erik

Re: solaris builds and new infra.....

2012-11-30 Thread Dmitry Samersoff
Kelly, > Or do the extra credit and just build a merged 32+64 image by default. I'm second to it. -Dmitry On 2012-11-29 08:01, Kelly O'Hair wrote: > > On Nov 28, 2012, at 12:27 PM, Alan Bateman wrote: > >> On 28/11/2012 19:45, Kumar Srinivasan wrote: >>> Hi, >>> >>> Is it possible for the new