On Tue, Dec 4, 2012 at 4:37 PM, David Holmes wrote:
> /java/embedded/users/dh198349/**profiles/builds/b66/se-linux-**
> i586-ea/jdk/classes/java/lang/**Integer.class: major version 52 is newer
> than 51, the highest major version supported by this compiler.
>
Consider (just for jdk development pu
Looks ok.
-kto
On Dec 7, 2012, at 12:28 AM, Erik Joelsson wrote:
> Reminder to review this, please.
>
> /Erik
>
> On 2012-11-27 16:01, Erik Joelsson wrote:
>> Small fix for common annoyance when rebuilding images. The zip utility
>> returns 12 when it has nothing to do. This happens because w
I also see the same message while building OpenJDK on Mac 10.7.5. I
specified
7u9 as my boot JDK while running configure. I then ran 'make
NEWBUILD=true all' to build.
I made sure that there is no other JDK installed on the machine.
Does anyone know the reason (and consequently a fix) for thi
Looks good to me.
Tim
On 12/07/12 00:28, Erik Joelsson wrote:
Reminder to review this, please.
/Erik
On 2012-11-27 16:01, Erik Joelsson wrote:
Small fix for common annoyance when rebuilding images. The zip
utility returns 12 when it has nothing to do. This happens because we
run it multiple
Looks ok to me. Thanks.
-kto
On Dec 7, 2012, at 2:39 AM, Weijun Wang wrote:
> The native JGSS provider on Mac is not ready yet. Disable the native lib
> creation. Please review the code changes at
>
> http://cr.openjdk.java.net/~weijun/8004235/webrev.00/
>
> *build-dev*: I don't know how t
Thank you, Okutsu-san. It looks good to me now.
Naoto
On 12/7/12 8:05 AM, Masayoshi Okutsu wrote:
Thank you for your review comments.
On 12/7/2012 5:49 AM, Naoto Sato wrote:
Here are my comments:
- Bundle.java
Line 277,297: Do we need two separate iteration loops here? Two
iteration loops l
Thank you for your review. I thought so too, but I followed the rule for
make/* changes.
Masayoshi
On 12/6/2012 8:36 PM, Erik Joelsson wrote:
(resending to all recepients)
I don't see any changes to the build except for java classes in the
cldrconverter build tool. This shouldn't affect the
Thank you for your review comments.
On 12/7/2012 5:49 AM, Naoto Sato wrote:
Here are my comments:
- Bundle.java
Line 277,297: Do we need two separate iteration loops here? Two
iteration loops look like the same.
These loops need to be separated to make inheritance work correctly.
Line 303
FWIW looks okay to me.
David
On 7/12/2012 6:28 PM, Erik Joelsson wrote:
Reminder to review this, please.
/Erik
On 2012-11-27 16:01, Erik Joelsson wrote:
Small fix for common annoyance when rebuilding images. The zip utility
returns 12 when it has nothing to do. This happens because we run it
From a build point of view, this looks ok.
I don't know of an easy way to write 2 ifneqs on the same line either.
The way you did it is at least readable and as far as I know the common
way of doing it in make.
/Erik
On 2012-12-07 11:39, Weijun Wang wrote:
The native JGSS provider on Mac is
The native JGSS provider on Mac is not ready yet. Disable the native lib
creation. Please review the code changes at
http://cr.openjdk.java.net/~weijun/8004235/webrev.00/
*build-dev*: I don't know how to write 2 ifneq on a single line.
Thanks
Max
(resending to full recepients list)
I just hit another issue. I tried using a jdk8 boot-jdk and the order of
the output was different in the generated sizes file compared to the one
in the repo. Sorting both resulted in a clean diff.
/Erik
On 2012-12-05 14:20, Fredrik Öhrström wrote:
2012-1
Reminder to review this, please.
/Erik
On 2012-11-27 16:01, Erik Joelsson wrote:
Small fix for common annoyance when rebuilding images. The zip utility
returns 12 when it has nothing to do. This happens because we run it
multiple times, once for each source root, when updating src.zip, even
i
13 matches
Mail list logo
