Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-12 Thread David Holmes
On 13/12/2012 1:10 PM, Jonathan Gibbons wrote: On 12/12/2012 06:58 PM, David Holmes wrote: However in this case we were not invoking the javac launcher but the java launcher with the javac jar file. In that context does "javac" still accept -Xbootclasspath, or is that only accepted by the javac

Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-12 Thread Jonathan Gibbons
On 12/12/2012 06:58 PM, David Holmes wrote: However in this case we were not invoking the javac launcher but the java launcher with the javac jar file. In that context does "javac" still accept -Xbootclasspath, or is that only accepted by the javac launcher? The javac launcher is equivale

Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-12 Thread Jonathan Gibbons
On 12/12/2012 06:58 PM, David Holmes wrote: I stand half corrected. The java launcher only accepts -Xbootclasspath while the javac launcher will accept both (though I believe they have different meanings). In javac, -bootclasspath and -Xbootclasspath are aliases, so they are exactly equiva

Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-12 Thread David Holmes
On 13/12/2012 2:35 AM, Jonathan Gibbons wrote: On 12/12/2012 08:27 AM, Kelly Ohair wrote: >On 2012-12-12 02:56, David Holmes wrote: >>Note that we went from -Xbootclasspath to just -bootclasspath. The former is a VM option and the latter a javac option. >> Huh? -Xbootclasspath and -bootclassp

hg: jdk8/build/langtools: 13 new changesets

2012-12-12 Thread david . katleman
Changeset: e9a13a6c9d5d Author:katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e9a13a6c9d5d Added tag jdk8-b67 for changeset 303b09787a69 ! .hgtags Changeset: d9fe1f80515d Author:vromero Date: 2012-11-21 18:40 + URL:

hg: jdk8/build/jdk: 67 new changesets

2012-12-12 Thread david . katleman
Changeset: ea0d3a9d0d01 Author:katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ea0d3a9d0d01 Added tag jdk8-b67 for changeset ce9b02a3a17e ! .hgtags Changeset: 39f9b2cc5738 Author:bae Date: 2012-11-28 12:28 +0400 URL: http://h

hg: jdk8/build/jaxws: Added tag jdk8-b67 for changeset eb06aa51dfc2

2012-12-12 Thread david . katleman
Changeset: d3fe408f3a9a Author:katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/d3fe408f3a9a Added tag jdk8-b67 for changeset eb06aa51dfc2 ! .hgtags

hg: jdk8/build/jaxp: Added tag jdk8-b67 for changeset 83df3493ca3c

2012-12-12 Thread david . katleman
Changeset: b854e7008421 Author:katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/b854e7008421 Added tag jdk8-b67 for changeset 83df3493ca3c ! .hgtags

hg: jdk8/build/hotspot: 22 new changesets

2012-12-12 Thread david . katleman
Changeset: 10587a580c51 Author:katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/10587a580c51 Added tag jdk8-b67 for changeset 25bdce771bb3 ! .hgtags Changeset: 816b7e5bf2ed Author:amurillo Date: 2012-11-30 17:00 -0800 URL:

hg: jdk8/build/corba: Added tag jdk8-b67 for changeset 394515ad2a55

2012-12-12 Thread david . katleman
Changeset: 82000531feaa Author:katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/82000531feaa Added tag jdk8-b67 for changeset 394515ad2a55 ! .hgtags

hg: jdk8/build: 5 new changesets

2012-12-12 Thread david . katleman
Changeset: c91c581321ce Author:katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/c91c581321ce Added tag jdk8-b67 for changeset 9a6ec97ec45c ! .hgtags Changeset: ab1ab9b148dd Author:smarks Date: 2012-11-28 17:31 -0800 URL: http://hg

Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-12 Thread Jonathan Gibbons
On 12/12/2012 08:27 AM, Kelly Ohair wrote: >On 2012-12-12 02:56, David Holmes wrote: >>Note that we went from -Xbootclasspath to just -bootclasspath. The former is a VM option and the latter a javac option. >> Huh? -Xbootclasspath and -bootclasspth are both JVM and javac options. -- Jon

Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-12 Thread Kelly Ohair
bs_javac_args in upper case :) just having _args at the end is fine with me Sent from my iPhone On Dec 12, 2012, at 0:39, Erik Joelsson wrote: > What would be a good name for the variable? It's currently setup in > jdk/makefiles/Setup.gmk as: > > JAVAC_JARS ?= > "-Xbootclasspath/p:$(LANGTOO

Re: Code review: 8004904: Makefile for ntlm (was Re: com/sun/security/ntlm)

2012-12-12 Thread Chris Hegarty
Thank you Max, looks fine to me. -Chris. On 12/12/2012 03:32, Weijun Wang wrote: Hi Chris/Mark I've added a makefile, please take a look http://cr.openjdk.java.net/~weijun/8004904/webrev.00/ *build-dev* guys, I guess this won't affect the new build style. Thanks Max On 12/12/2012 09:28 AM

Re: Code review: 8004904: Makefile for ntlm (was Re: com/sun/security/ntlm)

2012-12-12 Thread Erik Joelsson
That is correct, the new build will already handle incremental building of any changed java file, so this won't make a difference. Thanks for the heads up anyway! /Erik On 2012-12-12 04:32, Weijun Wang wrote: Hi Chris/Mark I've added a makefile, please take a look http://cr.openjdk.java.

Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-12 Thread Erik Joelsson
What would be a good name for the variable? It's currently setup in jdk/makefiles/Setup.gmk as: JAVAC_JARS ?= "-Xbootclasspath/p:$(LANGTOOLS_OUTPUTDIR)/dist/bootstrap/lib/javac.jar" -jar $(LANGTOOLS_OUTPUTDIR)/dist/bootstrap/lib/javac.jar So these are the arguments needed to run the bootstra