On 02/06/2013 07:17 PM, Jonathan Gibbons wrote:
common/makefiles/JavaCompilation.gmk
line 162
dechipher.
-- Jon
line 518
buliding
common/makefiles/JavaCompilation.gmk
line 162
dechipher.
-- Jon
On 6 Feb 2013, at 16:26, [email protected] wrote:
> On Feb 6, 10:04am, [email protected] (Chris Hegarty) wrote:
> -- Subject: Re: RFR: race with nested repos in hgforest.sh
>
> | Yes this is better, but the quotes are incorrect. It should simply be
> |for rc in ${tmp}/*.pid.rc ; do
Neil,
I think a wider discussion needs to be had around how this script should
operate, but I didn't want this specific issue to get side tracked by that.
The hgforest script already clones/pulls in parallel, the problem here
is that it just doesn't work with older versions of hg. And worse t
fwiw, I've always found the attempts by hg_forest to process things in
parallel cause me more pain than it's worth.
Marching through the repo locations serially in order might take a few
moments longer elapsed time, but creates instantly understandable
status / output / log and points for returnin
On 06/02/2013 10:24, David Holmes wrote:
Thanks Chris. I missed a couple of obvious things there. :(
One thing related to the repo name in the $(rc) variable. Somewhere the
repo name gets mangled:
+ echo jdk/src/closed
+ sed -e s@./@@ -e s@/@_@g
+ repopidfile=jdsrc_closed
the / to _ doesn't
Thanks Chris. I missed a couple of obvious things there. :(
One thing related to the repo name in the $(rc) variable. Somewhere the
repo name gets mangled:
+ echo jdk/src/closed
+ sed -e s@./@@ -e s@/@_@g
+ repopidfile=jdsrc_closed
the / to _ doesn't work for the first / (not part of your fi
Thank for the review. comments inline...
On 06/02/2013 01:53, David Holmes wrote:
204 # Terminate with exit 0 only if all subprocesses were successful
205 ec=0
206 if [ -d ${tmp} ]; then
207 for rc in `ls ${tmp}/*.pid.rc` ; do
I don't think you need to subshell an invocation of ls, simply do
f
