Re: Allow using a system-installed giflib

2013-03-08 Thread Erik Joelsson
On 2013-03-08 03:59, Omair Majid wrote: Hi, I have a webrev at: http://cr.openjdk.java.net/~omajid/webrevs/system-giflib/00/ It introduces a configure option --with-giflib that (similar to the existing --with-zlib) allows specifying whether the build should use the system installed giflib or

Re: How to override which autoconf is used?

2013-03-08 Thread Erik Joelsson
Could it be that bash is somehow resetting your path when you launch it? /Erik On 2013-03-08 06:06, David Holmes wrote: My build machine has autoconf 2.68 in /usr/bin but others use 2.67. This means we keep getting differences in generated-configure.sh that are not related to actual changes.

Re: RFR: 8009428 and 8009429 - Profile related fixes and clean ups

2013-03-08 Thread David Holmes
Thanks Erik! David On 8/03/2013 9:25 PM, Erik Joelsson wrote: On 2013-03-08 10:19, Alan Bateman wrote: On 08/03/2013 01:48, David Holmes wrote: Not sure which is best list for this given Alan will likely be the only reviewer anyway :) Webrevs under:

Re: RFR 8009517: Disable fatal compiler warning in the old build

2013-03-08 Thread Mike Duigou
Looks fine to me. Do we have an issue open for restoring warnings to the new build? Mike On Mar 8 2013, at 05:24 , Chris Hegarty wrote: Since the new build does not enable -Werror when compiling any java code, and disables quite a few lint options, new changes my inadvertently introduce

Re: RFR 8009517: Disable fatal compiler warning in the old build

2013-03-08 Thread Dan Xu
On 03/08/2013 08:40 AM, Jonathan Gibbons wrote: On 03/08/2013 08:09 AM, Mike Duigou wrote: On Mar 8 2013, at 07:56 , Alan Bateman wrote: On 08/03/2013 15:49, Mike Duigou wrote: Looks fine to me. Do we have an issue open for restoring warnings to the new build? Mike I don't know if there

Re: Allow using a system-installed giflib

2013-03-08 Thread Phil Race
If I understand correctly, this removes the directory containing the JDK's copy of giflib sources from the set of locations to be compiled etc, and replaces it with just a link line pointer to use libgif which is then expected to be on the default linker path, ie in /usr/lib. I think this is

Re: RFR 8009517: Disable fatal compiler warning in the old build

2013-03-08 Thread Brad Wetmore
I responded in another thread (wasn't aware of this one, sorry), there is an alternate to completely disabling -Werror. On 3/8/2013 7:58 AM, Chris Hegarty wrote: On 08/03/2013 15:49, Mike Duigou wrote: Looks fine to me. Thanks Mike. Do we have an issue open for restoring warnings to

Re: Allow using a system-installed giflib

2013-03-08 Thread Omair Majid
On 03/08/2013 12:26 PM, Phil Race wrote: If I understand correctly, this removes the directory containing the JDK's copy of giflib sources from the set of locations to be compiled etc, and replaces it with just a link line pointer to use libgif which is then expected to be on the default