Re: RFR: 8009426 profiles target fails due to nashorn if images is not built first

2013-03-19 Thread Alan Bateman
On 18/03/2013 19:59, David Holmes wrote: Very simple fix/cleanup. webrev: http://cr.openjdk.java.net/~dholmes/8009426/webrev/ nashorn.jar was being added to the set of JARS targets regardless of what was being built, but nashorn is not a dependency for profiles target. JARS is not used the

Re: RFR: 8009426 profiles target fails due to nashorn if images is not built first

2013-03-19 Thread David Holmes
Hi Alan, On 19/03/2013 5:44 PM, Alan Bateman wrote: On 18/03/2013 19:59, David Holmes wrote: Very simple fix/cleanup. webrev: http://cr.openjdk.java.net/~dholmes/8009426/webrev/ nashorn.jar was being added to the set of JARS targets regardless of what was being built, but nashorn is not a

Re: Fix x11 header check

2013-03-19 Thread Erik Joelsson
On 2013-03-18 21:39, Omair Majid wrote: On 03/15/2013 03:55 PM, Omair Majid wrote: In file included from /builddir/build/BUILD/java-1.8.0-openjdk/jdk8/build/jdk8.build/jdk/gensrc_x11wrappers/sizer.64.c:11:0:

Re: RFR 8009517: Disable fatal compiler warning in the old build

2013-03-19 Thread Chris Hegarty
Brad, I do not build using the old build anymore. This is clearly a blocker for your work. If you want to suppress the warnings for overrides/deprecation, then please push the change ( your patch ). We can revisit this in the future, when it is necessary. -Chris. On 03/19/2013 01:29 AM,

Re: RFR: 8006818: SunEC and SunPKCS11 providers should be in all profiles

2013-03-19 Thread Alan Bateman
On 19/03/2013 16:19, Jen Dority wrote: Please review http://cr.openjdk.java.net/~dholmes/8006818/webrev/. This resolves JDK-8006818 which calls for adding the SunEC and SunPKCS11 providers to the compact* profiles. Thanks, Jen This looks okay to me although the SunPKCS11 provider isn't