Re: RFR: 8011350 : hgforesth.sh fails if sh is not bash

On Apr 3 2013, at 21:17 , David Holmes wrote: > On 4/04/2013 11:45 AM, Tim Bell wrote: >> Looks good to me, Mike >> >> Thanks - a seemingly simple change inflated into a small project when >> tested on multiple O/S platforms. > > Indeed. A main take away from this exercise is that any changes t

Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds

Andrew, My sincerest apologies. As long as pushes are to jdk8/build then there is indeed scope for deferring broad testing until after the push - any failures will only affect users of the jdk8/build and a fix will likely swiftly occur. In any case that is for the build folk to concern themse

Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds

Hi Andrew, We live/work in an imperfect world. The shortcomings you outline below are well known and steps are being taken to address at least some of them. That has taken time and will continue to take time - there is nothing I can do about that - sorry. I too would love to see an automatic

Re: RFR: JDK-8011812: JDK-8011278 breaks the old build

All- I think we need to pull back one click on the diff tool, because these changes being reviewed are missing the enclosing ifeq ($(PLATFORM), macosx) ... endif This was an existing bug, but it is material to the issue at hand. This needs a fresh look and some refactoring. Here is the

Re: Review request: 2223156 Removal of lzma and upx from JDK7u repo

Thank you Tim! Any other comments before I commit? Thanks Dave On 4/10/2013 1:51 PM, Tim Bell wrote: On 04/09/13 18:45, David Katleman wrote: Please review this change, removal of lzma and upx from the open repos of JDK7u http://cr.openjdk.java.net/~katleman/2223156/webrev.r

Re: RFR: JDK-8011812: JDK-8011278 breaks the old build

Erik, Wait, this doesn't work on Windows. I think you need to add this to the Windows case also. See my patch below. [brwetmor@glisten] 208 >hg diff Makefile diff --git a/make/sun/splashscreen/Makefile b/make/sun/splashscreen/Makefile --- a/make/sun/splashscreen/Makefile +++ b/make/sun/splas

Re: Review request: 2223156 Removal of lzma and upx from JDK7u repo

On 04/09/13 18:45, David Katleman wrote: Please review this change, removal of lzma and upx from the open repos of JDK7u http://cr.openjdk.java.net/~katleman/2223156/webrev.root.03/ http://cr.openjdk.java.net/~katleman/2223156/webrev.jdk.03/ Code/Makefile deletion - looks fine. Appr

Re: RFR: JDK-8011812: JDK-8011278 breaks the old build

Looks good to me. Can you, or I, push this to TL? We need this for a putback I'm planning in the next day or two. Brad On 4/10/2013 3:07 AM, Erik Joelsson wrote: http://cr.openjdk.java.net/~erikj/8011812/webrev.jdk.01/ I modified the patch a bit, also adding the include for macosx and chan

Re: Allow using a system-installed giflib

On 4/10/2013 1:19 AM, Alan Bateman wrote: On 09/04/2013 23:11, Omair Majid wrote: : I would like to avoid this in the future; any tips on how to run the old build? I couldn't get it to work last I tried (the error messages were redirecting me to the new build). I see Brad's reply but I think

Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds

- Original Message - > On 9/04/2013 11:06 AM, Martin Buchholz wrote: > > On Mon, Apr 8, 2013 at 5:51 PM, David Holmes > > wrote: > > > > On 9/04/2013 2:59 AM, Andrew Hughes wrote: > > > > Well, if I push it, it will be, no? > > > > Testing co

Re: RFR: JDK-8011687: Support correct dependencies from header files on windows and solaris

On 2013-04-09 20:38, Tim Bell wrote: Erik: This patch adds workarounds for the way make dependencies are generated in the Solaris and Windows compilers. What this means is that if you touch a header file, the relevant c files will be recompiled as expected. On Solaris, there is support fo

RFR: JDK-8011812: JDK-8011278 breaks the old build

http://cr.openjdk.java.net/~erikj/8011812/webrev.jdk.01/ I modified the patch a bit, also adding the include for macosx and changed to the SHARED_SRC variable used in the old build. /Erik On 2013-04-10 00:01, Brad Wetmore wrote: Mike/Omair/Eric, This putback has likely broken the old JDK bu

Re: Allow using a system-installed giflib

On 09/04/2013 23:11, Omair Majid wrote: : I would like to avoid this in the future; any tips on how to run the old build? I couldn't get it to work last I tried (the error messages were redirecting me to the new build). I see Brad's reply but I think what you are looking for is actually: make N