Re: RFR :8014269: (XXS) Add missing .PHONY targets to Main.gmk

Hi Mike: Small issue for review. Some of the Main.gmk targets aren't mentioned in the PHONY targets as they should be. http://cr.openjdk.java.net/~mduigou/JDK-8014269/0/webrev/ Looks good. Tim

Re: RFR :8014269: (XXS) Add missing .PHONY targets to Main.gmk

Looks good. Mandy On 5/8/2013 9:00 PM, Mike Duigou wrote: Hello all; Small issue for review. Some of the Main.gmk targets aren't mentioned in the PHONY targets as they should be. http://cr.openjdk.java.net/~mduigou/JDK-8014269/0/webrev/ Mike

RFR :8014269: (XXS) Add missing .PHONY targets to Main.gmk

Hello all; Small issue for review. Some of the Main.gmk targets aren't mentioned in the PHONY targets as they should be. http://cr.openjdk.java.net/~mduigou/JDK-8014269/0/webrev/ Mike

Re: 8011346: build-infra: While Constructing Javadoc information, JSpinner.java error: package sun.util.locale.provider does not exist

- Original Message - > This patch removes the annoying Error output from javadoc during source > generation. > > http://cr.openjdk.java.net/~erikj/8011346/webrev.jdk.01/ > > /Erik > Looks good to me too. Will be good to see this error fixed. -- Andrew :) Free Java Software Engineer R

Re: Review Request : CR8014129

On 5/7/13 11:10 PM, Amy Wang wrote: > Hi, All, > > Please help review the following changes: > > CR8014129 : > makefile changes to allow integration of new features > Looks OK. CC:ing build-dev for a second review from there, and Alej