Re: RFR: 8010785: JDK 8 build on Linux fails with new build mechanism

2013-06-06 Thread David Holmes
On 4/06/2013 10:38 PM, David Holmes wrote: On 4/06/2013 9:21 PM, Erik Joelsson wrote: On 2013-06-04 06:56, David Holmes wrote: I think we should add a (configure time?) check to watch for the illegal: BUILD_CRYPTO=no, OPENJDK=true. Not sure where that would fit. Configure is only setting

Re: Why does the Windows build look for Solaris source files ?

2013-06-06 Thread Tim Bell
Hi Phil: I created a stripped down platform-specific set of sources for the Windows build and although it doesn't look like it was fatal I see the following :- ## Starting jdk /usr/bin/find: `/cygdrive/c/jdks/jdk8_2d/jdk/src/solaris/classes': No such file or directory /usr/bin/find: `/cygdrive

Why does the Windows build look for Solaris source files ?

2013-06-06 Thread Phil Race
I created a stripped down platform-specific set of sources for the Windows build and although it doesn't look like it was fatal I see the following :- ## Starting jdk /usr/bin/find: `/cygdrive/c/jdks/jdk8_2d/jdk/src/solaris/classes': No such file or directory /usr/bin/find: `/cygdrive/c/jdks/jdk

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-06 Thread Mikael Gerdin
Dan, On 2013-06-06 15:57, Daniel D. Daugherty wrote: Mikael, Sorry for top posting a reply here, but the thread below is just getting too muddled. I'm not quite clear on why you keep trying to distinguish between something being a "#define" or being a bound linkage symbol. In either case, the

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-06 Thread Daniel D. Daugherty
Mikael, Sorry for top posting a reply here, but the thread below is just getting too muddled. I'm not quite clear on why you keep trying to distinguish between something being a "#define" or being a bound linkage symbol. In either case, the end result will be the same. The ostream.o module will

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-06 Thread Daniel D. Daugherty
On 6/6/13 3:10 AM, Mikael Gerdin wrote: Dan, On 2013-06-05 18:06, Daniel D. Daugherty wrote: On 6/5/13 10:02 AM, Mikael Gerdin wrote: Tao, On 2013-06-05 17:48, Tao Mao wrote: Thank you for comments. One thing I want to point out is that the current change has not touched on Windows code. Pl

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-06 Thread Mikael Gerdin
Tao, On 2013-06-05 19:03, Tao Mao wrote: Hi Mikael, Let me explain the changeset first before I go into your comments. Ok. (1) make/linux/makefiles/vm.make # Large File Support ifneq ($(LP64), 1) CXXFLAGS/ostream.o += -D_FILE_OFFSET_BITS=64 endif # ifneq ($(LP64), 1) For "Linux" code, se

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-06 Thread Mikael Gerdin
Dan, On 2013-06-05 18:06, Daniel D. Daugherty wrote: On 6/5/13 10:02 AM, Mikael Gerdin wrote: Tao, On 2013-06-05 17:48, Tao Mao wrote: Thank you for comments. One thing I want to point out is that the current change has not touched on Windows code. Please see inline. Tao On 6/5/13 1:19 AM,