Re: jdk8-lambda builds failing in hotspot for all platforms ( thread.hpp )

2013-06-19 Thread David Katleman
On 6/19/2013 8:18 PM, Mike Duigou wrote: I have pushed a sync of jdk8 b94 to lambda/hotspot. This should resolve the issue. Thanks Mike, I've started another build Dave On Jun 19 2013, at 19:20 , David Katleman wrote: All the jdk8-lambda nightly builds failed tonight, in hotspot, i

Re: jdk8-lambda builds failing in hotspot for all platforms ( thread.hpp )

2013-06-19 Thread Mike Duigou
I have pushed a sync of jdk8 b94 to lambda/hotspot. This should resolve the issue. Mike On Jun 19 2013, at 19:20 , David Katleman wrote: > All the jdk8-lambda nightly builds failed tonight, in hotspot, in thread.hpp > > https://jbs.oracle.com/bugs/browse/JDK-8017117 > http://bugs.sun.com/bugda

jdk8-lambda builds failing in hotspot for all platforms ( thread.hpp )

2013-06-19 Thread David Katleman
All the jdk8-lambda nightly builds failed tonight, in hotspot, in thread.hpp https://jbs.oracle.com/bugs/browse/JDK-8017117 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8017117 Thanks Dave http://rehudson.us.oracle.com:8080/hudson/job/2-build-solaris-sparc/2106/con

Re: RFR: 8016780: (xs) README-builds.html misses crucial requirement on bootstrap JDK

2013-06-19 Thread Kelly O'Hair
On Jun 17, 2013, at 5:21 PM, Stuart Marks wrote: > Hi Kelly! You still read this stuff here? :-) I read anything that looks entertaining from entertaining people. ;^) -kto

Re: RFR: 8016780: (xs) README-builds.html misses crucial requirement on bootstrap JDK

2013-06-19 Thread Stuart Marks
On 6/19/13 1:01 AM, Erik Joelsson wrote: Currently, configure checks that the found boot jdk is 7 or 8. Do we really want to actively prevent using 8 all together? I could agree to printing a big warning in the summary at the end of configure to discourage it, but I do believe it necessary to hav

Re: HSX-24: Code Review (round 0) request for MacOS X exported symbols fix (8014326)

2013-06-19 Thread Daniel D. Daugherty
Thanks for the reviews! Dan On 6/19/13 1:58 PM, Coleen Phillimore wrote: Dan, This looks good! Coleen On 6/18/2013 4:50 PM, Daniel D. Daugherty wrote: Greetings, I have picked up David Holmes' work on the following bug: 8014326 [OSX] All libjvm symbols are exported http://bugs.sun

Re: HSX-25: Code Review (round 0) request for MacOS X exported symbols fix (8014326)

2013-06-19 Thread Daniel D. Daugherty
Ron, Thanks for the review (HSX-25 version). Dan On 6/19/13 7:40 AM, Ron Durbin wrote: Dan These changes look good. Ron -Original Message- From: Daniel D. Daugherty Sent: Tuesday, June 18, 2013 2:30 PM To: hotspot-runtime-...@openjdk.java.net; build-dev Subject: HSX-25: Code Revie

Re: HSX-24: Code Review (round 0) request for MacOS X exported symbols fix (8014326)

2013-06-19 Thread Daniel D. Daugherty
Ron, Thanks for the review. Dan On 6/19/13 7:39 AM, Ron Durbin wrote: Dan These changes look good. Ron -Original Message- From: Daniel D. Daugherty Sent: Tuesday, June 18, 2013 2:50 PM To: hotspot-runtime-...@openjdk.java.net; build-dev Subject: HSX-24: Code Review (round 0) reque

Re: RFR: 8016780: (xs) README-builds.html misses crucial requirement on bootstrap JDK

2013-06-19 Thread Weijun Wang
On 6/19/2013 4:01 PM, Erik Joelsson wrote: Now ... circular dependencies ... urk ... I *knew* there was something that would make this complicated. Well, maybe these will need to be refactored away somehow. Or maybe some kind of GenStubs technique can be used to deal with the circularity. We

Re: RFR: 8016780: (xs) README-builds.html misses crucial requirement on bootstrap JDK

2013-06-19 Thread Weijun Wang
I'm not sure how big a warning needs to be to make people aware of it. Is it possible to create another configure option like --yes-i-do-want-to-use-n that you must add to set boot jdk to 8? --Max On 6/19/2013 5:23 PM, Chris Hegarty wrote: On 19/06/2013 09:01, Erik Joelsson wrote: On 2013-

RE: HSX-24: Code Review (round 0) request for MacOS X exported symbols fix (8014326)

2013-06-19 Thread Ron Durbin
Dan These changes look good. Ron > -Original Message- > From: Daniel D. Daugherty > Sent: Tuesday, June 18, 2013 2:50 PM > To: hotspot-runtime-...@openjdk.java.net; build-dev > Subject: HSX-24: Code Review (round 0) request for MacOS X exported symbols > fix (8014326) > > Greetings, >

RE: HSX-25: Code Review (round 0) request for MacOS X exported symbols fix (8014326)

2013-06-19 Thread Ron Durbin
Dan These changes look good. Ron > -Original Message- > From: Daniel D. Daugherty > Sent: Tuesday, June 18, 2013 2:30 PM > To: hotspot-runtime-...@openjdk.java.net; build-dev > Subject: HSX-25: Code Review (round 0) request for MacOS X exported symbols > fix (8014326) > > Greetings, >

RFR: 8017047: Can't use --with-java-devtools and --with-devkit at the same time

2013-06-19 Thread Erik Joelsson
Open part of this review: There is an artificial limitation put into configure that prevents usage of options --with-devkit and --with-tools-dir at the same time. The reason was probably because they could potentially be conflicting. This patch removes this check and makes them work together,

Re: RFR: 8016780: (xs) README-builds.html misses crucial requirement on bootstrap JDK

2013-06-19 Thread Alan Bateman
On 19/06/2013 09:01, Erik Joelsson wrote: : My preferred solution would be to fold in the repos that aren't upstream projects into jdk and just have them compile with the rest there. I much like the idea of reducing the number of repos. If that isn't possible, we can just add those source dir

Re: RFR: 8016780: (xs) README-builds.html misses crucial requirement on bootstrap JDK

2013-06-19 Thread Chris Hegarty
On 19/06/2013 09:01, Erik Joelsson wrote: On 2013-06-19 03:10, Stuart Marks wrote: -- I have half a mind to look at the Configure changes myself in my spare time (ha!), but I have no spare time, and I don't have the expertise in this area anyway. So anyone is welcome to pick this up. In princ

Re: RFR: 8016780: (xs) README-builds.html misses crucial requirement on bootstrap JDK

2013-06-19 Thread Erik Joelsson
On 2013-06-19 03:10, Stuart Marks wrote: -- I have half a mind to look at the Configure changes myself in my spare time (ha!), but I have no spare time, and I don't have the expertise in this area anyway. So anyone is welcome to pick this up. In principle it should be fairly simple, and I t